-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bundled Jacoco version #7736
Merged
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/bump-jacoco-version
Oct 7, 2024
Merged
Update bundled Jacoco version #7736
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/bump-jacoco-version
Oct 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
the
comp: ci visibility
Continuous Integration Visibility
label
Oct 4, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~451935f020, baseline=1.41.0-SNAPSHOT~dda483e2a1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1071929
Total [baseline] (10.397 s) : 0, 10397144
Agent [candidate] (1.072 s) : 0, 1072269
Total [candidate] (10.434 s) : 0, 10433935
section appsec
Agent [baseline] (1.212 s) : 0, 1212059
Total [baseline] (10.584 s) : 0, 10584152
Agent [candidate] (1.202 s) : 0, 1202480
Total [candidate] (10.602 s) : 0, 10602180
section iast
Agent [baseline] (1.193 s) : 0, 1192836
Total [baseline] (10.862 s) : 0, 10862185
Agent [candidate] (1.202 s) : 0, 1201562
Total [candidate] (10.835 s) : 0, 10835326
section profiling
Agent [baseline] (1.268 s) : 0, 1267606
Total [baseline] (10.651 s) : 0, 10651107
Agent [candidate] (1.264 s) : 0, 1264014
Total [candidate] (10.559 s) : 0, 10559170
gantt
title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~451935f020, baseline=1.41.0-SNAPSHOT~dda483e2a1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.661 ms) : 0, 684661
BytebuddyAgent [candidate] (684.917 ms) : 0, 684917
GlobalTracer [baseline] (311.192 ms) : 0, 311192
GlobalTracer [candidate] (311.363 ms) : 0, 311363
AppSec [baseline] (54.116 ms) : 0, 54116
AppSec [candidate] (53.919 ms) : 0, 53919
Remote Config [baseline] (658.532 µs) : 0, 659
Remote Config [candidate] (669.756 µs) : 0, 670
Telemetry [baseline] (7.618 ms) : 0, 7618
Telemetry [candidate] (7.689 ms) : 0, 7689
section appsec
BytebuddyAgent [baseline] (705.758 ms) : 0, 705758
BytebuddyAgent [candidate] (699.587 ms) : 0, 699587
GlobalTracer [baseline] (310.123 ms) : 0, 310123
GlobalTracer [candidate] (307.407 ms) : 0, 307407
AppSec [baseline] (162.982 ms) : 0, 162982
AppSec [candidate] (163.269 ms) : 0, 163269
Remote Config [baseline] (652.184 µs) : 0, 652
Remote Config [candidate] (641.366 µs) : 0, 641
Telemetry [baseline] (9.019 ms) : 0, 9019
Telemetry [candidate] (8.173 ms) : 0, 8173
IAST [baseline] (19.499 ms) : 0, 19499
IAST [candidate] (19.473 ms) : 0, 19473
section iast
BytebuddyAgent [baseline] (794.733 ms) : 0, 794733
BytebuddyAgent [candidate] (801.216 ms) : 0, 801216
GlobalTracer [baseline] (298.705 ms) : 0, 298705
GlobalTracer [candidate] (300.437 ms) : 0, 300437
AppSec [baseline] (53.095 ms) : 0, 53095
AppSec [candidate] (54.039 ms) : 0, 54039
Remote Config [baseline] (605.706 µs) : 0, 606
Remote Config [candidate] (608.536 µs) : 0, 609
Telemetry [baseline] (6.978 ms) : 0, 6978
Telemetry [candidate] (7.059 ms) : 0, 7059
IAST [baseline] (25.093 ms) : 0, 25093
IAST [candidate] (24.463 ms) : 0, 24463
section profiling
BytebuddyAgent [baseline] (674.732 ms) : 0, 674732
BytebuddyAgent [candidate] (674.525 ms) : 0, 674525
GlobalTracer [baseline] (394.631 ms) : 0, 394631
GlobalTracer [candidate] (391.843 ms) : 0, 391843
AppSec [baseline] (54.76 ms) : 0, 54760
AppSec [candidate] (54.528 ms) : 0, 54528
Remote Config [baseline] (652.205 µs) : 0, 652
Remote Config [candidate] (672.737 µs) : 0, 673
Telemetry [baseline] (7.457 ms) : 0, 7457
Telemetry [candidate] (7.438 ms) : 0, 7438
ProfilingAgent [baseline] (96.839 ms) : 0, 96839
ProfilingAgent [candidate] (96.47 ms) : 0, 96470
Profiling [baseline] (96.863 ms) : 0, 96863
Profiling [candidate] (96.494 ms) : 0, 96494
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~451935f020, baseline=1.41.0-SNAPSHOT~dda483e2a1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.074 s) : 0, 1073693
Total [baseline] (8.562 s) : 0, 8561849
Agent [candidate] (1.066 s) : 0, 1066082
Total [candidate] (8.533 s) : 0, 8533279
section iast
Agent [baseline] (1.193 s) : 0, 1192586
Total [baseline] (9.076 s) : 0, 9075596
Agent [candidate] (1.193 s) : 0, 1193438
Total [candidate] (9.082 s) : 0, 9082404
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.193 s) : 0, 1193152
Total [baseline] (9.08 s) : 0, 9080234
Agent [candidate] (1.193 s) : 0, 1193056
Total [candidate] (9.043 s) : 0, 9042942
section iast_TELEMETRY_OFF
Agent [baseline] (1.201 s) : 0, 1200651
Total [baseline] (9.078 s) : 0, 9077705
Agent [candidate] (1.191 s) : 0, 1190563
Total [candidate] (9.104 s) : 0, 9104398
gantt
title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~451935f020, baseline=1.41.0-SNAPSHOT~dda483e2a1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.37 ms) : 0, 685370
BytebuddyAgent [candidate] (680.739 ms) : 0, 680739
GlobalTracer [baseline] (312.119 ms) : 0, 312119
GlobalTracer [candidate] (310.034 ms) : 0, 310034
AppSec [baseline] (54.065 ms) : 0, 54065
AppSec [candidate] (53.5 ms) : 0, 53500
Remote Config [baseline] (674.516 µs) : 0, 675
Remote Config [candidate] (657.423 µs) : 0, 657
Telemetry [baseline] (7.689 ms) : 0, 7689
Telemetry [candidate] (7.515 ms) : 0, 7515
section iast
BytebuddyAgent [baseline] (794.991 ms) : 0, 794991
BytebuddyAgent [candidate] (795.844 ms) : 0, 795844
GlobalTracer [baseline] (298.506 ms) : 0, 298506
GlobalTracer [candidate] (298.029 ms) : 0, 298029
AppSec [baseline] (55.171 ms) : 0, 55171
AppSec [candidate] (53.718 ms) : 0, 53718
IAST [baseline] (22.655 ms) : 0, 22655
IAST [candidate] (24.506 ms) : 0, 24506
Remote Config [baseline] (605.572 µs) : 0, 606
Remote Config [candidate] (605.124 µs) : 0, 605
Telemetry [baseline] (7.025 ms) : 0, 7025
Telemetry [candidate] (7.031 ms) : 0, 7031
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (794.743 ms) : 0, 794743
BytebuddyAgent [candidate] (794.496 ms) : 0, 794496
GlobalTracer [baseline] (299.215 ms) : 0, 299215
GlobalTracer [candidate] (299.339 ms) : 0, 299339
AppSec [baseline] (55.257 ms) : 0, 55257
AppSec [candidate] (55.165 ms) : 0, 55165
IAST [baseline] (22.623 ms) : 0, 22623
IAST [candidate] (22.693 ms) : 0, 22693
Remote Config [baseline] (596.969 µs) : 0, 597
Remote Config [candidate] (613.855 µs) : 0, 614
Telemetry [baseline] (7.033 ms) : 0, 7033
Telemetry [candidate] (7.062 ms) : 0, 7062
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (799.446 ms) : 0, 799446
BytebuddyAgent [candidate] (792.122 ms) : 0, 792122
GlobalTracer [baseline] (300.958 ms) : 0, 300958
GlobalTracer [candidate] (299.16 ms) : 0, 299160
AppSec [baseline] (52.987 ms) : 0, 52987
AppSec [candidate] (52.659 ms) : 0, 52659
IAST [baseline] (25.857 ms) : 0, 25857
IAST [candidate] (25.345 ms) : 0, 25345
Remote Config [baseline] (624.28 µs) : 0, 624
Remote Config [candidate] (619.576 µs) : 0, 620
Telemetry [baseline] (6.991 ms) : 0, 6991
Telemetry [candidate] (6.982 ms) : 0, 6982
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~451935f020, baseline=1.41.0-SNAPSHOT~dda483e2a1
dateFormat X
axisFormat %s
section baseline
no_agent (371.219 µs) : 352, 391
. : milestone, 371,
iast (479.693 µs) : 459, 501
. : milestone, 480,
iast_FULL (551.566 µs) : 531, 573
. : milestone, 552,
iast_GLOBAL (507.802 µs) : 487, 529
. : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (485.932 µs) : 464, 508
. : milestone, 486,
iast_INACTIVE (444.203 µs) : 424, 465
. : milestone, 444,
iast_TELEMETRY_OFF (470.253 µs) : 449, 491
. : milestone, 470,
tracing (439.327 µs) : 419, 460
. : milestone, 439,
section candidate
no_agent (371.51 µs) : 352, 391
. : milestone, 372,
iast (488.749 µs) : 468, 510
. : milestone, 489,
iast_FULL (551.648 µs) : 531, 573
. : milestone, 552,
iast_GLOBAL (516.234 µs) : 493, 539
. : milestone, 516,
iast_HARDCODED_SECRET_DISABLED (489.627 µs) : 468, 511
. : milestone, 490,
iast_INACTIVE (448.245 µs) : 427, 469
. : milestone, 448,
iast_TELEMETRY_OFF (481.042 µs) : 460, 502
. : milestone, 481,
tracing (445.328 µs) : 425, 466
. : milestone, 445,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~451935f020, baseline=1.41.0-SNAPSHOT~dda483e2a1
dateFormat X
axisFormat %s
section baseline
no_agent (1.35 ms) : 1331, 1369
. : milestone, 1350,
appsec (1.711 ms) : 1687, 1734
. : milestone, 1711,
appsec_no_iast (1.725 ms) : 1701, 1749
. : milestone, 1725,
iast (1.469 ms) : 1446, 1492
. : milestone, 1469,
profiling (1.495 ms) : 1469, 1520
. : milestone, 1495,
tracing (1.484 ms) : 1460, 1508
. : milestone, 1484,
section candidate
no_agent (1.347 ms) : 1327, 1366
. : milestone, 1347,
appsec (1.725 ms) : 1701, 1749
. : milestone, 1725,
appsec_no_iast (1.732 ms) : 1708, 1756
. : milestone, 1732,
iast (1.489 ms) : 1467, 1511
. : milestone, 1489,
profiling (1.514 ms) : 1488, 1540
. : milestone, 1514,
tracing (1.469 ms) : 1445, 1493
. : milestone, 1469,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~451935f020, baseline=1.41.0-SNAPSHOT~dda483e2a1
dateFormat X
axisFormat %s
section baseline
no_agent (15.074 s) : 15074000, 15074000
. : milestone, 15074000,
appsec (15.299 s) : 15299000, 15299000
. : milestone, 15299000,
iast (18.952 s) : 18952000, 18952000
. : milestone, 18952000,
iast_GLOBAL (18.061 s) : 18061000, 18061000
. : milestone, 18061000,
profiling (15.157 s) : 15157000, 15157000
. : milestone, 15157000,
tracing (15.256 s) : 15256000, 15256000
. : milestone, 15256000,
section candidate
no_agent (15.078 s) : 15078000, 15078000
. : milestone, 15078000,
appsec (15.373 s) : 15373000, 15373000
. : milestone, 15373000,
iast (18.879 s) : 18879000, 18879000
. : milestone, 18879000,
iast_GLOBAL (18.146 s) : 18146000, 18146000
. : milestone, 18146000,
profiling (15.439 s) : 15439000, 15439000
. : milestone, 15439000,
tracing (15.072 s) : 15072000, 15072000
. : milestone, 15072000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~451935f020, baseline=1.41.0-SNAPSHOT~dda483e2a1
dateFormat X
axisFormat %s
section baseline
no_agent (1.466 ms) : 1455, 1478
. : milestone, 1466,
appsec (2.339 ms) : 2298, 2379
. : milestone, 2339,
iast (2.07 ms) : 2019, 2121
. : milestone, 2070,
iast_GLOBAL (2.121 ms) : 2070, 2173
. : milestone, 2121,
profiling (1.953 ms) : 1912, 1993
. : milestone, 1953,
tracing (1.923 ms) : 1883, 1963
. : milestone, 1923,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (2.333 ms) : 2292, 2373
. : milestone, 2333,
iast (2.09 ms) : 2038, 2142
. : milestone, 2090,
iast_GLOBAL (2.127 ms) : 2075, 2180
. : milestone, 2127,
profiling (1.938 ms) : 1897, 1978
. : milestone, 1938,
tracing (1.924 ms) : 1885, 1964
. : milestone, 1924,
|
nikita-tkachenko-datadog
force-pushed
the
nikita-tkachenko/bump-jacoco-version
branch
from
October 7, 2024 08:58
4370636
to
451935f
Compare
PerfectSlayer
approved these changes
Oct 7, 2024
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/bump-jacoco-version
branch
October 7, 2024 15:16
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Updates Jacoco version that is bundled with the tracer.
Motivation
Jacoco is used, among other things, for parsing coverage data gathered by the JVMs that run the tests.
If the customer's project is using a newer version of Jacoco, the coverage data may not be compatible with the older version that the tracer uses.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: SDTEST-998