Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🍒 7699] Prevent publishing the same usr.id to the WAF twice #7709

Merged
merged 1 commit into from
Oct 2, 2024
Merged

[🍒 7699] Prevent publishing the same usr.id to the WAF twice #7709

merged 1 commit into from
Oct 2, 2024

Conversation

manuel-alvarez-alvarez
Copy link
Member

Backport #7699 to release/v1.40.x

@manuel-alvarez-alvarez manuel-alvarez-alvarez requested a review from a team as a code owner October 2, 2024 10:32
@manuel-alvarez-alvarez manuel-alvarez-alvarez added tag: performance Performance related changes comp: asm waf Application Security Management (WAF) labels Oct 2, 2024
@pr-commenter
Copy link

pr-commenter bot commented Oct 2, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/backport-pr-7699
git_commit_date 1727863496 1727865131
git_commit_sha 4eeed47 4de8cea
release_version 1.41.0-SNAPSHOT~4eeed47ee9 1.41.0-SNAPSHOT~4de8ceacb5
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727867455 1727867455
ci_job_id 658302479 658302479
ci_pipeline_id 45590102 45590102
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 52 metrics, 10 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:petclinic:iast:Remote Config worse
[+12.390µs; +48.085µs] or [+2.065%; +8.013%]		 630.356µs 600.119µs
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~4de8ceacb5, baseline=1.41.0-SNAPSHOT~4eeed47ee9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1069007
Total [baseline] (8.558 s) : 0, 8558355
Agent [candidate] (1.067 s) : 0, 1066711
Total [candidate] (8.555 s) : 0, 8554676
section iast
Agent [baseline] (1.193 s) : 0, 1192916
Total [baseline] (9.071 s) : 0, 9070784
Agent [candidate] (1.194 s) : 0, 1193995
Total [candidate] (9.097 s) : 0, 9097091
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.194 s) : 0, 1194332
Total [baseline] (9.055 s) : 0, 9055445
Agent [candidate] (1.195 s) : 0, 1194707
Total [candidate] (9.054 s) : 0, 9054096
section iast_TELEMETRY_OFF
Agent [baseline] (1.19 s) : 0, 1190213
Total [baseline] (9.052 s) : 0, 9051925
Agent [candidate] (1.189 s) : 0, 1189352
Total [candidate] (9.063 s) : 0, 9062596
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.069 s -
Agent iast 1.193 s 123.91 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.194 s 125.325 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.19 s 121.206 ms (11.3%)
Total tracing 8.558 s -
Total iast 9.071 s 512.429 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.055 s 497.09 ms (5.8%)
Total iast_TELEMETRY_OFF 9.052 s 493.57 ms (5.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.067 s -
Agent iast 1.194 s 127.284 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.195 s 127.996 ms (12.0%)
Agent iast_TELEMETRY_OFF 1.189 s 122.641 ms (11.5%)
Total tracing 8.555 s -
Total iast 9.097 s 542.415 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.054 s 499.42 ms (5.8%)
Total iast_TELEMETRY_OFF 9.063 s 507.92 ms (5.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~4de8ceacb5, baseline=1.41.0-SNAPSHOT~4eeed47ee9

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.958 ms) : 0, 682958
BytebuddyAgent [candidate] (680.834 ms) : 0, 680834
GlobalTracer [baseline] (310.408 ms) : 0, 310408
GlobalTracer [candidate] (310.095 ms) : 0, 310095
AppSec [baseline] (53.687 ms) : 0, 53687
AppSec [candidate] (53.864 ms) : 0, 53864
Remote Config [baseline] (657.705 µs) : 0, 658
Remote Config [candidate] (669.928 µs) : 0, 670
Telemetry [baseline] (7.656 ms) : 0, 7656
Telemetry [candidate] (7.601 ms) : 0, 7601
section iast
BytebuddyAgent [baseline] (795.145 ms) : 0, 795145
BytebuddyAgent [candidate] (795.313 ms) : 0, 795313
GlobalTracer [baseline] (298.434 ms) : 0, 298434
GlobalTracer [candidate] (299.247 ms) : 0, 299247
AppSec [baseline] (52.968 ms) : 0, 52968
AppSec [candidate] (53.814 ms) : 0, 53814
IAST [baseline] (25.101 ms) : 0, 25101
IAST [candidate] (24.335 ms) : 0, 24335
Remote Config [baseline] (606.82 µs) : 0, 607
Remote Config [candidate] (624.577 µs) : 0, 625
Telemetry [baseline] (7.039 ms) : 0, 7039
Telemetry [candidate] (6.965 ms) : 0, 6965
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (795.927 ms) : 0, 795927
BytebuddyAgent [candidate] (795.176 ms) : 0, 795176
GlobalTracer [baseline] (298.89 ms) : 0, 298890
GlobalTracer [candidate] (299.582 ms) : 0, 299582
AppSec [baseline] (54.592 ms) : 0, 54592
AppSec [candidate] (53.304 ms) : 0, 53304
IAST [baseline] (23.557 ms) : 0, 23557
IAST [candidate] (25.345 ms) : 0, 25345
Remote Config [baseline] (600.423 µs) : 0, 600
Remote Config [candidate] (615.125 µs) : 0, 615
Telemetry [baseline] (7.056 ms) : 0, 7056
Telemetry [candidate] (6.96 ms) : 0, 6960
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (792.351 ms) : 0, 792351
BytebuddyAgent [candidate] (790.436 ms) : 0, 790436
GlobalTracer [baseline] (298.423 ms) : 0, 298423
GlobalTracer [candidate] (299.857 ms) : 0, 299857
AppSec [baseline] (55.915 ms) : 0, 55915
AppSec [candidate] (55.444 ms) : 0, 55444
IAST [baseline] (22.368 ms) : 0, 22368
IAST [candidate] (22.455 ms) : 0, 22455
Remote Config [baseline] (598.823 µs) : 0, 599
Remote Config [candidate] (611.873 µs) : 0, 612
Telemetry [baseline] (6.913 ms) : 0, 6913
Telemetry [candidate] (6.87 ms) : 0, 6870
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~4de8ceacb5, baseline=1.41.0-SNAPSHOT~4eeed47ee9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065098
Total [baseline] (10.303 s) : 0, 10302557
Agent [candidate] (1.067 s) : 0, 1066897
Total [candidate] (10.437 s) : 0, 10436950
section appsec
Agent [baseline] (1.216 s) : 0, 1216434
Total [baseline] (10.645 s) : 0, 10644681
Agent [candidate] (1.199 s) : 0, 1198642
Total [candidate] (10.578 s) : 0, 10578230
section iast
Agent [baseline] (1.195 s) : 0, 1194676
Total [baseline] (10.802 s) : 0, 10801968
Agent [candidate] (1.193 s) : 0, 1193370
Total [candidate] (10.866 s) : 0, 10865931
section profiling
Agent [baseline] (1.262 s) : 0, 1262447
Total [baseline] (10.614 s) : 0, 10614285
Agent [candidate] (1.264 s) : 0, 1263920
Total [candidate] (10.622 s) : 0, 10622376
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent appsec 1.216 s 151.336 ms (14.2%)
Agent iast 1.195 s 129.578 ms (12.2%)
Agent profiling 1.262 s 197.349 ms (18.5%)
Total tracing 10.303 s -
Total appsec 10.645 s 342.124 ms (3.3%)
Total iast 10.802 s 499.411 ms (4.8%)
Total profiling 10.614 s 311.728 ms (3.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.067 s -
Agent appsec 1.199 s 131.746 ms (12.3%)
Agent iast 1.193 s 126.473 ms (11.9%)
Agent profiling 1.264 s 197.024 ms (18.5%)
Total tracing 10.437 s -
Total appsec 10.578 s 141.28 ms (1.4%)
Total iast 10.866 s 428.981 ms (4.1%)
Total profiling 10.622 s 185.426 ms (1.8%) 
gantt
    title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~4de8ceacb5, baseline=1.41.0-SNAPSHOT~4eeed47ee9

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.318 ms) : 0, 680318
BytebuddyAgent [candidate] (681.275 ms) : 0, 681275
GlobalTracer [baseline] (309.318 ms) : 0, 309318
GlobalTracer [candidate] (309.952 ms) : 0, 309952
AppSec [baseline] (53.638 ms) : 0, 53638
AppSec [candidate] (53.767 ms) : 0, 53767
Remote Config [baseline] (653.882 µs) : 0, 654
Remote Config [candidate] (660.078 µs) : 0, 660
Telemetry [baseline] (7.578 ms) : 0, 7578
Telemetry [candidate] (7.593 ms) : 0, 7593
section appsec
BytebuddyAgent [baseline] (708.439 ms) : 0, 708439
BytebuddyAgent [candidate] (696.873 ms) : 0, 696873
GlobalTracer [baseline] (310.27 ms) : 0, 310270
GlobalTracer [candidate] (306.842 ms) : 0, 306842
AppSec [baseline] (163.051 ms) : 0, 163051
AppSec [candidate] (161.331 ms) : 0, 161331
Remote Config [baseline] (653.703 µs) : 0, 654
Remote Config [candidate] (639.737 µs) : 0, 640
Telemetry [baseline] (8.933 ms) : 0, 8933
Telemetry [candidate] (8.541 ms) : 0, 8541
IAST [baseline] (22.588 ms) : 0, 22588
IAST [candidate] (21.598 ms) : 0, 21598
section iast
BytebuddyAgent [baseline] (796.175 ms) : 0, 796175
BytebuddyAgent [candidate] (794.816 ms) : 0, 794816
GlobalTracer [baseline] (298.819 ms) : 0, 298819
GlobalTracer [candidate] (298.842 ms) : 0, 298842
AppSec [baseline] (52.68 ms) : 0, 52680
AppSec [candidate] (52.283 ms) : 0, 52283
Remote Config [baseline] (600.118 µs) : 0, 600
Remote Config [candidate] (630.356 µs) : 0, 630
Telemetry [baseline] (7.002 ms) : 0, 7002
Telemetry [candidate] (6.987 ms) : 0, 6987
IAST [baseline] (25.776 ms) : 0, 25776
IAST [candidate] (26.179 ms) : 0, 26179
section profiling
BytebuddyAgent [baseline] (673.171 ms) : 0, 673171
BytebuddyAgent [candidate] (673.958 ms) : 0, 673958
GlobalTracer [baseline] (392.15 ms) : 0, 392150
GlobalTracer [candidate] (392.619 ms) : 0, 392619
AppSec [baseline] (54.648 ms) : 0, 54648
AppSec [candidate] (54.701 ms) : 0, 54701
Remote Config [baseline] (644.752 µs) : 0, 645
Remote Config [candidate] (651.942 µs) : 0, 652
Telemetry [baseline] (7.395 ms) : 0, 7395
Telemetry [candidate] (7.454 ms) : 0, 7454
ProfilingAgent [baseline] (95.946 ms) : 0, 95946
ProfilingAgent [candidate] (96.025 ms) : 0, 96025
Profiling [baseline] (95.97 ms) : 0, 95970
Profiling [candidate] (96.049 ms) : 0, 96049
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-02T10:41:29 2024-10-02T10:48:19
git_branch master malvarez/backport-pr-7699
git_commit_date 1727863496 1727865131
git_commit_sha 4eeed47 4de8cea
release_version 1.41.0-SNAPSHOT~4eeed47ee9 1.41.0-SNAPSHOT~4de8ceacb5
start_time 2024-10-02T10:41:16 2024-10-02T10:48:06
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727866446 1727866446
ci_job_id 658302480 658302480
ci_pipeline_id 45590102 45590102
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~4de8ceacb5, baseline=1.41.0-SNAPSHOT~4eeed47ee9
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.153 µs) : 353, 392
.   : milestone, 372,
iast (482.757 µs) : 461, 504
.   : milestone, 483,
iast_FULL (555.005 µs) : 534, 576
.   : milestone, 555,
iast_GLOBAL (514.027 µs) : 491, 537
.   : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (480.508 µs) : 460, 502
.   : milestone, 481,
iast_INACTIVE (445.719 µs) : 425, 466
.   : milestone, 446,
iast_TELEMETRY_OFF (471.304 µs) : 450, 492
.   : milestone, 471,
tracing (439.616 µs) : 419, 460
.   : milestone, 440,
section candidate
no_agent (367.82 µs) : 348, 387
.   : milestone, 368,
iast (490.853 µs) : 469, 513
.   : milestone, 491,
iast_FULL (551.837 µs) : 531, 573
.   : milestone, 552,
iast_GLOBAL (509.921 µs) : 488, 532
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (485.9 µs) : 465, 507
.   : milestone, 486,
iast_INACTIVE (453.668 µs) : 432, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (470.853 µs) : 450, 492
.   : milestone, 471,
tracing (439.899 µs) : 420, 460
.   : milestone, 440,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.153 µs [352.785 µs, 391.52 µs] -
iast 482.757 µs [461.477 µs, 504.037 µs] 110.604 µs (29.7%)
iast_FULL 555.005 µs [533.804 µs, 576.207 µs] 182.853 µs (49.1%)
iast_GLOBAL 514.027 µs [490.948 µs, 537.106 µs] 141.874 µs (38.1%)
iast_HARDCODED_SECRET_DISABLED 480.508 µs [459.502 µs, 501.515 µs] 108.356 µs (29.1%)
iast_INACTIVE 445.719 µs [424.977 µs, 466.461 µs] 73.567 µs (19.8%)
iast_TELEMETRY_OFF 471.304 µs [450.317 µs, 492.291 µs] 99.151 µs (26.6%)
tracing 439.616 µs [419.34 µs, 459.891 µs] 67.463 µs (18.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.82 µs [348.324 µs, 387.316 µs] -
iast 490.853 µs [468.802 µs, 512.904 µs] 123.033 µs (33.4%)
iast_FULL 551.837 µs [530.679 µs, 572.994 µs] 184.017 µs (50.0%)
iast_GLOBAL 509.921 µs [487.717 µs, 532.125 µs] 142.101 µs (38.6%)
iast_HARDCODED_SECRET_DISABLED 485.9 µs [464.569 µs, 507.23 µs] 118.08 µs (32.1%)
iast_INACTIVE 453.668 µs [432.049 µs, 475.287 µs] 85.848 µs (23.3%)
iast_TELEMETRY_OFF 470.853 µs [449.828 µs, 491.878 µs] 103.034 µs (28.0%)
tracing 439.899 µs [419.573 µs, 460.225 µs] 72.08 µs (19.6%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~4de8ceacb5, baseline=1.41.0-SNAPSHOT~4eeed47ee9
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.332 ms) : 1313, 1351
.   : milestone, 1332,
appsec (1.718 ms) : 1694, 1742
.   : milestone, 1718,
appsec_no_iast (1.732 ms) : 1708, 1756
.   : milestone, 1732,
iast (1.472 ms) : 1449, 1494
.   : milestone, 1472,
profiling (1.472 ms) : 1448, 1496
.   : milestone, 1472,
tracing (1.452 ms) : 1427, 1477
.   : milestone, 1452,
section candidate
no_agent (1.344 ms) : 1325, 1364
.   : milestone, 1344,
appsec (1.726 ms) : 1701, 1750
.   : milestone, 1726,
appsec_no_iast (1.728 ms) : 1704, 1752
.   : milestone, 1728,
iast (1.466 ms) : 1444, 1488
.   : milestone, 1466,
profiling (1.48 ms) : 1457, 1503
.   : milestone, 1480,
tracing (1.459 ms) : 1434, 1483
.   : milestone, 1459,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.332 ms [1.313 ms, 1.351 ms] -
appsec 1.718 ms [1.694 ms, 1.742 ms] 386.049 µs (29.0%)
appsec_no_iast 1.732 ms [1.708 ms, 1.756 ms] 399.665 µs (30.0%)
iast 1.472 ms [1.449 ms, 1.494 ms] 139.769 µs (10.5%)
profiling 1.472 ms [1.448 ms, 1.496 ms] 139.673 µs (10.5%)
tracing 1.452 ms [1.427 ms, 1.477 ms] 120.118 µs (9.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.344 ms [1.325 ms, 1.364 ms] -
appsec 1.726 ms [1.701 ms, 1.75 ms] 381.198 µs (28.4%)
appsec_no_iast 1.728 ms [1.704 ms, 1.752 ms] 383.429 µs (28.5%)
iast 1.466 ms [1.444 ms, 1.488 ms] 121.716 µs (9.1%)
profiling 1.48 ms [1.457 ms, 1.503 ms] 135.486 µs (10.1%)
tracing 1.459 ms [1.434 ms, 1.483 ms] 114.296 µs (8.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/backport-pr-7699
git_commit_date 1727863496 1727865131
git_commit_sha 4eeed47 4de8cea
release_version 1.41.0-SNAPSHOT~4eeed47ee9 1.41.0-SNAPSHOT~4de8ceacb5
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1727867002 1727867002
ci_job_id 658302481 658302481
ci_pipeline_id 45590102 45590102
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~4de8ceacb5, baseline=1.41.0-SNAPSHOT~4eeed47ee9
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
.   : milestone, 1469,
appsec (2.318 ms) : 2278, 2358
.   : milestone, 2318,
iast (2.077 ms) : 2026, 2128
.   : milestone, 2077,
iast_GLOBAL (2.116 ms) : 2064, 2167
.   : milestone, 2116,
profiling (1.936 ms) : 1896, 1977
.   : milestone, 1936,
tracing (1.915 ms) : 1876, 1954
.   : milestone, 1915,
section candidate
no_agent (1.475 ms) : 1463, 1486
.   : milestone, 1475,
appsec (2.318 ms) : 2278, 2358
.   : milestone, 2318,
iast (2.072 ms) : 2021, 2124
.   : milestone, 2072,
iast_GLOBAL (2.117 ms) : 2065, 2169
.   : milestone, 2117,
profiling (1.939 ms) : 1898, 1980
.   : milestone, 1939,
tracing (1.923 ms) : 1883, 1962
.   : milestone, 1923,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.458 ms, 1.481 ms] -
appsec 2.318 ms [2.278 ms, 2.358 ms] 849.051 µs (57.8%)
iast 2.077 ms [2.026 ms, 2.128 ms] 607.878 µs (41.4%)
iast_GLOBAL 2.116 ms [2.064 ms, 2.167 ms] 646.385 µs (44.0%)
profiling 1.936 ms [1.896 ms, 1.977 ms] 467.3 µs (31.8%)
tracing 1.915 ms [1.876 ms, 1.954 ms] 445.988 µs (30.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.463 ms, 1.486 ms] -
appsec 2.318 ms [2.278 ms, 2.358 ms] 843.169 µs (57.2%)
iast 2.072 ms [2.021 ms, 2.124 ms] 597.603 µs (40.5%)
iast_GLOBAL 2.117 ms [2.065 ms, 2.169 ms] 642.512 µs (43.6%)
profiling 1.939 ms [1.898 ms, 1.98 ms] 464.373 µs (31.5%)
tracing 1.923 ms [1.883 ms, 1.962 ms] 448.359 µs (30.4%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~4de8ceacb5, baseline=1.41.0-SNAPSHOT~4eeed47ee9
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.079 s) : 15079000, 15079000
.   : milestone, 15079000,
appsec (15.17 s) : 15170000, 15170000
.   : milestone, 15170000,
iast (18.937 s) : 18937000, 18937000
.   : milestone, 18937000,
iast_GLOBAL (18.161 s) : 18161000, 18161000
.   : milestone, 18161000,
profiling (14.88 s) : 14880000, 14880000
.   : milestone, 14880000,
tracing (15.577 s) : 15577000, 15577000
.   : milestone, 15577000,
section candidate
no_agent (15.107 s) : 15107000, 15107000
.   : milestone, 15107000,
appsec (15.319 s) : 15319000, 15319000
.   : milestone, 15319000,
iast (18.888 s) : 18888000, 18888000
.   : milestone, 18888000,
iast_GLOBAL (18.107 s) : 18107000, 18107000
.   : milestone, 18107000,
profiling (15.197 s) : 15197000, 15197000
.   : milestone, 15197000,
tracing (15.357 s) : 15357000, 15357000
.   : milestone, 15357000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.079 s [15.079 s, 15.079 s] -
appsec 15.17 s [15.17 s, 15.17 s] 91.0 ms (0.6%)
iast 18.937 s [18.937 s, 18.937 s] 3.858 s (25.6%)
iast_GLOBAL 18.161 s [18.161 s, 18.161 s] 3.082 s (20.4%)
profiling 14.88 s [14.88 s, 14.88 s] -199.0 ms (-1.3%)
tracing 15.577 s [15.577 s, 15.577 s] 498.0 ms (3.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.107 s [15.107 s, 15.107 s] -
appsec 15.319 s [15.319 s, 15.319 s] 212.0 ms (1.4%)
iast 18.888 s [18.888 s, 18.888 s] 3.781 s (25.0%)
iast_GLOBAL 18.107 s [18.107 s, 18.107 s] 3.0 s (19.9%)
profiling 15.197 s [15.197 s, 15.197 s] 90.0 ms (0.6%)
tracing 15.357 s [15.357 s, 15.357 s] 250.0 ms (1.7%)

@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit 13a7a4f into release/v1.40.x Oct 2, 2024
101 checks passed
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/backport-pr-7699 branch October 2, 2024 11:22
@github-actions github-actions bot added this to the 1.40.1 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariovido Mariovido Mariovido approved these changes

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/asm-java

@jandro996 jandro996 Awaiting requested review from jandro996 jandro996 is a code owner automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: asm waf Application Security Management (WAF) tag: performance Performance related changes
Projects
None yet
Milestone
1.40.1
Development

Successfully merging this pull request may close these issues.
2 participants
@manuel-alvarez-alvarez @Mariovido