Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent publishing the same usr.id to the WAF twice #7699

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Prevent publishing the same usr.id to the WAF twice #7699

merged 1 commit into from
Oct 2, 2024
+61 −9

Conversation

manuel-alvarez-alvarez
Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez commented Oct 1, 2024 •
edited
Loading

What Does This Do

Avoid publishing the same usr.id to the WAF more than once in a request.

Motivation

Calls to the WAF are expensive due to the switch between java and native code, this PR should reduce the number of jumps.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@manuel-alvarez-alvarez manuel-alvarez-alvarez added tag: performance Performance related changes comp: asm waf Application Security Management (WAF) labels Oct 1, 2024
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested a review from a team as a code owner October 1, 2024 12:20
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/waf-do-not-publish-dup-user-ids branch 2 times, most recently from ebe35c3 to 42af107 Compare October 1, 2024 12:28
@pr-commenter
Copy link

pr-commenter bot commented Oct 1, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/waf-do-not-publish-dup-user-ids
git_commit_date 1727856557 1727856647
git_commit_sha 0a80d67 c9bb1ba
release_version 1.41.0-SNAPSHOT~0a80d676b0 1.41.0-SNAPSHOT~c9bb1bacc4
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727859158 1727859158
ci_job_id 658129707 658129707
ci_pipeline_id 45580378 45580378
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~c9bb1bacc4, baseline=1.41.0-SNAPSHOT~0a80d676b0

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1072044
Total [baseline] (10.459 s) : 0, 10458981
Agent [candidate] (1.071 s) : 0, 1071403
Total [candidate] (10.475 s) : 0, 10475097
section appsec
Agent [baseline] (1.208 s) : 0, 1208058
Total [baseline] (10.672 s) : 0, 10672484
Agent [candidate] (1.21 s) : 0, 1210411
Total [candidate] (10.652 s) : 0, 10652494
section iast
Agent [baseline] (1.201 s) : 0, 1200661
Total [baseline] (10.884 s) : 0, 10883644
Agent [candidate] (1.201 s) : 0, 1201000
Total [candidate] (10.874 s) : 0, 10873692
section profiling
Agent [baseline] (1.271 s) : 0, 1271014
Total [baseline] (10.641 s) : 0, 10641487
Agent [candidate] (1.279 s) : 0, 1279429
Total [candidate] (10.676 s) : 0, 10676350
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.072 s -
Agent appsec 1.208 s 136.015 ms (12.7%)
Agent iast 1.201 s 128.618 ms (12.0%)
Agent profiling 1.271 s 198.97 ms (18.6%)
Total tracing 10.459 s -
Total appsec 10.672 s 213.503 ms (2.0%)
Total iast 10.884 s 424.663 ms (4.1%)
Total profiling 10.641 s 182.506 ms (1.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.071 s -
Agent appsec 1.21 s 139.008 ms (13.0%)
Agent iast 1.201 s 129.597 ms (12.1%)
Agent profiling 1.279 s 208.027 ms (19.4%)
Total tracing 10.475 s -
Total appsec 10.652 s 177.397 ms (1.7%)
Total iast 10.874 s 398.595 ms (3.8%)
Total profiling 10.676 s 201.252 ms (1.9%) 
gantt
    title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~c9bb1bacc4, baseline=1.41.0-SNAPSHOT~0a80d676b0

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.851 ms) : 0, 683851
BytebuddyAgent [candidate] (682.719 ms) : 0, 682719
GlobalTracer [baseline] (311.955 ms) : 0, 311955
GlobalTracer [candidate] (311.994 ms) : 0, 311994
AppSec [baseline] (54.106 ms) : 0, 54106
AppSec [candidate] (54.533 ms) : 0, 54533
Remote Config [baseline] (669.74 µs) : 0, 670
Remote Config [candidate] (681.024 µs) : 0, 681
Telemetry [baseline] (7.736 ms) : 0, 7736
Telemetry [candidate] (7.74 ms) : 0, 7740
section appsec
BytebuddyAgent [baseline] (701.85 ms) : 0, 701850
BytebuddyAgent [candidate] (704.435 ms) : 0, 704435
GlobalTracer [baseline] (309.616 ms) : 0, 309616
GlobalTracer [candidate] (309.146 ms) : 0, 309146
AppSec [baseline] (162.773 ms) : 0, 162773
AppSec [candidate] (164.128 ms) : 0, 164128
IAST [baseline] (19.547 ms) : 0, 19547
IAST [candidate] (20.696 ms) : 0, 20696
Remote Config [baseline] (641.446 µs) : 0, 641
Remote Config [candidate] (640.893 µs) : 0, 641
Telemetry [baseline] (9.612 ms) : 0, 9612
Telemetry [candidate] (7.889 ms) : 0, 7889
section iast
BytebuddyAgent [baseline] (799.582 ms) : 0, 799582
BytebuddyAgent [candidate] (800.324 ms) : 0, 800324
GlobalTracer [baseline] (300.697 ms) : 0, 300697
GlobalTracer [candidate] (300.832 ms) : 0, 300832
AppSec [baseline] (56.011 ms) : 0, 56011
AppSec [candidate] (53.854 ms) : 0, 53854
IAST [baseline] (22.944 ms) : 0, 22944
IAST [candidate] (24.455 ms) : 0, 24455
Remote Config [baseline] (612.512 µs) : 0, 613
Remote Config [candidate] (602.524 µs) : 0, 603
Telemetry [baseline] (7.054 ms) : 0, 7054
Telemetry [candidate] (7.136 ms) : 0, 7136
section profiling
BytebuddyAgent [baseline] (677.425 ms) : 0, 677425
BytebuddyAgent [candidate] (681.85 ms) : 0, 681850
GlobalTracer [baseline] (394.529 ms) : 0, 394529
GlobalTracer [candidate] (397.373 ms) : 0, 397373
AppSec [baseline] (54.764 ms) : 0, 54764
AppSec [candidate] (55.056 ms) : 0, 55056
Remote Config [baseline] (654.686 µs) : 0, 655
Remote Config [candidate] (660.072 µs) : 0, 660
Telemetry [baseline] (7.472 ms) : 0, 7472
Telemetry [candidate] (7.505 ms) : 0, 7505
ProfilingAgent [baseline] (97.355 ms) : 0, 97355
ProfilingAgent [candidate] (97.885 ms) : 0, 97885
Profiling [baseline] (97.379 ms) : 0, 97379
Profiling [candidate] (97.909 ms) : 0, 97909
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~c9bb1bacc4, baseline=1.41.0-SNAPSHOT~0a80d676b0

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1084594
Total [baseline] (8.596 s) : 0, 8595555
Agent [candidate] (1.078 s) : 0, 1077784
Total [candidate] (8.648 s) : 0, 8648140
section iast
Agent [baseline] (1.209 s) : 0, 1208777
Total [baseline] (9.153 s) : 0, 9153167
Agent [candidate] (1.197 s) : 0, 1196537
Total [candidate] (9.071 s) : 0, 9070642
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.198 s) : 0, 1198079
Total [baseline] (9.1 s) : 0, 9099959
Agent [candidate] (1.199 s) : 0, 1199457
Total [candidate] (9.09 s) : 0, 9089830
section iast_TELEMETRY_OFF
Agent [baseline] (1.197 s) : 0, 1197074
Total [baseline] (9.096 s) : 0, 9096304
Agent [candidate] (1.211 s) : 0, 1210751
Total [candidate] (9.112 s) : 0, 9112380
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.085 s -
Agent iast 1.209 s 124.183 ms (11.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.198 s 113.485 ms (10.5%)
Agent iast_TELEMETRY_OFF 1.197 s 112.48 ms (10.4%)
Total tracing 8.596 s -
Total iast 9.153 s 557.612 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.1 s 504.405 ms (5.9%)
Total iast_TELEMETRY_OFF 9.096 s 500.749 ms (5.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent iast 1.197 s 118.754 ms (11.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.199 s 121.673 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.211 s 132.967 ms (12.3%)
Total tracing 8.648 s -
Total iast 9.071 s 422.502 ms (4.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.09 s 441.69 ms (5.1%)
Total iast_TELEMETRY_OFF 9.112 s 464.241 ms (5.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~c9bb1bacc4, baseline=1.41.0-SNAPSHOT~0a80d676b0

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (694.317 ms) : 0, 694317
BytebuddyAgent [candidate] (687.909 ms) : 0, 687909
GlobalTracer [baseline] (313.502 ms) : 0, 313502
GlobalTracer [candidate] (313.251 ms) : 0, 313251
AppSec [baseline] (54.455 ms) : 0, 54455
AppSec [candidate] (54.342 ms) : 0, 54342
Remote Config [baseline] (664.629 µs) : 0, 665
Remote Config [candidate] (667.197 µs) : 0, 667
Telemetry [baseline] (7.681 ms) : 0, 7681
Telemetry [candidate] (7.773 ms) : 0, 7773
section iast
BytebuddyAgent [baseline] (805.365 ms) : 0, 805365
BytebuddyAgent [candidate] (797.315 ms) : 0, 797315
GlobalTracer [baseline] (302.709 ms) : 0, 302709
GlobalTracer [candidate] (300.104 ms) : 0, 300104
AppSec [baseline] (53.85 ms) : 0, 53850
AppSec [candidate] (52.498 ms) : 0, 52498
IAST [baseline] (25.309 ms) : 0, 25309
IAST [candidate] (25.269 ms) : 0, 25269
Remote Config [baseline] (607.298 µs) : 0, 607
Remote Config [candidate] (596.387 µs) : 0, 596
Telemetry [baseline] (7.02 ms) : 0, 7020
Telemetry [candidate] (6.976 ms) : 0, 6976
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (797.704 ms) : 0, 797704
BytebuddyAgent [candidate] (798.201 ms) : 0, 798201
GlobalTracer [baseline] (300.152 ms) : 0, 300152
GlobalTracer [candidate] (300.372 ms) : 0, 300372
AppSec [baseline] (55.022 ms) : 0, 55022
AppSec [candidate] (53.059 ms) : 0, 53059
IAST [baseline] (23.665 ms) : 0, 23665
IAST [candidate] (26.326 ms) : 0, 26326
Remote Config [baseline] (605.704 µs) : 0, 606
Remote Config [candidate] (607.877 µs) : 0, 608
Telemetry [baseline] (7.074 ms) : 0, 7074
Telemetry [candidate] (7.047 ms) : 0, 7047
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (796.708 ms) : 0, 796708
BytebuddyAgent [candidate] (806.457 ms) : 0, 806457
GlobalTracer [baseline] (300.185 ms) : 0, 300185
GlobalTracer [candidate] (303.664 ms) : 0, 303664
AppSec [baseline] (53.683 ms) : 0, 53683
AppSec [candidate] (57.375 ms) : 0, 57375
IAST [baseline] (25.096 ms) : 0, 25096
IAST [candidate] (21.633 ms) : 0, 21633
Remote Config [baseline] (605.122 µs) : 0, 605
Remote Config [candidate] (633.227 µs) : 0, 633
Telemetry [baseline] (6.909 ms) : 0, 6909
Telemetry [candidate] (6.973 ms) : 0, 6973
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-02T08:21:22 2024-10-02T08:28:13
git_branch master malvarez/waf-do-not-publish-dup-user-ids
git_commit_date 1727856557 1727856647
git_commit_sha 0a80d67 c9bb1ba
release_version 1.41.0-SNAPSHOT~0a80d676b0 1.41.0-SNAPSHOT~c9bb1bacc4
start_time 2024-10-02T08:21:09 2024-10-02T08:28:00
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727858039 1727858039
ci_job_id 658129708 658129708
ci_pipeline_id 45580378 45580378
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~c9bb1bacc4, baseline=1.41.0-SNAPSHOT~0a80d676b0
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.349 ms) : 1328, 1369
.   : milestone, 1349,
appsec (1.717 ms) : 1693, 1741
.   : milestone, 1717,
appsec_no_iast (1.716 ms) : 1691, 1741
.   : milestone, 1716,
iast (1.462 ms) : 1440, 1484
.   : milestone, 1462,
profiling (1.526 ms) : 1500, 1551
.   : milestone, 1526,
tracing (1.453 ms) : 1429, 1478
.   : milestone, 1453,
section candidate
no_agent (1.334 ms) : 1314, 1354
.   : milestone, 1334,
appsec (1.726 ms) : 1704, 1748
.   : milestone, 1726,
appsec_no_iast (1.69 ms) : 1665, 1715
.   : milestone, 1690,
iast (1.486 ms) : 1463, 1508
.   : milestone, 1486,
profiling (1.478 ms) : 1454, 1503
.   : milestone, 1478,
tracing (1.456 ms) : 1431, 1480
.   : milestone, 1456,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.349 ms [1.328 ms, 1.369 ms] -
appsec 1.717 ms [1.693 ms, 1.741 ms] 368.456 µs (27.3%)
appsec_no_iast 1.716 ms [1.691 ms, 1.741 ms] 367.173 µs (27.2%)
iast 1.462 ms [1.44 ms, 1.484 ms] 113.364 µs (8.4%)
profiling 1.526 ms [1.5 ms, 1.551 ms] 177.286 µs (13.1%)
tracing 1.453 ms [1.429 ms, 1.478 ms] 104.77 µs (7.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.334 ms [1.314 ms, 1.354 ms] -
appsec 1.726 ms [1.704 ms, 1.748 ms] 392.106 µs (29.4%)
appsec_no_iast 1.69 ms [1.665 ms, 1.715 ms] 355.871 µs (26.7%)
iast 1.486 ms [1.463 ms, 1.508 ms] 151.619 µs (11.4%)
profiling 1.478 ms [1.454 ms, 1.503 ms] 144.251 µs (10.8%)
tracing 1.456 ms [1.431 ms, 1.48 ms] 121.611 µs (9.1%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~c9bb1bacc4, baseline=1.41.0-SNAPSHOT~0a80d676b0
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.254 µs) : 355, 394
.   : milestone, 374,
iast (490.042 µs) : 469, 511
.   : milestone, 490,
iast_FULL (549.469 µs) : 528, 571
.   : milestone, 549,
iast_GLOBAL (503.94 µs) : 483, 525
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (482.383 µs) : 461, 504
.   : milestone, 482,
iast_INACTIVE (443.302 µs) : 423, 464
.   : milestone, 443,
iast_TELEMETRY_OFF (470.971 µs) : 450, 492
.   : milestone, 471,
tracing (446.797 µs) : 426, 468
.   : milestone, 447,
section candidate
no_agent (374.205 µs) : 353, 396
.   : milestone, 374,
iast (489.871 µs) : 468, 512
.   : milestone, 490,
iast_FULL (555.19 µs) : 534, 577
.   : milestone, 555,
iast_GLOBAL (508.151 µs) : 487, 529
.   : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (480.833 µs) : 460, 502
.   : milestone, 481,
iast_INACTIVE (442.14 µs) : 421, 463
.   : milestone, 442,
iast_TELEMETRY_OFF (477.787 µs) : 456, 500
.   : milestone, 478,
tracing (440.628 µs) : 420, 461
.   : milestone, 441,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.254 µs [354.81 µs, 393.698 µs] -
iast 490.042 µs [468.814 µs, 511.269 µs] 115.788 µs (30.9%)
iast_FULL 549.469 µs [528.369 µs, 570.57 µs] 175.216 µs (46.8%)
iast_GLOBAL 503.94 µs [482.749 µs, 525.131 µs] 129.686 µs (34.7%)
iast_HARDCODED_SECRET_DISABLED 482.383 µs [460.945 µs, 503.82 µs] 108.129 µs (28.9%)
iast_INACTIVE 443.302 µs [422.755 µs, 463.848 µs] 69.048 µs (18.4%)
iast_TELEMETRY_OFF 470.971 µs [450.253 µs, 491.69 µs] 96.718 µs (25.8%)
tracing 446.797 µs [426.029 µs, 467.564 µs] 72.543 µs (19.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.205 µs [352.703 µs, 395.708 µs] -
iast 489.871 µs [468.0 µs, 511.742 µs] 115.665 µs (30.9%)
iast_FULL 555.19 µs [533.851 µs, 576.529 µs] 180.984 µs (48.4%)
iast_GLOBAL 508.151 µs [487.081 µs, 529.221 µs] 133.945 µs (35.8%)
iast_HARDCODED_SECRET_DISABLED 480.833 µs [460.031 µs, 501.635 µs] 106.628 µs (28.5%)
iast_INACTIVE 442.14 µs [421.082 µs, 463.197 µs] 67.934 µs (18.2%)
iast_TELEMETRY_OFF 477.787 µs [455.828 µs, 499.745 µs] 103.581 µs (27.7%)
tracing 440.628 µs [420.31 µs, 460.945 µs] 66.422 µs (17.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/waf-do-not-publish-dup-user-ids
git_commit_date 1727856557 1727856647
git_commit_sha 0a80d67 c9bb1ba
release_version 1.41.0-SNAPSHOT~0a80d676b0 1.41.0-SNAPSHOT~c9bb1bacc4
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1727858666 1727858666
ci_job_id 658129709 658129709
ci_pipeline_id 45580378 45580378
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~c9bb1bacc4, baseline=1.41.0-SNAPSHOT~0a80d676b0
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.459 ms) : 1448, 1471
.   : milestone, 1459,
appsec (2.297 ms) : 2257, 2337
.   : milestone, 2297,
iast (2.072 ms) : 2021, 2124
.   : milestone, 2072,
iast_GLOBAL (2.11 ms) : 2058, 2161
.   : milestone, 2110,
profiling (1.939 ms) : 1898, 1980
.   : milestone, 1939,
tracing (1.906 ms) : 1867, 1945
.   : milestone, 1906,
section candidate
no_agent (1.462 ms) : 1451, 1474
.   : milestone, 1462,
appsec (2.313 ms) : 2273, 2353
.   : milestone, 2313,
iast (2.064 ms) : 2012, 2115
.   : milestone, 2064,
iast_GLOBAL (2.098 ms) : 2046, 2149
.   : milestone, 2098,
profiling (1.922 ms) : 1881, 1962
.   : milestone, 1922,
tracing (1.906 ms) : 1866, 1945
.   : milestone, 1906,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.448 ms, 1.471 ms] -
appsec 2.297 ms [2.257 ms, 2.337 ms] 837.491 µs (57.4%)
iast 2.072 ms [2.021 ms, 2.124 ms] 612.643 µs (42.0%)
iast_GLOBAL 2.11 ms [2.058 ms, 2.161 ms] 650.475 µs (44.6%)
profiling 1.939 ms [1.898 ms, 1.98 ms] 479.524 µs (32.9%)
tracing 1.906 ms [1.867 ms, 1.945 ms] 446.572 µs (30.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.451 ms, 1.474 ms] -
appsec 2.313 ms [2.273 ms, 2.353 ms] 850.84 µs (58.2%)
iast 2.064 ms [2.012 ms, 2.115 ms] 601.446 µs (41.1%)
iast_GLOBAL 2.098 ms [2.046 ms, 2.149 ms] 635.306 µs (43.4%)
profiling 1.922 ms [1.881 ms, 1.962 ms] 459.362 µs (31.4%)
tracing 1.906 ms [1.866 ms, 1.945 ms] 443.479 µs (30.3%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~c9bb1bacc4, baseline=1.41.0-SNAPSHOT~0a80d676b0
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.598 s) : 15598000, 15598000
.   : milestone, 15598000,
appsec (15.115 s) : 15115000, 15115000
.   : milestone, 15115000,
iast (18.87 s) : 18870000, 18870000
.   : milestone, 18870000,
iast_GLOBAL (17.622 s) : 17622000, 17622000
.   : milestone, 17622000,
profiling (15.242 s) : 15242000, 15242000
.   : milestone, 15242000,
tracing (15.13 s) : 15130000, 15130000
.   : milestone, 15130000,
section candidate
no_agent (15.064 s) : 15064000, 15064000
.   : milestone, 15064000,
appsec (15.17 s) : 15170000, 15170000
.   : milestone, 15170000,
iast (18.772 s) : 18772000, 18772000
.   : milestone, 18772000,
iast_GLOBAL (17.96 s) : 17960000, 17960000
.   : milestone, 17960000,
profiling (15.287 s) : 15287000, 15287000
.   : milestone, 15287000,
tracing (15.347 s) : 15347000, 15347000
.   : milestone, 15347000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.598 s [15.598 s, 15.598 s] -
appsec 15.115 s [15.115 s, 15.115 s] -483.0 ms (-3.1%)
iast 18.87 s [18.87 s, 18.87 s] 3.272 s (21.0%)
iast_GLOBAL 17.622 s [17.622 s, 17.622 s] 2.024 s (13.0%)
profiling 15.242 s [15.242 s, 15.242 s] -356.0 ms (-2.3%)
tracing 15.13 s [15.13 s, 15.13 s] -468.0 ms (-3.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.064 s [15.064 s, 15.064 s] -
appsec 15.17 s [15.17 s, 15.17 s] 106.0 ms (0.7%)
iast 18.772 s [18.772 s, 18.772 s] 3.708 s (24.6%)
iast_GLOBAL 17.96 s [17.96 s, 17.96 s] 2.896 s (19.2%)
profiling 15.287 s [15.287 s, 15.287 s] 223.0 ms (1.5%)
tracing 15.347 s [15.347 s, 15.347 s] 283.0 ms (1.9%)

Base automatically changed from malvarez/waf-noise-with-usr-id to master October 2, 2024 08:09
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/waf-do-not-publish-dup-user-ids branch from 42af107 to c9bb1ba Compare October 2, 2024 08:11
@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit 4eeed47 into master Oct 2, 2024
103 checks passed
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/waf-do-not-publish-dup-user-ids branch October 2, 2024 10:04
@github-actions github-actions bot added this to the 1.41.0 milestone Oct 2, 2024
@manuel-alvarez-alvarez manuel-alvarez-alvarez mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariovido Mariovido Mariovido approved these changes

@jandro996 jandro996 jandro996 approved these changes

@ValentinZakharov ValentinZakharov ValentinZakharov approved these changes

@smola smola smola approved these changes

Assignees
No one assigned
Labels
comp: asm waf Application Security Management (WAF) tag: performance Performance related changes
Projects
None yet
Milestone
1.41.0
Development

Successfully merging this pull request may close these issues.
5 participants
@manuel-alvarez-alvarez @smola @ValentinZakharov @jandro996 @Mariovido