-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🍒 7697] Fix crashtracking log parser #7703
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Summary uses time format with space padding for days of the month while our parser uses zero padded number. Change the DateTimeFormatter pattern and add a test to cover this case. 2. Summary time can be based of offset and time zone name. Add two parsers to support both formats.
PerfectSlayer
changed the title
[🍒 7562] Fix crashtracking log parser
[🍒 7697] Fix crashtracking log parser
Oct 2, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~2cc5379e34, baseline=1.41.0-SNAPSHOT~069b6771c0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1071447
Total [baseline] (8.561 s) : 0, 8560534
Agent [candidate] (1.074 s) : 0, 1074400
Total [candidate] (8.613 s) : 0, 8613155
section iast
Agent [baseline] (1.201 s) : 0, 1201142
Total [baseline] (9.109 s) : 0, 9109342
Agent [candidate] (1.194 s) : 0, 1193940
Total [candidate] (9.088 s) : 0, 9088444
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.193 s) : 0, 1193094
Total [baseline] (9.137 s) : 0, 9136649
Agent [candidate] (1.196 s) : 0, 1195529
Total [candidate] (9.082 s) : 0, 9081940
section iast_TELEMETRY_OFF
Agent [baseline] (1.199 s) : 0, 1198802
Total [baseline] (9.096 s) : 0, 9096288
Agent [candidate] (1.19 s) : 0, 1189996
Total [candidate] (9.065 s) : 0, 9064578
gantt
title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~2cc5379e34, baseline=1.41.0-SNAPSHOT~069b6771c0
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.185 ms) : 0, 684185
BytebuddyAgent [candidate] (685.72 ms) : 0, 685720
GlobalTracer [baseline] (311.458 ms) : 0, 311458
GlobalTracer [candidate] (312.395 ms) : 0, 312395
AppSec [baseline] (53.72 ms) : 0, 53720
AppSec [candidate] (54.111 ms) : 0, 54111
Remote Config [baseline] (667.781 µs) : 0, 668
Remote Config [candidate] (666.855 µs) : 0, 667
Telemetry [baseline] (7.718 ms) : 0, 7718
Telemetry [candidate] (7.732 ms) : 0, 7732
section iast
BytebuddyAgent [baseline] (800.043 ms) : 0, 800043
BytebuddyAgent [candidate] (794.933 ms) : 0, 794933
GlobalTracer [baseline] (301.545 ms) : 0, 301545
GlobalTracer [candidate] (299.8 ms) : 0, 299800
AppSec [baseline] (53.949 ms) : 0, 53949
AppSec [candidate] (53.558 ms) : 0, 53558
IAST [baseline] (24.195 ms) : 0, 24195
IAST [candidate] (24.295 ms) : 0, 24295
Remote Config [baseline] (621.019 µs) : 0, 621
Remote Config [candidate] (604.719 µs) : 0, 605
Telemetry [baseline] (7.053 ms) : 0, 7053
Telemetry [candidate] (7.013 ms) : 0, 7013
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (794.43 ms) : 0, 794430
BytebuddyAgent [candidate] (795.38 ms) : 0, 795380
GlobalTracer [baseline] (299.713 ms) : 0, 299713
GlobalTracer [candidate] (300.218 ms) : 0, 300218
AppSec [baseline] (53.395 ms) : 0, 53395
AppSec [candidate] (52.454 ms) : 0, 52454
IAST [baseline] (24.187 ms) : 0, 24187
IAST [candidate] (26.098 ms) : 0, 26098
Remote Config [baseline] (620.161 µs) : 0, 620
Remote Config [candidate] (608.652 µs) : 0, 609
Telemetry [baseline] (7.033 ms) : 0, 7033
Telemetry [candidate] (7.049 ms) : 0, 7049
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (796.776 ms) : 0, 796776
BytebuddyAgent [candidate] (790.55 ms) : 0, 790550
GlobalTracer [baseline] (301.918 ms) : 0, 301918
GlobalTracer [candidate] (300.134 ms) : 0, 300134
AppSec [baseline] (55.218 ms) : 0, 55218
AppSec [candidate] (53.279 ms) : 0, 53279
IAST [baseline] (23.536 ms) : 0, 23536
IAST [candidate] (24.829 ms) : 0, 24829
Remote Config [baseline] (616.563 µs) : 0, 617
Remote Config [candidate] (604.382 µs) : 0, 604
Telemetry [baseline] (6.952 ms) : 0, 6952
Telemetry [candidate] (6.864 ms) : 0, 6864
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~2cc5379e34, baseline=1.41.0-SNAPSHOT~069b6771c0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1075080
Total [baseline] (10.449 s) : 0, 10448848
Agent [candidate] (1.067 s) : 0, 1067362
Total [candidate] (10.369 s) : 0, 10369139
section appsec
Agent [baseline] (1.205 s) : 0, 1205174
Total [baseline] (10.592 s) : 0, 10592362
Agent [candidate] (1.205 s) : 0, 1204745
Total [candidate] (10.631 s) : 0, 10630696
section iast
Agent [baseline] (1.196 s) : 0, 1196014
Total [baseline] (10.843 s) : 0, 10843241
Agent [candidate] (1.198 s) : 0, 1198048
Total [candidate] (10.872 s) : 0, 10871863
section profiling
Agent [baseline] (1.273 s) : 0, 1272958
Total [baseline] (10.696 s) : 0, 10695622
Agent [candidate] (1.268 s) : 0, 1268466
Total [candidate] (10.587 s) : 0, 10586934
gantt
title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~2cc5379e34, baseline=1.41.0-SNAPSHOT~069b6771c0
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.102 ms) : 0, 686102
BytebuddyAgent [candidate] (681.191 ms) : 0, 681191
GlobalTracer [baseline] (312.746 ms) : 0, 312746
GlobalTracer [candidate] (310.62 ms) : 0, 310620
AppSec [baseline] (54.113 ms) : 0, 54113
AppSec [candidate] (53.64 ms) : 0, 53640
Remote Config [baseline] (669.094 µs) : 0, 669
Remote Config [candidate] (667.259 µs) : 0, 667
Telemetry [baseline] (7.702 ms) : 0, 7702
Telemetry [candidate] (7.58 ms) : 0, 7580
section appsec
BytebuddyAgent [baseline] (700.727 ms) : 0, 700727
BytebuddyAgent [candidate] (700.638 ms) : 0, 700638
GlobalTracer [baseline] (308.635 ms) : 0, 308635
GlobalTracer [candidate] (308.447 ms) : 0, 308447
AppSec [baseline] (162.853 ms) : 0, 162853
AppSec [candidate] (163.054 ms) : 0, 163054
Remote Config [baseline] (632.941 µs) : 0, 633
Remote Config [candidate] (636.473 µs) : 0, 636
Telemetry [baseline] (7.453 ms) : 0, 7453
Telemetry [candidate] (7.853 ms) : 0, 7853
IAST [baseline] (22.364 ms) : 0, 22364
IAST [candidate] (20.774 ms) : 0, 20774
section iast
BytebuddyAgent [baseline] (795.998 ms) : 0, 795998
BytebuddyAgent [candidate] (797.226 ms) : 0, 797226
GlobalTracer [baseline] (300.294 ms) : 0, 300294
GlobalTracer [candidate] (301.193 ms) : 0, 301193
AppSec [baseline] (54.833 ms) : 0, 54833
AppSec [candidate] (55.519 ms) : 0, 55519
Remote Config [baseline] (629.248 µs) : 0, 629
Remote Config [candidate] (620.28 µs) : 0, 620
Telemetry [baseline] (7.044 ms) : 0, 7044
Telemetry [candidate] (7.008 ms) : 0, 7008
IAST [baseline] (23.556 ms) : 0, 23556
IAST [candidate] (22.777 ms) : 0, 22777
section profiling
ProfilingAgent [baseline] (97.086 ms) : 0, 97086
ProfilingAgent [candidate] (96.877 ms) : 0, 96877
BytebuddyAgent [baseline] (678.965 ms) : 0, 678965
BytebuddyAgent [candidate] (675.649 ms) : 0, 675649
GlobalTracer [baseline] (395.34 ms) : 0, 395340
GlobalTracer [candidate] (394.417 ms) : 0, 394417
AppSec [baseline] (54.617 ms) : 0, 54617
AppSec [candidate] (54.736 ms) : 0, 54736
Remote Config [baseline] (654.214 µs) : 0, 654
Remote Config [candidate] (652.128 µs) : 0, 652
Telemetry [baseline] (7.457 ms) : 0, 7457
Telemetry [candidate] (7.44 ms) : 0, 7440
Profiling [baseline] (97.109 ms) : 0, 97109
Profiling [candidate] (96.9 ms) : 0, 96900
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~2cc5379e34, baseline=1.41.0-SNAPSHOT~069b6771c0
dateFormat X
axisFormat %s
section baseline
no_agent (372.457 µs) : 353, 392
. : milestone, 372,
iast (484.466 µs) : 463, 506
. : milestone, 484,
iast_FULL (549.772 µs) : 529, 571
. : milestone, 550,
iast_GLOBAL (501.884 µs) : 481, 523
. : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (478.89 µs) : 458, 500
. : milestone, 479,
iast_INACTIVE (440.025 µs) : 420, 460
. : milestone, 440,
iast_TELEMETRY_OFF (471.291 µs) : 450, 493
. : milestone, 471,
tracing (435.762 µs) : 415, 457
. : milestone, 436,
section candidate
no_agent (373.956 µs) : 354, 394
. : milestone, 374,
iast (479.441 µs) : 458, 501
. : milestone, 479,
iast_FULL (548.896 µs) : 528, 570
. : milestone, 549,
iast_GLOBAL (497.097 µs) : 476, 518
. : milestone, 497,
iast_HARDCODED_SECRET_DISABLED (479.169 µs) : 458, 500
. : milestone, 479,
iast_INACTIVE (442.337 µs) : 421, 464
. : milestone, 442,
iast_TELEMETRY_OFF (465.206 µs) : 444, 486
. : milestone, 465,
tracing (443.998 µs) : 423, 465
. : milestone, 444,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~2cc5379e34, baseline=1.41.0-SNAPSHOT~069b6771c0
dateFormat X
axisFormat %s
section baseline
no_agent (1.328 ms) : 1308, 1348
. : milestone, 1328,
appsec (1.701 ms) : 1677, 1725
. : milestone, 1701,
appsec_no_iast (1.709 ms) : 1685, 1732
. : milestone, 1709,
iast (1.465 ms) : 1443, 1488
. : milestone, 1465,
profiling (1.476 ms) : 1453, 1500
. : milestone, 1476,
tracing (1.469 ms) : 1445, 1493
. : milestone, 1469,
section candidate
no_agent (1.331 ms) : 1312, 1350
. : milestone, 1331,
appsec (1.734 ms) : 1709, 1759
. : milestone, 1734,
appsec_no_iast (1.704 ms) : 1680, 1727
. : milestone, 1704,
iast (1.471 ms) : 1449, 1494
. : milestone, 1471,
profiling (1.489 ms) : 1463, 1514
. : milestone, 1489,
tracing (1.456 ms) : 1431, 1480
. : milestone, 1456,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~2cc5379e34, baseline=1.41.0-SNAPSHOT~069b6771c0
dateFormat X
axisFormat %s
section baseline
no_agent (15.237 s) : 15237000, 15237000
. : milestone, 15237000,
appsec (15.286 s) : 15286000, 15286000
. : milestone, 15286000,
iast (19.006 s) : 19006000, 19006000
. : milestone, 19006000,
iast_GLOBAL (17.884 s) : 17884000, 17884000
. : milestone, 17884000,
profiling (15.617 s) : 15617000, 15617000
. : milestone, 15617000,
tracing (15.452 s) : 15452000, 15452000
. : milestone, 15452000,
section candidate
no_agent (15.024 s) : 15024000, 15024000
. : milestone, 15024000,
appsec (15.252 s) : 15252000, 15252000
. : milestone, 15252000,
iast (18.67 s) : 18670000, 18670000
. : milestone, 18670000,
iast_GLOBAL (17.869 s) : 17869000, 17869000
. : milestone, 17869000,
profiling (15.278 s) : 15278000, 15278000
. : milestone, 15278000,
tracing (15.515 s) : 15515000, 15515000
. : milestone, 15515000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~2cc5379e34, baseline=1.41.0-SNAPSHOT~069b6771c0
dateFormat X
axisFormat %s
section baseline
no_agent (1.467 ms) : 1455, 1478
. : milestone, 1467,
appsec (2.31 ms) : 2269, 2351
. : milestone, 2310,
iast (2.064 ms) : 2013, 2116
. : milestone, 2064,
iast_GLOBAL (2.109 ms) : 2057, 2161
. : milestone, 2109,
profiling (1.928 ms) : 1887, 1969
. : milestone, 1928,
tracing (1.906 ms) : 1868, 1945
. : milestone, 1906,
section candidate
no_agent (1.459 ms) : 1448, 1470
. : milestone, 1459,
appsec (2.306 ms) : 2266, 2347
. : milestone, 2306,
iast (2.054 ms) : 2003, 2105
. : milestone, 2054,
iast_GLOBAL (2.087 ms) : 2036, 2137
. : milestone, 2087,
profiling (1.935 ms) : 1893, 1977
. : milestone, 1935,
tracing (1.897 ms) : 1859, 1936
. : milestone, 1897,
|
manuel-alvarez-alvarez
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #7697 to release/v1.40.x