Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crashtracking log parser #7697

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Fix crashtracking log parser #7697

merged 1 commit into from
Oct 2, 2024

Conversation

PerfectSlayer
Copy link
Contributor

@PerfectSlayer PerfectSlayer commented Oct 1, 2024 •
edited
Loading

What Does This Do

This PR fixes the date time parser from the crashtracking log parser to support:

  • Single digit day of month
  • Both offset and timezone date times

It also adds some unit tests that cover this change to quickly test for new values.

Motivation

The Summary section uses time format with space padding for days of the month while our parser uses zero padded number (dd, reference).

The Summary section time can also be offset based (Z, +08, +08:00) or time zone based (CEST, UTC, GMT).

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@PerfectSlayer PerfectSlayer requested a review from a team as a code owner October 1, 2024 11:52
@pr-commenter
Copy link

pr-commenter bot commented Oct 1, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/crashtracking
git_commit_date 1727781530 1727790769
git_commit_sha 794ff14 b1fd9f6
release_version 1.41.0-SNAPSHOT~794ff14344 1.41.0-SNAPSHOT~b1fd9f6ece
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727793481 1727793481
ci_job_id 657119740 657119740
ci_pipeline_id 45515924 45515924
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~b1fd9f6ece, baseline=1.41.0-SNAPSHOT~794ff14344

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1071446
Total [baseline] (8.577 s) : 0, 8576677
Agent [candidate] (1.077 s) : 0, 1076687
Total [candidate] (8.56 s) : 0, 8559852
section iast
Agent [baseline] (1.203 s) : 0, 1202956
Total [baseline] (9.098 s) : 0, 9098206
Agent [candidate] (1.194 s) : 0, 1194177
Total [candidate] (9.09 s) : 0, 9089602
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.196 s) : 0, 1195577
Total [baseline] (9.1 s) : 0, 9100190
Agent [candidate] (1.205 s) : 0, 1204594
Total [candidate] (9.1 s) : 0, 9100408
section iast_TELEMETRY_OFF
Agent [baseline] (1.193 s) : 0, 1192630
Total [baseline] (9.077 s) : 0, 9077191
Agent [candidate] (1.193 s) : 0, 1192535
Total [candidate] (9.131 s) : 0, 9131229
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.071 s -
Agent iast 1.203 s 131.51 ms (12.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.196 s 124.131 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.193 s 121.184 ms (11.3%)
Total tracing 8.577 s -
Total iast 9.098 s 521.529 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.1 s 523.513 ms (6.1%)
Total iast_TELEMETRY_OFF 9.077 s 500.513 ms (5.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.077 s -
Agent iast 1.194 s 117.49 ms (10.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.205 s 127.907 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.193 s 115.847 ms (10.8%)
Total tracing 8.56 s -
Total iast 9.09 s 529.75 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.1 s 540.555 ms (6.3%)
Total iast_TELEMETRY_OFF 9.131 s 571.377 ms (6.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~b1fd9f6ece, baseline=1.41.0-SNAPSHOT~794ff14344

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.894 ms) : 0, 683894
BytebuddyAgent [candidate] (687.104 ms) : 0, 687104
GlobalTracer [baseline] (311.878 ms) : 0, 311878
GlobalTracer [candidate] (313.057 ms) : 0, 313057
AppSec [baseline] (53.649 ms) : 0, 53649
AppSec [candidate] (54.316 ms) : 0, 54316
Remote Config [baseline] (659.841 µs) : 0, 660
Remote Config [candidate] (663.591 µs) : 0, 664
Telemetry [baseline] (7.637 ms) : 0, 7637
Telemetry [candidate] (7.713 ms) : 0, 7713
section iast
BytebuddyAgent [baseline] (801.49 ms) : 0, 801490
BytebuddyAgent [candidate] (795.108 ms) : 0, 795108
GlobalTracer [baseline] (301.793 ms) : 0, 301793
GlobalTracer [candidate] (300.282 ms) : 0, 300282
AppSec [baseline] (55.178 ms) : 0, 55178
AppSec [candidate] (56.349 ms) : 0, 56349
IAST [baseline] (22.917 ms) : 0, 22917
IAST [candidate] (20.988 ms) : 0, 20988
Remote Config [baseline] (620.744 µs) : 0, 621
Remote Config [candidate] (627.626 µs) : 0, 628
Telemetry [baseline] (7.121 ms) : 0, 7121
Telemetry [candidate] (7.072 ms) : 0, 7072
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (795.748 ms) : 0, 795748
BytebuddyAgent [candidate] (802.021 ms) : 0, 802021
GlobalTracer [baseline] (299.86 ms) : 0, 299860
GlobalTracer [candidate] (302.874 ms) : 0, 302874
AppSec [baseline] (52.519 ms) : 0, 52519
AppSec [candidate] (55.571 ms) : 0, 55571
IAST [baseline] (25.939 ms) : 0, 25939
IAST [candidate] (22.578 ms) : 0, 22578
Remote Config [baseline] (627.989 µs) : 0, 628
Remote Config [candidate] (612.308 µs) : 0, 612
Telemetry [baseline] (7.095 ms) : 0, 7095
Telemetry [candidate] (7.066 ms) : 0, 7066
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (792.869 ms) : 0, 792869
BytebuddyAgent [candidate] (792.288 ms) : 0, 792288
GlobalTracer [baseline] (300.359 ms) : 0, 300359
GlobalTracer [candidate] (300.652 ms) : 0, 300652
AppSec [baseline] (54.985 ms) : 0, 54985
AppSec [candidate] (56.327 ms) : 0, 56327
IAST [baseline] (23.192 ms) : 0, 23192
IAST [candidate] (21.87 ms) : 0, 21870
Remote Config [baseline] (606.666 µs) : 0, 607
Remote Config [candidate] (619.816 µs) : 0, 620
Telemetry [baseline] (6.884 ms) : 0, 6884
Telemetry [candidate] (6.983 ms) : 0, 6983
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~b1fd9f6ece, baseline=1.41.0-SNAPSHOT~794ff14344

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1078032
Total [baseline] (10.462 s) : 0, 10462088
Agent [candidate] (1.071 s) : 0, 1070943
Total [candidate] (10.424 s) : 0, 10423705
section appsec
Agent [baseline] (1.204 s) : 0, 1203902
Total [baseline] (10.594 s) : 0, 10594262
Agent [candidate] (1.204 s) : 0, 1203794
Total [candidate] (10.623 s) : 0, 10622604
section iast
Agent [baseline] (1.196 s) : 0, 1196487
Total [baseline] (10.816 s) : 0, 10816139
Agent [candidate] (1.206 s) : 0, 1205978
Total [candidate] (10.933 s) : 0, 10932824
section profiling
Agent [baseline] (1.266 s) : 0, 1266009
Total [baseline] (10.664 s) : 0, 10663831
Agent [candidate] (1.267 s) : 0, 1267485
Total [candidate] (10.604 s) : 0, 10604402
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent appsec 1.204 s 125.87 ms (11.7%)
Agent iast 1.196 s 118.455 ms (11.0%)
Agent profiling 1.266 s 187.978 ms (17.4%)
Total tracing 10.462 s -
Total appsec 10.594 s 132.174 ms (1.3%)
Total iast 10.816 s 354.051 ms (3.4%)
Total profiling 10.664 s 201.743 ms (1.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.071 s -
Agent appsec 1.204 s 132.851 ms (12.4%)
Agent iast 1.206 s 135.035 ms (12.6%)
Agent profiling 1.267 s 196.542 ms (18.4%)
Total tracing 10.424 s -
Total appsec 10.623 s 198.899 ms (1.9%)
Total iast 10.933 s 509.119 ms (4.9%)
Total profiling 10.604 s 180.697 ms (1.7%) 
gantt
    title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~b1fd9f6ece, baseline=1.41.0-SNAPSHOT~794ff14344

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.244 ms) : 0, 686244
BytebuddyAgent [candidate] (683.074 ms) : 0, 683074
GlobalTracer [baseline] (314.987 ms) : 0, 314987
GlobalTracer [candidate] (311.859 ms) : 0, 311859
AppSec [baseline] (54.519 ms) : 0, 54519
AppSec [candidate] (54.032 ms) : 0, 54032
Remote Config [baseline] (686.761 µs) : 0, 687
Remote Config [candidate] (662.605 µs) : 0, 663
Telemetry [baseline] (7.773 ms) : 0, 7773
Telemetry [candidate] (7.623 ms) : 0, 7623
section appsec
BytebuddyAgent [baseline] (699.118 ms) : 0, 699118
BytebuddyAgent [candidate] (699.399 ms) : 0, 699399
GlobalTracer [baseline] (308.404 ms) : 0, 308404
GlobalTracer [candidate] (308.145 ms) : 0, 308145
AppSec [baseline] (163.068 ms) : 0, 163068
AppSec [candidate] (163.321 ms) : 0, 163321
Remote Config [baseline] (639.895 µs) : 0, 640
Remote Config [candidate] (631.921 µs) : 0, 632
Telemetry [baseline] (8.927 ms) : 0, 8927
Telemetry [candidate] (8.561 ms) : 0, 8561
IAST [baseline] (20.037 ms) : 0, 20037
IAST [candidate] (20.048 ms) : 0, 20048
section iast
BytebuddyAgent [baseline] (796.428 ms) : 0, 796428
BytebuddyAgent [candidate] (803.886 ms) : 0, 803886
GlobalTracer [baseline] (300.631 ms) : 0, 300631
GlobalTracer [candidate] (302.398 ms) : 0, 302398
AppSec [baseline] (53.702 ms) : 0, 53702
AppSec [candidate] (56.074 ms) : 0, 56074
Remote Config [baseline] (610.564 µs) : 0, 611
Remote Config [candidate] (623.15 µs) : 0, 623
Telemetry [baseline] (6.97 ms) : 0, 6970
Telemetry [candidate] (7.133 ms) : 0, 7133
IAST [baseline] (24.426 ms) : 0, 24426
IAST [candidate] (22.02 ms) : 0, 22020
section profiling
BytebuddyAgent [baseline] (674.541 ms) : 0, 674541
BytebuddyAgent [candidate] (675.474 ms) : 0, 675474
GlobalTracer [baseline] (393.713 ms) : 0, 393713
GlobalTracer [candidate] (394.14 ms) : 0, 394140
AppSec [baseline] (54.481 ms) : 0, 54481
AppSec [candidate] (54.427 ms) : 0, 54427
Remote Config [baseline] (649.838 µs) : 0, 650
Remote Config [candidate] (646.028 µs) : 0, 646
Telemetry [baseline] (7.409 ms) : 0, 7409
Telemetry [candidate] (7.382 ms) : 0, 7382
ProfilingAgent [baseline] (96.547 ms) : 0, 96547
ProfilingAgent [candidate] (96.715 ms) : 0, 96715
Profiling [baseline] (96.57 ms) : 0, 96570
Profiling [candidate] (96.738 ms) : 0, 96738
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-01T14:07:37 2024-10-01T14:14:27
git_branch master bbujon/crashtracking
git_commit_date 1727781530 1727790769
git_commit_sha 794ff14 b1fd9f6
release_version 1.41.0-SNAPSHOT~794ff14344 1.41.0-SNAPSHOT~b1fd9f6ece
start_time 2024-10-01T14:07:24 2024-10-01T14:14:13
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727792414 1727792414
ci_job_id 657119741 657119741
ci_pipeline_id 45515924 45515924
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~b1fd9f6ece, baseline=1.41.0-SNAPSHOT~794ff14344
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.438 µs) : 352, 392
.   : milestone, 372,
iast (481.624 µs) : 460, 503
.   : milestone, 482,
iast_FULL (553.624 µs) : 532, 575
.   : milestone, 554,
iast_GLOBAL (510.816 µs) : 489, 533
.   : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (480.047 µs) : 459, 501
.   : milestone, 480,
iast_INACTIVE (447.971 µs) : 427, 469
.   : milestone, 448,
iast_TELEMETRY_OFF (480.907 µs) : 459, 503
.   : milestone, 481,
tracing (444.027 µs) : 423, 465
.   : milestone, 444,
section candidate
no_agent (370.996 µs) : 352, 390
.   : milestone, 371,
iast (486.334 µs) : 465, 508
.   : milestone, 486,
iast_FULL (549.961 µs) : 529, 571
.   : milestone, 550,
iast_GLOBAL (504.672 µs) : 483, 527
.   : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (477.104 µs) : 456, 498
.   : milestone, 477,
iast_INACTIVE (446.071 µs) : 425, 468
.   : milestone, 446,
iast_TELEMETRY_OFF (483.256 µs) : 461, 505
.   : milestone, 483,
tracing (444.168 µs) : 423, 465
.   : milestone, 444,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.438 µs [352.388 µs, 392.489 µs] -
iast 481.624 µs [460.217 µs, 503.032 µs] 109.186 µs (29.3%)
iast_FULL 553.624 µs [532.297 µs, 574.951 µs] 181.186 µs (48.6%)
iast_GLOBAL 510.816 µs [488.576 µs, 533.057 µs] 138.378 µs (37.2%)
iast_HARDCODED_SECRET_DISABLED 480.047 µs [459.013 µs, 501.081 µs] 107.609 µs (28.9%)
iast_INACTIVE 447.971 µs [427.296 µs, 468.646 µs] 75.533 µs (20.3%)
iast_TELEMETRY_OFF 480.907 µs [459.151 µs, 502.663 µs] 108.469 µs (29.1%)
tracing 444.027 µs [422.974 µs, 465.08 µs] 71.589 µs (19.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.996 µs [351.595 µs, 390.396 µs] -
iast 486.334 µs [464.887 µs, 507.781 µs] 115.338 µs (31.1%)
iast_FULL 549.961 µs [528.743 µs, 571.179 µs] 178.965 µs (48.2%)
iast_GLOBAL 504.672 µs [482.522 µs, 526.821 µs] 133.676 µs (36.0%)
iast_HARDCODED_SECRET_DISABLED 477.104 µs [456.162 µs, 498.046 µs] 106.108 µs (28.6%)
iast_INACTIVE 446.071 µs [424.603 µs, 467.539 µs] 75.075 µs (20.2%)
iast_TELEMETRY_OFF 483.256 µs [461.087 µs, 505.426 µs] 112.26 µs (30.3%)
tracing 444.168 µs [422.839 µs, 465.497 µs] 73.172 µs (19.7%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~b1fd9f6ece, baseline=1.41.0-SNAPSHOT~794ff14344
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.343 ms) : 1324, 1362
.   : milestone, 1343,
appsec (1.712 ms) : 1687, 1737
.   : milestone, 1712,
appsec_no_iast (1.717 ms) : 1693, 1740
.   : milestone, 1717,
iast (1.47 ms) : 1447, 1492
.   : milestone, 1470,
profiling (1.481 ms) : 1456, 1505
.   : milestone, 1481,
tracing (1.449 ms) : 1425, 1474
.   : milestone, 1449,
section candidate
no_agent (1.335 ms) : 1316, 1355
.   : milestone, 1335,
appsec (1.723 ms) : 1699, 1747
.   : milestone, 1723,
appsec_no_iast (1.731 ms) : 1707, 1755
.   : milestone, 1731,
iast (1.461 ms) : 1438, 1484
.   : milestone, 1461,
profiling (1.528 ms) : 1503, 1552
.   : milestone, 1528,
tracing (1.466 ms) : 1441, 1491
.   : milestone, 1466,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.324 ms, 1.362 ms] -
appsec 1.712 ms [1.687 ms, 1.737 ms] 368.658 µs (27.4%)
appsec_no_iast 1.717 ms [1.693 ms, 1.74 ms] 373.519 µs (27.8%)
iast 1.47 ms [1.447 ms, 1.492 ms] 126.747 µs (9.4%)
profiling 1.481 ms [1.456 ms, 1.505 ms] 137.601 µs (10.2%)
tracing 1.449 ms [1.425 ms, 1.474 ms] 106.017 µs (7.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.335 ms [1.316 ms, 1.355 ms] -
appsec 1.723 ms [1.699 ms, 1.747 ms] 387.497 µs (29.0%)
appsec_no_iast 1.731 ms [1.707 ms, 1.755 ms] 395.423 µs (29.6%)
iast 1.461 ms [1.438 ms, 1.484 ms] 125.988 µs (9.4%)
profiling 1.528 ms [1.503 ms, 1.552 ms] 192.234 µs (14.4%)
tracing 1.466 ms [1.441 ms, 1.491 ms] 130.619 µs (9.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/crashtracking
git_commit_date 1727781530 1727790769
git_commit_sha 794ff14 b1fd9f6
release_version 1.41.0-SNAPSHOT~794ff14344 1.41.0-SNAPSHOT~b1fd9f6ece
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1727793106 1727793106
ci_job_id 657119743 657119743
ci_pipeline_id 45515924 45515924
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~b1fd9f6ece, baseline=1.41.0-SNAPSHOT~794ff14344
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.25 s) : 15250000, 15250000
.   : milestone, 15250000,
appsec (15.238 s) : 15238000, 15238000
.   : milestone, 15238000,
iast (18.846 s) : 18846000, 18846000
.   : milestone, 18846000,
iast_GLOBAL (18.046 s) : 18046000, 18046000
.   : milestone, 18046000,
profiling (15.031 s) : 15031000, 15031000
.   : milestone, 15031000,
tracing (15.131 s) : 15131000, 15131000
.   : milestone, 15131000,
section candidate
no_agent (15.118 s) : 15118000, 15118000
.   : milestone, 15118000,
appsec (15.034 s) : 15034000, 15034000
.   : milestone, 15034000,
iast (18.982 s) : 18982000, 18982000
.   : milestone, 18982000,
iast_GLOBAL (18.208 s) : 18208000, 18208000
.   : milestone, 18208000,
profiling (15.005 s) : 15005000, 15005000
.   : milestone, 15005000,
tracing (15.295 s) : 15295000, 15295000
.   : milestone, 15295000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.25 s [15.25 s, 15.25 s] -
appsec 15.238 s [15.238 s, 15.238 s] -12.0 ms (-0.1%)
iast 18.846 s [18.846 s, 18.846 s] 3.596 s (23.6%)
iast_GLOBAL 18.046 s [18.046 s, 18.046 s] 2.796 s (18.3%)
profiling 15.031 s [15.031 s, 15.031 s] -219.0 ms (-1.4%)
tracing 15.131 s [15.131 s, 15.131 s] -119.0 ms (-0.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.118 s [15.118 s, 15.118 s] -
appsec 15.034 s [15.034 s, 15.034 s] -84.0 ms (-0.6%)
iast 18.982 s [18.982 s, 18.982 s] 3.864 s (25.6%)
iast_GLOBAL 18.208 s [18.208 s, 18.208 s] 3.09 s (20.4%)
profiling 15.005 s [15.005 s, 15.005 s] -113.0 ms (-0.7%)
tracing 15.295 s [15.295 s, 15.295 s] 177.0 ms (1.2%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~b1fd9f6ece, baseline=1.41.0-SNAPSHOT~794ff14344
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.46 ms) : 1449, 1471
.   : milestone, 1460,
appsec (2.302 ms) : 2262, 2342
.   : milestone, 2302,
iast (2.069 ms) : 2017, 2120
.   : milestone, 2069,
iast_GLOBAL (2.11 ms) : 2058, 2162
.   : milestone, 2110,
profiling (1.934 ms) : 1893, 1975
.   : milestone, 1934,
tracing (1.899 ms) : 1861, 1938
.   : milestone, 1899,
section candidate
no_agent (1.457 ms) : 1446, 1468
.   : milestone, 1457,
appsec (2.301 ms) : 2261, 2341
.   : milestone, 2301,
iast (2.068 ms) : 2016, 2120
.   : milestone, 2068,
iast_GLOBAL (2.103 ms) : 2052, 2155
.   : milestone, 2103,
profiling (1.938 ms) : 1896, 1980
.   : milestone, 1938,
tracing (1.908 ms) : 1868, 1947
.   : milestone, 1908,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.449 ms, 1.471 ms] -
appsec 2.302 ms [2.262 ms, 2.342 ms] 841.78 µs (57.7%)
iast 2.069 ms [2.017 ms, 2.12 ms] 608.873 µs (41.7%)
iast_GLOBAL 2.11 ms [2.058 ms, 2.162 ms] 650.186 µs (44.5%)
profiling 1.934 ms [1.893 ms, 1.975 ms] 474.1 µs (32.5%)
tracing 1.899 ms [1.861 ms, 1.938 ms] 439.438 µs (30.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.457 ms [1.446 ms, 1.468 ms] -
appsec 2.301 ms [2.261 ms, 2.341 ms] 843.667 µs (57.9%)
iast 2.068 ms [2.016 ms, 2.12 ms] 611.187 µs (42.0%)
iast_GLOBAL 2.103 ms [2.052 ms, 2.155 ms] 646.573 µs (44.4%)
profiling 1.938 ms [1.896 ms, 1.98 ms] 480.964 µs (33.0%)
tracing 1.908 ms [1.868 ms, 1.947 ms] 451.031 µs (31.0%)

@PerfectSlayer
fix(crashtracking): Fix crash tracking log parser
b1fd9f6 
1. Summary uses time format with space padding for days of the month while our parser uses zero padded number.

Change the DateTimeFormatter pattern and add a test to cover this case.

2. Summary time can be based of offset and time zone name.

Add two parsers to support both formats.
@PerfectSlayer PerfectSlayer merged commit 069b677 into master Oct 2, 2024
99 of 101 checks passed
@PerfectSlayer PerfectSlayer deleted the bbujon/crashtracking branch October 2, 2024 06:14
@github-actions github-actions bot added this to the 1.41.0 milestone Oct 2, 2024
@PerfectSlayer PerfectSlayer mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smola smola smola approved these changes

Assignees
No one assigned
Labels
comp: crash tracking Crash tracking type: bug
Projects
None yet
Milestone
1.41.0
Development

Successfully merging this pull request may close these issues.
2 participants
@PerfectSlayer @smola