Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/civisibility: change the default value for DD_CIVISIBILITY_ENABLED to false #2893

Merged
merged 1 commit into from
Sep 27, 2024
Merged

internal/civisibility: change the default value for DD_CIVISIBILITY_ENABLED to false #2893

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions internal/civisibility/integrations/gotesting/instrumentation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,12 @@ func isCiVisibilityEnabled() bool {
// let's check if the value has already been loaded from the env-vars
enabledValue := atomic.LoadInt32(&ciVisibilityEnabledValue)
if enabledValue == -1 {
// Get the DD_CIVISIBILITY_ENABLED env var, if not present we default to true. This is because if we are here, it means
// Get the DD_CIVISIBILITY_ENABLED env var, if not present we default to false (for now). This is because if we are here, it means
// that the process was instrumented for ci visibility or by using orchestrion.
// So effectively this env-var will act as a kill switch for cases where the code is instrumented, but
// we don't want the civisibility instrumentation to be enabled.
if internal.BoolEnv(constants.CIVisibilityEnabledEnvironmentVariable, true) {
// *** For preview releases we will default to false, meaning that the use of ci visibility must be opt-in ***
if internal.BoolEnv(constants.CIVisibilityEnabledEnvironmentVariable, false) {
atomic.StoreInt32(&ciVisibilityEnabledValue, 1)
return true
} else {
Expand Down
Loading