Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/civisibility: change the default value for DD_CIVISIBILITY_ENABLED to false #2893

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

tonyredondo
Copy link
Member

What does this PR do?

Change the default value for CI Visibility enabled to be false at least for preview releases. So users require to opt-in using the DD_CIVISIBILITY_ENABLED environment variable.

Motivation

We don't want to enable CI Visibility by default when we are running tests instrumented by orchestrion while we are in preview mode. We will revisit this once we go to GA.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

…bled to be false at least for preview releases. So users require to opt-in using an environment variable.
@tonyredondo tonyredondo self-assigned this Sep 26, 2024
@tonyredondo tonyredondo marked this pull request as ready for review September 26, 2024 21:11
@tonyredondo tonyredondo requested a review from a team as a code owner September 26, 2024 21:11
@pr-commenter
Copy link

pr-commenter bot commented Sep 26, 2024

Benchmarks

Benchmark execution time: 2024-09-26 21:49:33

Comparing candidate commit c2bfe58 in PR branch tony/civisibility-disable-by-default with baseline commit 043dcd1 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

@tonyredondo tonyredondo merged commit 82f0b8e into main Sep 27, 2024
145 checks passed
@tonyredondo tonyredondo deleted the tony/civisibility-disable-by-default branch September 27, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants