contrib/database/sql: remove broken execution trace tests #2789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
apm:ecosystem
The execution tracer tests for contrib/database/sql use a parser which does not support Go 1.21 or newer traces. The tests should be ported to use golang.org/x/exp/trace and moved to internal/exectracetest, but for now they are effectively broken since we no longer run Go 1.20 in CI. Remove them to fix CI on main, until we port them to the new parser.
nsrip-dd
force-pushed
the
nick.ripley/remove-contrib-exectrace-test
branch
from
1f4b9c6 to
472867f
Compare
darccio
approved these changes
Jul 16, 2024
BenchmarksBenchmark execution time: 2024-07-16 13:32:08 Comparing candidate commit 472867f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 1 unstable metrics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The execution tracer tests for contrib/database/sql use a parser which
does not support Go 1.21 or newer traces. The tests should be ported to
use golang.org/x/exp/trace and moved to internal/exectracetest, but for
now they are effectively broken since we no longer run Go 1.20 in CI.
Remove them to fix CI on main, until we port them to the new parser.