Skip to content

Commit

Permalink
contrib/database/sql: remove broken execution trace tests (#2789)
Browse files Browse the repository at this point in the history
The execution tracer tests for contrib/database/sql use a parser which
does not support Go 1.21 or newer traces. The tests should be ported to
use golang.org/x/exp/trace and moved to internal/exectracetest, but for
now they are effectively broken since we no longer run Go 1.20 in CI.
Remove them to fix CI on main, until we port them to the new parser.
  • Loading branch information
nsrip-dd authored Jul 16, 2024
1 parent a8bb469 commit d3a6549
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 149 deletions.
146 changes: 0 additions & 146 deletions contrib/database/sql/exec_trace_test.go

This file was deleted.

1 change: 0 additions & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ require (
gorm.io/driver/postgres v1.4.6
gorm.io/driver/sqlserver v1.4.2
gorm.io/gorm v1.25.3
honnef.co/go/gotraceui v0.4.0
k8s.io/apimachinery v0.23.17
k8s.io/client-go v0.23.17
modernc.org/sqlite v1.28.0
Expand Down
2 changes: 0 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -3058,8 +3058,6 @@ gotest.tools/gotestsum v1.8.2/go.mod h1:6JHCiN6TEjA7Kaz23q1bH0e2Dc3YJjDUZ0DmctFZ
gotest.tools/v3 v3.0.2/go.mod h1:3SzNCllyD9/Y+b5r9JIKQ474KzkZyqLqEfYqMsX94Bk=
gotest.tools/v3 v3.0.3/go.mod h1:Z7Lb0S5l+klDB31fvDQX8ss/FlKDxtlFlw3Oa8Ymbl8=
gotest.tools/v3 v3.3.0/go.mod h1:Mcr9QNxkg0uMvy/YElmo4SpXgJKWgQvYrT7Kw5RzJ1A=
honnef.co/go/gotraceui v0.4.0 h1:6CioQQRvVEWTQ9fXcGY3LXSuKL6cgavln5ZMKVbF5yE=
honnef.co/go/gotraceui v0.4.0/go.mod h1:hcoo31yypIJuS1FXdFWjKu1PVJrdpIL9ShdQvMvm9qw=
honnef.co/go/tools v0.0.0-20190102054323-c2f93a96b099/go.mod h1:rf3lG4BRIbNafJWhAfAdb/ePZxsR/4RtNHQocxwk9r4=
honnef.co/go/tools v0.0.0-20190106161140-3f1c8253044a/go.mod h1:rf3lG4BRIbNafJWhAfAdb/ePZxsR/4RtNHQocxwk9r4=
honnef.co/go/tools v0.0.0-20190418001031-e561f6794a2a/go.mod h1:rf3lG4BRIbNafJWhAfAdb/ePZxsR/4RtNHQocxwk9r4=
Expand Down

0 comments on commit d3a6549

Please sign in to comment.