Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/IBM/sarama.v1: add DSM support #2788

Merged
merged 6 commits into from
Jul 23, 2024
Merged

contrib/IBM/sarama.v1: add DSM support #2788

merged 6 commits into from
Jul 23, 2024

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Jul 16, 2024 •
edited
Loading

What does this PR do?

Ports changes from #2006 and #2353 to IBM/sarama.v1.

Also add some missing DSM tests for some functionality (SyncProducerSendMessages, AsyncProducer)

Motivation

Add DSM support for IBM/sarama.v1

Closes #2573, closes #2481

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Jul 16, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jul 17, 2024 •
edited
Loading

Benchmarks

Benchmark execution time: 2024-07-23 09:23:32

Comparing candidate commit 3ddd08c in PR branch rarguelloF/AIDM-211/dsm-ibm-sarama with baseline commit 9e05fc2 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 0 unstable metrics.

@rarguelloF rarguelloF marked this pull request as ready for review July 17, 2024 13:48
@rarguelloF rarguelloF requested review from a team as code owners July 17, 2024 13:48
darccio
darccio approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@darccio darccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rarguelloF rarguelloF merged commit 05a8b5a into main Jul 23, 2024
164 checks passed
@rarguelloF rarguelloF deleted the rarguelloF/AIDM-211/dsm-ibm-sarama branch July 23, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darccio darccio darccio approved these changes

Assignees
No one assigned
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2/contrib: Add datastreams support for contrib/IBM/sarama Add datastreams support for contrib/IBM/sarama.v1
2 participants
@rarguelloF @darccio