contrib/kafka: take env variable into account to enable DSM #2353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
apm:ecosystem
piochelepiotr
approved these changes
Nov 14, 2023
rarguelloF
reviewed
Nov 15, 2023
contrib/Shopify/sarama/option.go
Outdated
Comment on lines
59
to
60
| // | ||
| // Deprecated: Use the environment variable DD_DATA_STREAMS_ENABLED instead |
There was a problem hiding this comment.
why can't we keep both? I think its a common pattern in the Go tracer to provide both in-code and env variable choices for configurations
There was a problem hiding this comment.
hmm, yes that's an argument that can be heard. Though it lets go users do stuff that won't work in other tracers, which is not the best, but being consistent within the go tracer itself is probably more important.
dianashevchenko
approved these changes
Nov 17, 2023
|
/merge |
|
❌ MergeQueue You are not allowed to use the merge queue towards If you need support, contact us on slack #ci-interfaces with those details! |
|
/merge |
|
❌ MergeQueue You are not allowed to use the merge queue towards If you need support, contact us on slack #ci-interfaces with those details! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most tracers, setting the
DD_DATA_STREAMS_ENABLEDenv variable is enough to enable DSM, but in go this has to be done at wrapping time, which is inconsistent with other languages.In this change, I deprecated the option to enable DSM, in favor of the env variable.
For Datadog employees:
@DataDog/security-design-and-guidance.