Add SSI denylist and tests #5928

andrewlock · 2024-08-22T10:44:18Z

Summary of changes

Adds the SSI denylist and initial testing

Reason for change

We want to bail out early if we don't support the platform.

Implementation details

Add a requirements.json file that specifies supported hosts and some of the patterns we expect to block or allow injection on

Test coverage

This includes a requirements_json_test stage. This will be ported to the one-pipeline once the auto_inject code is merged, this is a PoC that proves it works atm

Other details

Will backport this to 2.x as well

datadog-ddstaging · 2024-08-22T11:03:23Z

Datadog Report

Branch report: andrew/ci/add-ssi-denylist
Commit report: 67bda22
Test service: dd-trace-dotnet

✅ 0 Failed, 379572 Passed, 3091 Skipped, 27h 26m 4.33s Total Time

andrewlock · 2024-08-22T11:11:24Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5928) - mean (70ms)  : 67, 72
     .   : milestone, 70,
    master - mean (70ms)  : 67, 72
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (5928) - mean (1,113ms)  : 1088, 1137
     .   : milestone, 1113,
    master - mean (1,106ms)  : 1086, 1127
     .   : milestone, 1106,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5928) - mean (108ms)  : 106, 111
     .   : milestone, 108,
    master - mean (109ms)  : 106, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5928) - mean (770ms)  : 754, 787
     .   : milestone, 770,
    master - mean (772ms)  : 755, 788
     .   : milestone, 772,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5928) - mean (92ms)  : 89, 95
     .   : milestone, 92,
    master - mean (92ms)  : 89, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (5928) - mean (724ms)  : 709, 740
     .   : milestone, 724,
    master - mean (726ms)  : 707, 746
     .   : milestone, 726,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5928) - mean (191ms)  : 188, 194
     .   : milestone, 191,
    master - mean (191ms)  : 188, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (5928) - mean (1,201ms)  : 1177, 1225
     .   : milestone, 1201,
    master - mean (1,202ms)  : 1175, 1230
     .   : milestone, 1202,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5928) - mean (276ms)  : 272, 281
     .   : milestone, 276,
    master - mean (276ms)  : 271, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (5928) - mean (942ms)  : 928, 956
     .   : milestone, 942,
    master - mean (947ms)  : 929, 964
     .   : milestone, 947,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5928) - mean (265ms)  : 261, 269
     .   : milestone, 265,
    master - mean (265ms)  : 261, 268
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (5928) - mean (927ms)  : 905, 948
     .   : milestone, 927,
    master - mean (932ms)  : 910, 953
     .   : milestone, 932,

andrewlock · 2024-08-22T14:15:25Z

Benchmarks Report for tracer 🐌

Benchmarks for #5928 compared to master:

2 benchmarks are faster, with geometric mean 1.159
1 benchmarks are slower, with geometric mean 1.133
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.74μs	43.6ns	296ns	0.0153	0.00766	0	5.42 KB
master	`StartStopWithChild`	netcoreapp3.1	9.86μs	55.6ns	377ns	0.0187	0.00469	0	5.62 KB
master	`StartStopWithChild`	net472	16.3μs	57.1ns	206ns	1.04	0.321	0.107	6.06 KB
#5928	`StartStopWithChild`	net6.0	7.62μs	43ns	285ns	0.0159	0.00797	0	5.42 KB
#5928	`StartStopWithChild`	netcoreapp3.1	9.94μs	55.2ns	336ns	0.0236	0.0141	0.00472	5.62 KB
#5928	`StartStopWithChild`	net472	16.6μs	34.3ns	128ns	1.04	0.326	0.0859	6.06 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	512μs	151ns	566ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	640μs	396ns	1.54μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	840μs	319ns	1.24μs	0.417	3.3 KB
#5928	`WriteAndFlushEnrichedTraces`	net6.0	482μs	253ns	978ns	0	2.7 KB
#5928	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	640μs	358ns	1.39μs	0	2.7 KB
#5928	`WriteAndFlushEnrichedTraces`	net472	837μs	465ns	1.8μs	0.417	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	203μs	1.65μs	16.4μs	0.23	18.45 KB
master	`SendRequest`	netcoreapp3.1	237μs	1.39μs	13.9μs	0.224	20.61 KB
master	`SendRequest`	net472	0ns	0ns	0ns	0	0 b
#5928	`SendRequest`	net6.0	210μs	1.23μs	11.2μs	0.198	18.45 KB
#5928	`SendRequest`	netcoreapp3.1	225μs	1.31μs	11.5μs	0.244	20.61 KB
#5928	`SendRequest`	net472	0.0037ns	0.00126ns	0.00489ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	581μs	3.34μs	26.5μs	0.566	0	0	41.59 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	709μs	3.96μs	24.8μs	0.351	0	0	41.67 KB
master	`WriteAndFlushEnrichedTraces`	net472	886μs	4.26μs	16.5μs	8.36	2.64	0.44	53.29 KB
#5928	`WriteAndFlushEnrichedTraces`	net6.0	581μs	2.25μs	7.78μs	0.581	0	0	41.6 KB
#5928	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	720μs	3.13μs	11.7μs	0.347	0	0	41.81 KB
#5928	`WriteAndFlushEnrichedTraces`	net472	872μs	2.82μs	10.6μs	8.08	2.55	0.425	53.34 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.33μs	0.832ns	3.22ns	0.014	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.77μs	1.89ns	7.34ns	0.0133	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.16μs	1.8ns	6.97ns	0.157	0	987 B
#5928	`ExecuteNonQuery`	net6.0	1.42μs	1.07ns	4.15ns	0.0141	0	1.02 KB
#5928	`ExecuteNonQuery`	netcoreapp3.1	1.78μs	1.9ns	7.12ns	0.0132	0	1.02 KB
#5928	`ExecuteNonQuery`	net472	2.03μs	2.31ns	8.95ns	0.157	0.00102	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.25μs	0.555ns	2.08ns	0.0138	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.62μs	1.51ns	5.63ns	0.0128	976 B
master	`CallElasticsearch`	net472	2.52μs	1.87ns	7.23ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.26μs	0.446ns	1.67ns	0.0133	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.67μs	1.56ns	6.02ns	0.0134	1.02 KB
master	`CallElasticsearchAsync`	net472	2.54μs	1.56ns	6.03ns	0.167	1.05 KB
#5928	`CallElasticsearch`	net6.0	1.28μs	0.588ns	2.2ns	0.0135	976 B
#5928	`CallElasticsearch`	netcoreapp3.1	1.58μs	3.07ns	11.5ns	0.0126	976 B
#5928	`CallElasticsearch`	net472	2.49μs	0.789ns	2.84ns	0.158	995 B
#5928	`CallElasticsearchAsync`	net6.0	1.33μs	0.431ns	1.61ns	0.0133	952 B
#5928	`CallElasticsearchAsync`	netcoreapp3.1	1.73μs	1.48ns	5.56ns	0.0139	1.02 KB
#5928	`CallElasticsearchAsync`	net472	2.57μs	1.97ns	7.37ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5928

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0	1.133	1,229.48	1,392.69

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.23μs	0.6ns	2.33ns	0.0135	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.59μs	0.764ns	2.86ns	0.0128	952 B
master	`ExecuteAsync`	net472	1.76μs	0.656ns	2.46ns	0.145	915 B
#5928	`ExecuteAsync`	net6.0	1.39μs	0.613ns	2.29ns	0.0133	952 B
#5928	`ExecuteAsync`	netcoreapp3.1	1.68μs	0.897ns	3.36ns	0.0127	952 B
#5928	`ExecuteAsync`	net472	1.8μs	0.881ns	3.41ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.2μs	1.88ns	7.29ns	0.0315	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.07μs	3.93ns	15.2ns	0.0356	2.76 KB
master	`SendAsync`	net472	7.8μs	2.37ns	9.19ns	0.5	3.15 KB
#5928	`SendAsync`	net6.0	4.15μs	1.34ns	5.01ns	0.0312	2.22 KB
#5928	`SendAsync`	netcoreapp3.1	5.1μs	1.93ns	7.21ns	0.0357	2.76 KB
#5928	`SendAsync`	net472	7.72μs	3.86ns	14.9ns	0.498	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.57μs	0.854ns	3.19ns	0.0233	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.18μs	1.27ns	4.9ns	0.0226	1.64 KB
master	`EnrichedLog`	net472	2.62μs	0.91ns	3.4ns	0.25	1.57 KB
#5928	`EnrichedLog`	net6.0	1.5μs	0.616ns	2.39ns	0.0233	1.64 KB
#5928	`EnrichedLog`	netcoreapp3.1	2.33μs	1.07ns	4.14ns	0.0221	1.64 KB
#5928	`EnrichedLog`	net472	2.64μs	0.677ns	2.62ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	118μs	177ns	684ns	0.059	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	119μs	155ns	599ns	0.0598	0	4.28 KB
master	`EnrichedLog`	net472	151μs	275ns	1.06μs	0.679	0.226	4.46 KB
#5928	`EnrichedLog`	net6.0	117μs	172ns	667ns	0.0574	0	4.28 KB
#5928	`EnrichedLog`	netcoreapp3.1	122μs	292ns	1.13μs	0	0	4.28 KB
#5928	`EnrichedLog`	net472	150μs	104ns	403ns	0.677	0.226	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.24μs	3.65ns	14.1ns	0.0309	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.26μs	2.53ns	9.8ns	0.0298	2.2 KB
master	`EnrichedLog`	net472	4.82μs	2.05ns	7.93ns	0.318	2.02 KB
#5928	`EnrichedLog`	net6.0	3.16μs	0.57ns	2.13ns	0.0301	2.2 KB
#5928	`EnrichedLog`	netcoreapp3.1	4.12μs	1.4ns	5.23ns	0.0289	2.2 KB
#5928	`EnrichedLog`	net472	4.83μs	1.66ns	6.43ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.35μs	0.615ns	2.38ns	0.0164	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.76μs	0.901ns	3.49ns	0.0149	0	1.14 KB
master	`SendReceive`	net472	2.08μs	1.04ns	3.89ns	0.183	0.00104	1.16 KB
#5928	`SendReceive`	net6.0	1.35μs	0.96ns	3.72ns	0.0162	0	1.14 KB
#5928	`SendReceive`	netcoreapp3.1	1.73μs	0.659ns	2.46ns	0.0155	0	1.14 KB
#5928	`SendReceive`	net472	2.14μs	1.1ns	4.27ns	0.183	0.00107	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.64μs	0.576ns	2.15ns	0.0224	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.88μs	1.21ns	4.38ns	0.0213	1.65 KB
master	`EnrichedLog`	net472	4.45μs	2.08ns	8.06ns	0.322	2.04 KB
#5928	`EnrichedLog`	net6.0	2.65μs	0.512ns	1.92ns	0.0225	1.6 KB
#5928	`EnrichedLog`	netcoreapp3.1	3.93μs	2.11ns	8.17ns	0.0216	1.65 KB
#5928	`EnrichedLog`	net472	4.28μs	2.5ns	9.69ns	0.324	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5928

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.169	467.80	400.24

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	468ns	0.176ns	0.682ns	0.00802	576 B
master	`StartFinishSpan`	netcoreapp3.1	615ns	1.44ns	5.58ns	0.00771	576 B
master	`StartFinishSpan`	net472	634ns	1.1ns	4.28ns	0.0917	578 B
master	`StartFinishScope`	net6.0	494ns	0.224ns	0.868ns	0.00985	696 B
master	`StartFinishScope`	netcoreapp3.1	766ns	1.47ns	5.1ns	0.00953	696 B
master	`StartFinishScope`	net472	898ns	0.377ns	1.41ns	0.104	658 B
#5928	`StartFinishSpan`	net6.0	400ns	0.216ns	0.835ns	0.00805	576 B
#5928	`StartFinishSpan`	netcoreapp3.1	583ns	0.254ns	0.983ns	0.0079	576 B
#5928	`StartFinishSpan`	net472	685ns	0.878ns	3.4ns	0.0915	578 B
#5928	`StartFinishScope`	net6.0	477ns	0.246ns	0.951ns	0.00979	696 B
#5928	`StartFinishScope`	netcoreapp3.1	732ns	0.585ns	2.27ns	0.00959	696 B
#5928	`StartFinishScope`	net472	907ns	0.909ns	3.52ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5928

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.150	685.72	596.18

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	686ns	2.3ns	8.9ns	0.00977	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	964ns	2.07ns	8.01ns	0.00961	696 B
master	`RunOnMethodBegin`	net472	1.17μs	1.12ns	4.36ns	0.104	658 B
#5928	`RunOnMethodBegin`	net6.0	596ns	0.389ns	1.51ns	0.00984	696 B
#5928	`RunOnMethodBegin`	netcoreapp3.1	986ns	1.37ns	5.29ns	0.00928	696 B
#5928	`RunOnMethodBegin`	net472	1.17μs	1.29ns	5ns	0.104	658 B

.gitlab-ci.yml

andrewlock · 2024-09-16T12:49:46Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5928) (11.135M)   : 0, 11135451
    master (11.127M)   : 0, 11126752
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (5928) (7.455M)   : 0, 7454973
    master (7.377M)   : 0, 7376563
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.612M)   : 0, 7612091

    section Manual
    master (11.042M)   : 0, 11042306

    section Manual + Automatic
    This PR (5928) (6.885M)   : 0, 6885258
    master (6.743M)   : 0, 6742844

    section DD_TRACE_ENABLED=0
    master (10.176M)   : 0, 10175955

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5928) (9.407M)   : 0, 9407418
    master (9.601M)   : 0, 9600942
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (5928) (6.388M)   : 0, 6388490
    master (6.478M)   : 0, 6477825

    section Trace stats
    master (6.824M)   : 0, 6824216

    section Manual
    master (9.656M)   : 0, 9655746

    section Manual + Automatic
    This PR (5928) (6.152M)   : 0, 6151550
    master (6.006M)   : 0, 6006388

    section DD_TRACE_ENABLED=0
    master (8.643M)   : 0, 8642890

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5928) (10.161M)   : 0, 10160901
    master (10.217M)   : 0, 10217051
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (5928) (6.587M)   : 0, 6587005
    master (6.825M)   : 0, 6825492
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.437M)   : 0, 7437330

    section Manual
    master (9.999M)   : 0, 9998601

    section Manual + Automatic
    This PR (5928) (6.317M)   : 0, 6316857
    master (6.024M)   : 0, 6023637

    section DD_TRACE_ENABLED=0
    master (9.286M)   : 0, 9286300

tracer/build/artifacts/requirements.json

…l-out conditions

This reverts commit 605e22b.

This reverts commit f2d5d45.

## Summary of changes Adds the SSI denylist and initial testing ## Reason for change We want to bail out early if we don't support the platform. ## Implementation details Add a requirements.json file that specifies supported hosts and some of the patterns we expect to block or allow injection on ## Test coverage This includes a `requirements_json_test` stage. This will be ported to the one-pipeline once the `auto_inject` code is merged, this is a PoC that proves it works atm ## Other details Will backport this to 2.x as well

## Summary of changes Adds the SSI denylist and initial testing ## Reason for change We want to bail out early if we don't support the platform. ## Implementation details Add a requirements.json file that specifies supported hosts and some of the patterns we expect to block or allow injection on ## Test coverage This includes a `requirements_json_test` stage. This will be ported to the one-pipeline once the `auto_inject` code is merged, this is a PoC that proves it works atm ## Other details Backport of #5928

andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Aug 22, 2024

andrewlock force-pushed the andrew/ci/add-ssi-denylist branch 3 times, most recently from 499b7ee to b0acedd Compare August 30, 2024 12:23

andrewlock commented Aug 30, 2024

View reviewed changes

.gitlab-ci.yml Show resolved Hide resolved

andrewlock force-pushed the andrew/ci/add-ssi-denylist branch from b0acedd to 9cc1910 Compare September 5, 2024 11:34

andrewlock marked this pull request as ready for review September 5, 2024 11:36

andrewlock requested review from a team as code owners September 5, 2024 11:36

kevingosse approved these changes Sep 5, 2024

View reviewed changes

andrewlock force-pushed the andrew/ci/add-ssi-denylist branch from df45e2b to 6b2b0ce Compare September 6, 2024 11:19

randomanderson approved these changes Sep 6, 2024

View reviewed changes

andrewlock force-pushed the andrew/ci/add-ssi-denylist branch from aac8631 to eb5bcb0 Compare September 16, 2024 11:31

andrewlock force-pushed the andrew/ci/add-ssi-denylist branch from f2d5d45 to da096bf Compare September 17, 2024 12:42

andrewlock force-pushed the andrew/ci/add-ssi-denylist branch 3 times, most recently from ee513c5 to b3bff46 Compare September 30, 2024 15:26

andrewlock commented Oct 2, 2024

View reviewed changes

tracer/build/artifacts/requirements.json Outdated Show resolved Hide resolved

andrewlock force-pushed the andrew/ci/add-ssi-denylist branch from c37ad7d to 7019ce6 Compare October 4, 2024 13:23

andrewlock added 7 commits October 21, 2024 09:12

Add requirements.json and testing files

e7ef450

Document that we should update requirements.json if we update the bai…

a12e22a

…l-out conditions

TEMP use branch of libdatadog

c81d1c5

Add requirements.json to package

6640607

Update requirements to latest spec

8f96552

Revert "TEMP use branch of libdatadog"

03fd74a

This reverts commit 605e22b.

TEMP checkout the updated-denylist branch

b7600d7

andrewlock added 2 commits October 21, 2024 09:12

Revert "TEMP checkout the updated-denylist branch"

20cec93

This reverts commit f2d5d45.

Apply suggestions from code review

67bda22

andrewlock force-pushed the andrew/ci/add-ssi-denylist branch from 7019ce6 to 67bda22 Compare October 21, 2024 08:12

andrewlock merged commit b756cd9 into master Oct 21, 2024
86 checks passed

andrewlock deleted the andrew/ci/add-ssi-denylist branch October 21, 2024 17:06

github-actions bot added this to the vNext-v3 milestone Oct 21, 2024

andrewlock mentioned this pull request Oct 23, 2024

Add SSI denylist and tests (#5928 => v2) #6182

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add SSI denylist and tests #5928

Add SSI denylist and tests #5928

andrewlock commented Aug 22, 2024

datadog-ddstaging bot commented Aug 22, 2024 •

edited

Loading

andrewlock commented Aug 22, 2024 •

edited

Loading

andrewlock commented Aug 22, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5928

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #5928

Raw results

Faster 🎉 in #5928

Raw results

andrewlock commented Sep 16, 2024 •

edited

Loading

Add SSI denylist and tests #5928

Add SSI denylist and tests #5928

Conversation

andrewlock commented Aug 22, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging bot commented Aug 22, 2024 • edited Loading

Datadog Report

andrewlock commented Aug 22, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Aug 22, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5928

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #5928

Raw results

Faster 🎉 in #5928

Raw results

andrewlock commented Sep 16, 2024 • edited Loading

Throughput/Crank Report ⚡

datadog-ddstaging bot commented Aug 22, 2024 •

edited

Loading

andrewlock commented Aug 22, 2024 •

edited

Loading

andrewlock commented Aug 22, 2024 •

edited

Loading

andrewlock commented Sep 16, 2024 •

edited

Loading