Skip to content

Commit

Permalink
Document that we should update requirements.json if we update the bai…
Browse files Browse the repository at this point in the history
…l-out conditions
  • Loading branch information
andrewlock committed Sep 5, 2024
1 parent afd75ac commit 9cc1910
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ namespace datadog::shared::nativeloader
// We don't want to instrument _build_ processes in dotnet by default, as they generally
// don't give useful information, add latency, and risk triggering bugs in the runtime,
// particularly around shutdown, like this one: https://github.com/dotnet/runtime/issues/55441
// Note that you also consider adding to the SSI tracer/build/artifacts/requirements.json file
const auto [process_command_line , tokenized_command_line] = GetCurrentProcessCommandLine();
Log::Info("Process CommandLine: ", process_command_line);

Expand Down
1 change: 1 addition & 0 deletions shared/src/Datadog.Trace.ClrProfiler.Native/util.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ const ::shared::WSTRING cfg_copying_originals_modules_env = WStr("DD_COPY_ORIGIN
const ::shared::WSTRING cfg_log_directory_env = WStr("DD_TRACE_LOG_DIRECTORY");

// Note that this list should be kept in sync with the values in tracer/src/Datadog.Tracer.Native/dd_profiler_constants.h
// Note that you also consider adding to the SSI tracer/build/artifacts/requirements.json file
const shared::WSTRING default_exclude_assemblies[]{
WStr("dd-trace"),
WStr("dd-trace.exe"),
Expand Down
1 change: 1 addition & 0 deletions tracer/src/Datadog.Tracer.Native/dd_profiler_constants.h
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ const shared::WSTRING include_assemblies[]{
};

// Note that this list should be kept in sync with the values in shared/src/Datadog.Trace.ClrProfiler.Native/util.h
// Note that you also consider adding to the SSI tracer/build/artifacts/requirements.json file
const shared::WSTRING default_exclude_assemblies[]{
WStr("dd-trace"),
WStr("dd-trace.exe"),
Expand Down

0 comments on commit 9cc1910

Please sign in to comment.