Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard CRD] Use fully-qualified domain name finalizer #1398

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

tbavelier
Copy link
Member

What does this PR do?

Motivation

  • Refer to main PR

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.40%. Comparing base (c9cc04d) to head (6f6bfc9).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             v1.9    #1398   +/-   ##
=======================================
  Coverage   47.40%   47.40%           
=======================================
  Files         223      223           
  Lines       19244    19244           
=======================================
  Hits         9123     9123           
  Misses       9635     9635           
  Partials      486      486           
Flag Coverage Δ
unittests 47.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/controller/datadogdashboard/finalizer.go 61.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9cc04d...6f6bfc9. Read the comment docs.

@tbavelier tbavelier added this to the v1.9.0 milestone Sep 11, 2024
@tbavelier
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Sep 12, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in v1.9 is 16m.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Sep 12, 2024

🚨 MergeQueue: This merge request is in error

mergequeue build completed successfully, but the github api returned an error while merging the pr.
It's probably because:

  • repository configuration requires approval by code owners, but no code owner approved this PR
  • target branch of PR is restricted to only allow up-to-date branches, but the pr is now outdated
Details

Error: PUT https://api.github.com/repos/DataDog/datadog-operator/pulls/1398/merge: 405 6 of 6 required status checks are expected. []

FullStacktrace:
activity error (type: github.GithubService_MergePullRequest, scheduledEventID: 41, startedEventID: 42, identity: 1@github-worker-59f6756d79-gprcs@): PUT https://api.github.com/repos/DataDog/datadog-operator/pulls/1398/merge: 405 6 of 6 required status checks are expected. [] (type: ErrorResponse, retryable: true)

If you need support, contact us on Slack #devflow with those details!

@khewonc khewonc merged commit d44647e into v1.9 Sep 12, 2024
16 checks passed
@khewonc khewonc deleted the tbavelier/cherry_pick_1397 branch September 12, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants