-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CECO-1441] Use fully-qualified domain name finalizer #1397
[CECO-1441] Use fully-qualified domain name finalizer #1397
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1397 +/- ##
=======================================
Coverage 47.40% 47.40%
=======================================
Files 223 223
Lines 19244 19244
=======================================
Hits 9123 9123
Misses 9635 9635
Partials 486 486
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
* Use fully-qualified domain name to avoid apiserver warning on dashboard CRD * fix controller unit test
What does this PR do?
Motivation
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
KubeAPIWarningLogger
in the operator, then delete the CR withkubectl delete
and ensure the CR is properly deletedChecklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label