Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authorizer trace context #256

Merged
merged 28 commits into from
Nov 15, 2022
Merged

authorizer trace context #256

merged 28 commits into from
Nov 15, 2022

Conversation

joeyzhao2018
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 commented Oct 26, 2022

What does this PR do?

Fixes DataDog/serverless-plugin-datadog#252 for Python
Ticket: SLS-2499, RFC

Motivation

This solution is essentially adding an extra inferred span that connects the current two traces, i.e. the authorizer function trace and the main function trace, into one trace.
apigateway authorizer

Implementation

  • When in the authorizer function, inject the necessary trace information and the timestamp information into the returned response
  • When in the main function, extract the information injected during authorizer function execution and create an inferred span based on it.
  • More Details and test evidence: google doc link

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@joeyzhao2018 joeyzhao2018 requested a review from a team as a code owner October 26, 2022 17:19
@joeyzhao2018 joeyzhao2018 changed the title Joey/authorizer trace context authorizer trace context Oct 26, 2022
Copy link
Contributor

@astuyve astuyve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small notes, otherwise great work here Joey!

datadog_lambda/constants.py Show resolved Hide resolved
datadog_lambda/tracing.py Outdated Show resolved Hide resolved
datadog_lambda/tracing.py Show resolved Hide resolved
datadog_lambda/tracing.py Outdated Show resolved Hide resolved
datadog_lambda/tracing.py Show resolved Hide resolved
datadog_lambda/tracing.py Outdated Show resolved Hide resolved
datadog_lambda/tracing.py Show resolved Hide resolved
datadog_lambda/wrapper.py Outdated Show resolved Hide resolved
datadog_lambda/tracing.py Show resolved Hide resolved
Copy link
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good, nice job. Thanks for refactoring! 🚀

@joeyzhao2018 joeyzhao2018 merged commit 0a070a6 into main Nov 15, 2022
@joeyzhao2018 joeyzhao2018 deleted the joey/authorizer-trace-context branch November 15, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authorizer traces not correlated with API gateway traces
3 participants