-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authorizer traces not correlated with API gateway traces #252
Authorizer traces not correlated with API gateway traces #252
Comments
A 'request' typed authorizer has access to the request headers while a token authorizer doesn't have the header data, so you might get something workable with the other authenticator type. Even there, I'd expect that the layer may not automatically extract the trace context |
Hi @arturenault - this is true. Right now, we do not propagate trace context through authorizer functions. I will forward this on to the Product team and leave it open as a feature request. Thanks! |
Just a quick update, @astuyve already have a RFC, will likely make some progress later this quarter. But it's non-trivial, so it will take some time. |
Thank you - for others hitting this, I was able to get correlated traces by switching to Request authorizers. But would be nice to get it in all kinds of authorizers. |
Will this work for TOKEN and REQUEST typed authorizers? |
Yes! |
@joeyzhao2018 Can you please also done this improvement for Go Lang?? |
Expected Behavior
If a lambda is gated behind an AWS API Gateway Authorizer, I'd expect the call to the authorizer to be part of the same trace as the overall API Gateway call and lambda execution.
Actual Behavior
The overarching trace that captures the full request trace goes through to the main lambda, but not to the authorizer lambda. That one has a separate trace.
Steps to Reproduce the Problem
Specifications
Let me know if this isn't the right place for this issue - I'm using the plugin so I figured I'd start here.
The text was updated successfully, but these errors were encountered: