Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitors: Pass on Stack tags #229

Merged
merged 3 commits into from
Dec 8, 2022
Merged

Monitors: Pass on Stack tags #229

merged 3 commits into from
Dec 8, 2022

Conversation

skarimo
Copy link
Member

@skarimo skarimo commented Nov 28, 2022

This is a follow up to #226 to be able to run CI tests.

This PR includes a fix in regards to ignoring tag ordering and ensuring no drift is present on applies.

elruwen and others added 2 commits November 21, 2022 13:57
Cloudformation supports tags at a stack level. They are normally passed on to all Cloudformation resources (some resources don't support that yet...). Datadog monitors got tags, too. With this change, the Cloudformation Stack tags are copied to the Datadog monitor. Additionally, the AWS autogenerated tags like stack name and logical id are also set. If a tag is already set explicitly at a monitor, the monitor value is being used.
Since Datadog uses a : to separate key and value, all : are replaced with _.

In order to maintain backwards compatibility, this feature is switched off by default. It can be enabled account-wide via the type configuration, the same way Datadog credentials are being set.
@skarimo skarimo added resource/monitor Impacts the datadog-monitors-monitor-handler package changelog/Added Added features results into a minor version bump labels Nov 28, 2022
@skarimo skarimo requested a review from a team as a code owner November 28, 2022 19:34
therve
therve previously approved these changes Dec 6, 2022
@skarimo skarimo merged commit 4cda276 into master Dec 8, 2022
@skarimo skarimo deleted the sherz/stack-tags branch December 8, 2022 14:59
skarimo added a commit that referenced this pull request Dec 8, 2022
@skarimo skarimo added changelog/no-changelog Changes don't appear in changelog and removed changelog/Added Added features results into a minor version bump labels Dec 8, 2022
skarimo added a commit that referenced this pull request Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog Changes don't appear in changelog resource/monitor Impacts the datadog-monitors-monitor-handler package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants