Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitors: Pass on Stack tags #226

Open
elruwen opened this issue Nov 9, 2022 · 1 comment
Open

Monitors: Pass on Stack tags #226

elruwen opened this issue Nov 9, 2022 · 1 comment
Labels
kind/feature-request Feature request related issue stale Stale - Bot reminder

Comments

@elruwen
Copy link
Contributor

elruwen commented Nov 9, 2022

Is your feature request related to a problem? Please describe.
I got already on stack level lots of tags. Adding them manually to a monitor is just duplication.

Describe the solution you'd like
Stack tags are passed on to the monitor.

Describe alternatives you've considered
none

Additional context
I will try to implement it.

The only interesting question is: shall we disable this feature by default for backwards compatibility?
@elruwen elruwen added the kind/feature-request Feature request related issue label Nov 9, 2022
elruwen added a commit to elruwen/datadog-cloudformation-resources that referenced this issue Nov 9, 2022
@elruwen
Copying Stack tags to the Datadog monitor (DataDog#226)
0c8ed55 
Cloudformation supports tags at a stack level. They are normally passed on to all Cloudformation resources (some resources don't support that yet...). Datadog monitors got tags, too. With this change, the Cloudformation Stack tags are copied to the Datadog monitor. Additionally, the AWS autogenerated tags like stack name and logical id are also set. If a tag is already set explicitly at a monitor, the monitor value is being used.
Since Datadog uses a : to separate key and value, all : are replaced with _.

In order to maintain backwards compatibility, this feature is switched off by default. It can be enabled account-wide via the type configuration, the same way Datadog credentials are being set.
@elruwen elruwen mentioned this issue Nov 9, 2022
Closed
6 tasks
skarimo pushed a commit that referenced this issue Nov 22, 2022
@elruwen @skarimo
Copying Stack tags to the Datadog monitor (#226)
66b6d18 
Cloudformation supports tags at a stack level. They are normally passed on to all Cloudformation resources (some resources don't support that yet...). Datadog monitors got tags, too. With this change, the Cloudformation Stack tags are copied to the Datadog monitor. Additionally, the AWS autogenerated tags like stack name and logical id are also set. If a tag is already set explicitly at a monitor, the monitor value is being used.
Since Datadog uses a : to separate key and value, all : are replaced with _.

In order to maintain backwards compatibility, this feature is switched off by default. It can be enabled account-wide via the type configuration, the same way Datadog credentials are being set.
@skarimo skarimo mentioned this issue Nov 28, 2022
Merged
skarimo added a commit that referenced this issue Dec 8, 2022
@skarimo @elruwen
Monitors: Pass on Stack tags (#229)
4cda276 
* Copying Stack tags to the Datadog monitor (#226)

* refactor and ignore tag ordering

* fix tag key correction

Co-authored-by: Ruwen <[email protected]>
@github-actions
Copy link

Thanks for your contribution!

This issue has been automatically marked as stale because it has not had activity in the last 30 days. Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity. Thank you for participating in the Datadog open source community.

If you would like this issue to remain open:

  1. Verify that you can still reproduce the issue in the latest version of this project.

  2. Comment that the issue is still reproducible and include updated details requested in the issue template.

@github-actions github-actions bot added the stale Stale - Bot reminder label Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature-request Feature request related issue stale Stale - Bot reminder
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Copying Stack tags to the Datadog monitor (#226) elruwen/datadog-cloudformation-resources
1 participant
@elruwen