-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 7.61.x] [NDM] Do not always log error on SNMP Autodiscovery unmarshal failure #32436
base: 7.61.x
Are you sure you want to change the base?
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=51671751 --os-family=ubuntu Note: This applies to commit 87a03f6 |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 9017a87 Optimization Goals: ❌ Regression(s) detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
❌ | basic_py_check | % cpu utilization | +5.11 | [+1.19, +9.03] | 1 | Logs |
➖ | pycheck_lots_of_tags | % cpu utilization | +1.99 | [-1.50, +5.48] | 1 | Logs |
➖ | file_tree | memory utilization | +0.42 | [+0.27, +0.57] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | +0.24 | [-0.43, +0.91] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | +0.12 | [+0.07, +0.16] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_0ms_latency | egress throughput | +0.12 | [-0.73, +0.97] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.02 | [-0.06, +0.09] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | +0.01 | [-0.62, +0.63] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.02 | [-0.08, +0.03] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.03 | [-0.49, +0.43] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | -0.04 | [-0.80, +0.73] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.11 | [-0.90, +0.69] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | -0.22 | [-0.99, +0.55] | 1 | Logs |
➖ | quality_gate_logs | % cpu utilization | -0.25 | [-3.20, +2.69] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | -2.07 | [-2.19, -1.94] | 1 | Logs bounds checks dashboard |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -2.88 | [-3.60, -2.17] | 1 | Logs |
Bounds Checks: ✅ Passed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | lost_bytes | 10/10 | |
✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
Backport 8b85951 from #32429.
<!--
-->
What does this PR do?
#30180 introduced a new error log on SNMP Autodiscovery config unmarshal error. We don't want to log the error when the config is not set.
Motivation
Describe how you validated your changes
<!--
Validate your changes before merge, ensuring that:
If you want additional validation by a second person, you can ask reviewers to do it. Describe how to set up an environment for manual tests in the PR description. Manual validation is expected to happen on every commit before merge.
Any manual validation step should then map to an automated test. Manual validation should not substitute automation, minus exceptions not supported by test tooling yet.
-->
Possible Drawbacks / Trade-offs
Additional Notes
<!--
version was chosen.
-->