[NDM] Do not always log error on SNMP Autodiscovery unmarshal failure

[TCheruy]

What does this PR do?

#30180 introduced a new error log on SNMP Autodiscovery config unmarshal error. We don't want to log the error when the config is not set.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

[TCheruy]

/merge

[dd-devflow]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2024-12-20 16:40:49 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

---

2024-12-20 17:26:31 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 34m.

---

2024-12-20 18:03:36 UTC ℹ️ MergeQueue: This merge request was merged

[agent-platform-auto-pr]

Uncompressed package size comparison

Comparison with ancestor 1c318b7c0025332108f8d45192ffd6069b5331b5

Diff per package

package	diff	status	size	ancestor	threshold
datadog-heroku-agent-amd64-deb	0.00MB	✅	504.88MB	504.87MB	70.00MB
datadog-iot-agent-amd64-deb	0.00MB	✅	113.33MB	113.33MB	10.00MB
datadog-iot-agent-arm64-deb	0.00MB	✅	108.80MB	108.80MB	10.00MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	108.87MB	108.87MB	10.00MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	113.40MB	113.40MB	10.00MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	113.40MB	113.40MB	10.00MB
datadog-agent-x86_64-rpm	0.00MB	✅	1197.22MB	1197.22MB	140.00MB
datadog-agent-x86_64-suse	0.00MB	✅	1197.22MB	1197.22MB	140.00MB
datadog-agent-aarch64-rpm	0.00MB	✅	943.19MB	943.19MB	140.00MB
datadog-agent-amd64-deb	0.00MB	✅	1187.96MB	1187.96MB	140.00MB
datadog-agent-arm64-deb	0.00MB	✅	933.95MB	933.95MB	140.00MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	78.57MB	78.57MB	10.00MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	78.64MB	78.64MB	10.00MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	78.64MB	78.64MB	10.00MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	55.77MB	55.77MB	10.00MB

Decision

✅ Passed

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51665850 --os-family=ubuntu

Note: This applies to commit 38ae683

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ceec771b-e435-4b07-b97d-0a1c803896d9

Baseline: 1c318b7
Comparison: 38ae683
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+1.13	[-2.09, +4.36]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.31	[+0.24, +0.37]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.20	[+0.11, +0.29]	1	Logs bounds checks dashboard
➖	file_to_blackhole_500ms_latency	egress throughput	+0.16	[-0.61, +0.93]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.05	[-0.59, +0.70]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.04	[-0.76, +0.83]	1	Logs
➖	file_tree	memory utilization	+0.03	[-0.11, +0.16]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.02	[-0.91, +0.95]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.03, +0.04]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.00	[-0.91, +0.90]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.12, +0.11]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.01	[-0.90, +0.88]	1	Logs
➖	otel_to_otel_logs	ingress throughput	-0.07	[-0.74, +0.59]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.18	[-0.65, +0.29]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.29	[-1.11, +0.52]	1	Logs
➖	quality_gate_idle	memory utilization	-0.44	[-0.48, -0.40]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.82	[-1.49, -0.15]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.