Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Mark ConfigHostname/external as flaky #32392

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[APM] Mark ConfigHostname/external as flaky #32392

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5253be
[APM] Mark ConfigHostname/external as flaky
ichinaski Dec 19, 2024
f98ff00
rm draft test file
ichinaski Dec 19, 2024
2d87557
Merge branch 'main' into ichinaski/flaky-test-config-external
ichinaski Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion comp/trace/config/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,7 @@ func TestConfigHostname(t *testing.T) {
})

t.Run("external", func(t *testing.T) {
t.Skip("Skip flaky test while we explore fixes.")
// makeProgram creates a new binary file which returns the given response and exits to the OS
// given the specified code, returning the path of the program.
makeProgram := func(t *testing.T, response string, code int) string {
Expand Down Expand Up @@ -398,7 +399,6 @@ func TestConfigHostname(t *testing.T) {
fallbackHostnameFunc = func() (string, error) { return "fallback.host", nil }

t.Run("good", func(t *testing.T) {
t.Skip("Skip flaky test while we explore fixes.")
bin := makeProgram(t, "host.name", 0)
defer os.Remove(bin)

Expand Down
Loading