Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Mark ConfigHostname/external as flaky #32392

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ichinaski
Copy link
Contributor

What does this PR do?

Mark TestConfigHostname/external (and therefore all subtests) as flaky, while we investigate this issue affecting MacOS tests.

Motivation

TestConfigHostname still has some flaky subtests, caused by timeouts on the hostname acquisition.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@ichinaski ichinaski added changelog/no-changelog team/agent-apm trace-agent qa/done QA done before merge and regressions are covered by tests labels Dec 19, 2024
@ichinaski ichinaski requested a review from a team as a code owner December 19, 2024 13:03
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 19, 2024
@ichinaski
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 19, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-19 13:32:55 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-12-19 17:32:59 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request: It did not become mergeable within the expected time

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 19, 2024

Uncompressed package size comparison

Comparison with ancestor 1aa7a6f7439162fc1d7a28edb1bfed8d6800156c

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 1187.89MB 1187.89MB 140.00MB
datadog-agent-x86_64-rpm 0.00MB 1197.15MB 1197.15MB 140.00MB
datadog-agent-x86_64-suse 0.00MB 1197.15MB 1197.15MB 140.00MB
datadog-agent-arm64-deb 0.00MB 933.87MB 933.87MB 140.00MB
datadog-agent-aarch64-rpm 0.00MB 943.11MB 943.11MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.57MB 78.57MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.64MB 78.64MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.64MB 78.64MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.77MB 55.77MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 504.86MB 504.86MB 70.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.32MB 113.32MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.39MB 113.39MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.39MB 113.39MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.79MB 108.79MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.86MB 108.86MB 10.00MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 19, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51596931 --os-family=ubuntu

Note: This applies to commit 2d87557

Copy link

cit-pr-commenter bot commented Dec 19, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 9a03729c-abc3-41c8-9683-978e32dfb3f8

Baseline: 1aa7a6f
Comparison: 2d87557
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +2.15 [-1.13, +5.44] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +2.11 [+1.41, +2.81] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.28 [-0.48, +1.05] 1 Logs
file_tree memory utilization +0.03 [-0.10, +0.17] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.86, +0.90] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.01 [-0.87, +0.89] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.66, +0.68] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.12, +0.11] 1 Logs
quality_gate_idle memory utilization -0.02 [-0.06, +0.02] 1 Logs bounds checks dashboard
file_to_blackhole_300ms_latency egress throughput -0.14 [-0.79, +0.50] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.18 [-1.04, +0.69] 1 Logs
quality_gate_idle_all_features memory utilization -0.18 [-0.26, -0.10] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.24 [-0.70, +0.22] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.50 [-1.29, +0.29] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.67 [-0.74, -0.60] 1 Logs
otel_to_otel_logs ingress throughput -0.85 [-1.57, -0.14] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-apm trace-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants