upgrade(installer): Return specific error codes #31619
Conversation
BaptisteFoy
added
changelog/no-changelog
qa/done
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=50180958 --os-family=ubuntuNote: This applies to commit 4d45e4b |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 98b799c Optimization Goals: ❌ Significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ❌ | pycheck_lots_of_tags | % cpu utilization | +6.50 | [+2.70, +10.31] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.88 | [+0.21, +1.56] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.52 | [+0.40, +0.64] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.38 | [-0.37, +1.12] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.36 | [-0.42, +1.13] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.33 | [+0.28, +0.39] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.03 | [-0.75, +0.80] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.01 | [-0.69, +0.71] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.01 | [-0.86, +0.85] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.11, +0.08] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | -0.02 | [-0.64, +0.61] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.09 | [-0.24, +0.05] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.14 | [-3.11, +2.83] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.15 | [-0.61, +0.32] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -1.14 | [-1.18, -1.09] | 1 | Logs bounds checks dashboard |
| ➖ | basic_py_check | % cpu utilization | -1.90 | [-5.71, +1.91] | 1 | Logs |
Bounds Checks: ❌ Failed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ❌ | file_to_blackhole_100ms_latency | lost_bytes | 6/10 | |
| ❌ | file_to_blackhole_0ms_latency | lost_bytes | 8/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
|
/merge |
Devflow running:
|
|
/merge |
Devflow running:
|
|
/merge |
Devflow running:
|
upgrade(installer): Return specific error codes (#31619) Co-authored-by: arbll <[email protected]> (fleet) env cleanup (#31628) create benchmark for consumer operations fixed test changed test to be user mode only revert newEventGenerator changes as it not needed for the benchmark changed return value changed events counts to support correct loads improve some ut structure
What does this PR do?
Motivation
Describe how to test/QA your changes
QA-ed manually on a VM
Possible Drawbacks / Trade-offs
Additional Notes