Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade(installer): Report and store policies metadata #31474

Merged
merged 11 commits into from
Nov 29, 2024

Conversation

BaptisteFoy
Copy link
Contributor

What does this PR do?

Reports policies applied and add boilerplate to add more metadata.
The policies metadata is reported through Remote Config Updater state. To permanently have it for stable / experiment versions it is stored in a file next to configuration. It is encoded in protobuf to lower footprint on customer host. The file can only be read (not written) by dd-agent & root. It is written by root only.

Motivation

Describe how to test/QA your changes

QA-ed manually, E2E test

Possible Drawbacks / Trade-offs

Additional Notes

@BaptisteFoy BaptisteFoy added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/fleet-automation labels Nov 26, 2024
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Nov 26, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 26, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=50098303 --os-family=ubuntu

Note: This applies to commit 7f5d1ac

Copy link

cit-pr-commenter bot commented Nov 26, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 515522e5-aede-4082-994d-7e310ad38631

Baseline: 79b975d
Comparison: 7f5d1ac
Diff

Optimization Goals: ❌ Significant changes detected

perf experiment goal Δ mean % Δ mean % CI trials links
pycheck_lots_of_tags % cpu utilization +6.93 [+3.36, +10.51] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
pycheck_lots_of_tags % cpu utilization +6.93 [+3.36, +10.51] 1 Logs
quality_gate_idle_all_features memory utilization +2.08 [+1.95, +2.20] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput +0.37 [-0.40, +1.14] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.24 [+0.18, +0.31] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.15 [-0.61, +0.91] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.02 [-0.45, +0.48] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.00 [-0.67, +0.67] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.11, +0.11] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.79, +0.78] 1 Logs
otel_to_otel_logs ingress throughput -0.03 [-0.72, +0.66] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.06 [-0.69, +0.57] 1 Logs
file_tree memory utilization -0.17 [-0.32, -0.03] 1 Logs
quality_gate_idle memory utilization -0.34 [-0.38, -0.29] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization -0.88 [-1.60, -0.15] 1 Logs
quality_gate_logs % cpu utilization -0.99 [-3.95, +1.96] 1 Logs
basic_py_check % cpu utilization -4.08 [-7.84, -0.31] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@BaptisteFoy BaptisteFoy marked this pull request as ready for review November 26, 2024 14:20
@BaptisteFoy BaptisteFoy requested review from a team as code owners November 26, 2024 14:20
Copy link
Member

@arbll arbll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📦

@BaptisteFoy BaptisteFoy force-pushed the baptiste.foy/FA/policies-metadata branch from f4c9dcb to 7f5d1ac Compare November 28, 2024 09:59
@BaptisteFoy
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 29, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-29 09:20:57 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-11-29 09:21:56 UTC ⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

@BaptisteFoy
Copy link
Contributor Author

/remove

@dd-devflow
Copy link

dd-devflow bot commented Nov 29, 2024

Devflow running: /remove

View all feedbacks in Devflow UI.


2024-11-29 09:21:55 UTC ℹ️ Devflow: /remove

@BaptisteFoy
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 29, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-29 16:09:16 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 23m.

@dd-mergequeue dd-mergequeue bot merged commit daad6bc into main Nov 29, 2024
370 checks passed
@dd-mergequeue dd-mergequeue bot deleted the baptiste.foy/FA/policies-metadata branch November 29, 2024 16:53
@github-actions github-actions bot added this to the 7.62.0 milestone Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/fleet-automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants