Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployOperator option to the AWS kind E2E environment #31136

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 15 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitlab/common/test_infra_version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ variables:
# and check the job creating the image to make sure you have the right SHA prefix
TEST_INFRA_DEFINITIONS_BUILDIMAGES_SUFFIX: ""
# Make sure to update test-infra-definitions version in go.mod as well
TEST_INFRA_DEFINITIONS_BUILDIMAGES: 4b4112f5f64d
TEST_INFRA_DEFINITIONS_BUILDIMAGES: 10486aec63a8
fanny-jiang marked this conversation as resolved.
Show resolved Hide resolved
137 changes: 137 additions & 0 deletions test/new-e2e/examples/kind_local_operator_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,137 @@
// Unless explicitly stated otherwise all files in this repository are licensed
// under the Apache License Version 2.0.
// This product includes software developed at Datadog (https://www.datadoghq.com/).
// Copyright 2016-present Datadog, Inc.

package examples

import (
"context"
"github.com/DataDog/test-infra-definitions/components/datadog/agent"
"github.com/DataDog/test-infra-definitions/components/datadog/agentwithoperatorparams"
fakeintakeComp "github.com/DataDog/test-infra-definitions/components/datadog/fakeintake"
"github.com/DataDog/test-infra-definitions/components/datadog/operator"
"github.com/DataDog/test-infra-definitions/components/datadog/operatorparams"
compkube "github.com/DataDog/test-infra-definitions/components/kubernetes"
"github.com/DataDog/test-infra-definitions/resources/local"
"github.com/pulumi/pulumi-kubernetes/sdk/v4/go/kubernetes"
"github.com/pulumi/pulumi/sdk/v3/go/pulumi"
"strings"
"testing"

"github.com/stretchr/testify/assert"
v1 "k8s.io/apimachinery/pkg/apis/meta/v1"

"github.com/DataDog/datadog-agent/test/new-e2e/pkg/e2e"
"github.com/DataDog/datadog-agent/test/new-e2e/pkg/environments"
)

const namespace = "datadog"

type localKindOperatorSuite struct {
e2e.BaseSuite[environments.Kubernetes]
}

func localKindOperatorProvisioner() e2e.PulumiEnvRunFunc[environments.Kubernetes] {
return func(ctx *pulumi.Context, env *environments.Kubernetes) error {
kindEnv, err := local.NewEnvironment(ctx)
if err != nil {
return err
}

kindCluster, err := compkube.NewLocalKindCluster(&kindEnv, kindEnv.CommonNamer().ResourceName("kind-operator"), kindEnv.KubernetesVersion())
if err != nil {
return err
}

if err := kindCluster.Export(ctx, &env.KubernetesCluster.ClusterOutput); err != nil {
return err
}

// Build Kubernetes provider
kindKubeProvider, err := kubernetes.NewProvider(ctx, kindEnv.CommonNamer().ResourceName("k8s-provider"), &kubernetes.ProviderArgs{
Kubeconfig: kindCluster.KubeConfig,
EnableServerSideApply: pulumi.BoolPtr(true),
})
if err != nil {
return err
}

kindCluster.KubeProvider = kindKubeProvider

fakeIntake, err := fakeintakeComp.NewLocalDockerFakeintake(&kindEnv, "fakeintake")
if err != nil {
return err
}
if err := fakeIntake.Export(ctx, &env.FakeIntake.FakeintakeOutput); err != nil {
return err
}

// Setup default operator options
operatorOpts := make([]operatorparams.Option, 0)
operatorOpts = append(
operatorOpts,
operatorparams.WithNamespace(namespace),
)

// Create Operator component
_, err = operator.NewOperator(&kindEnv, kindEnv.CommonNamer().ResourceName("dd-operator"), kindCluster.KubeProvider, operatorOpts...)

if err != nil {
return err
}

customDDA := agentwithoperatorparams.DDAConfig{
Name: "ccr-enabled",
YamlConfig: `
apiVersion: datadoghq.com/v2alpha1
kind: DatadogAgent
spec:
global:
kubelet:
tlsVerify: false
features:
clusterChecks:
useClusterChecksRunners: true
`,
}

// Setup DDA options
ddaOptions := make([]agentwithoperatorparams.Option, 0)
ddaOptions = append(
ddaOptions,
agentwithoperatorparams.WithDDAConfig(customDDA),
agentwithoperatorparams.WithNamespace(namespace),
agentwithoperatorparams.WithFakeIntake(fakeIntake),
)

// Create Datadog Agent with Operator component
agentComponent, err := agent.NewDDAWithOperator(&kindEnv, ctx.Stack(), kindCluster.KubeProvider, ddaOptions...)

if err != nil {
return err
}
err = agentComponent.Export(ctx, &env.Agent.KubernetesAgentOutput)
if err != nil {
return err
}

return nil
}
}

func TestOperatorKindSuite(t *testing.T) {
e2e.Run(t, &localKindOperatorSuite{}, e2e.WithPulumiProvisioner(localKindOperatorProvisioner(), nil))
}

func (k *localKindOperatorSuite) TestClusterChecksRunner() {
res, _ := k.Env().KubernetesCluster.Client().CoreV1().Pods(namespace).List(context.TODO(), v1.ListOptions{})
containsCCR := false
for _, pod := range res.Items {
if strings.Contains(pod.Name, "cluster-checks-runner") {
containsCCR = true
break
}
}
assert.True(k.T(), containsCCR, "Cluster checks runner not found")
}
60 changes: 60 additions & 0 deletions test/new-e2e/examples/kind_operator_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
// Unless explicitly stated otherwise all files in this repository are licensed
// under the Apache License Version 2.0.
// This product includes software developed at Datadog (https://www.datadoghq.com/).
// Copyright 2016-present Datadog, Inc.

package examples

import (
"context"
"github.com/DataDog/datadog-agent/test/new-e2e/pkg/e2e"
"github.com/DataDog/datadog-agent/test/new-e2e/pkg/environments"
awskubernetes "github.com/DataDog/datadog-agent/test/new-e2e/pkg/environments/aws/kubernetes"
"github.com/DataDog/test-infra-definitions/components/datadog/agentwithoperatorparams"
"github.com/stretchr/testify/assert"
v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"strings"
"testing"
)

type kindOperatorSuite struct {
e2e.BaseSuite[environments.Kubernetes]
}

func TestKindOperatorSuite(t *testing.T) {
customDDA := agentwithoperatorparams.DDAConfig{
Name: "ccr-enabled",
YamlConfig: `
apiVersion: datadoghq.com/v2alpha1
kind: DatadogAgent
spec:
global:
kubelet:
tlsVerify: false
features:
clusterChecks:
useClusterChecksRunners: true
`,
}

e2e.Run(t, &kindOperatorSuite{}, e2e.WithProvisioner(awskubernetes.KindProvisioner(
awskubernetes.WithOperator(),
awskubernetes.WithOperatorDDAOptions([]agentwithoperatorparams.Option{
agentwithoperatorparams.WithDDAConfig(customDDA),
}...),
)))
}

func (k *kindOperatorSuite) TestClusterChecksRunner() {
{
res, _ := k.Env().KubernetesCluster.Client().CoreV1().Pods("datadog").List(context.TODO(), v1.ListOptions{})
containsCCR := false
for _, pod := range res.Items {
if strings.Contains(pod.Name, "cluster-checks-runner") {
containsCCR = true
break
}
}
assert.True(k.T(), containsCCR, "Cluster checks runner not found")
}
}
4 changes: 2 additions & 2 deletions test/new-e2e/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ require (
// `TEST_INFRA_DEFINITIONS_BUILDIMAGES` matches the commit sha in the module version
// Example: github.com/DataDog/test-infra-definitions v0.0.0-YYYYMMDDHHmmSS-0123456789AB
// => TEST_INFRA_DEFINITIONS_BUILDIMAGES: 0123456789AB
github.com/DataDog/test-infra-definitions v0.0.0-20241217110507-4b4112f5f64d
github.com/DataDog/test-infra-definitions v0.0.0-20241217152533-10486aec63a8
github.com/aws/aws-sdk-go-v2 v1.32.6
github.com/aws/aws-sdk-go-v2/config v1.28.6
github.com/aws/aws-sdk-go-v2/service/ec2 v1.190.0
Expand Down Expand Up @@ -122,6 +122,7 @@ require (
github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.4.6 // indirect
github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.12.6 // indirect
github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.18.6 // indirect
github.com/aws/aws-sdk-go-v2/service/s3 v1.71.0
github.com/aws/aws-sdk-go-v2/service/sso v1.24.7 // indirect
github.com/aws/aws-sdk-go-v2/service/ssooidc v1.28.6 // indirect
github.com/aws/aws-sdk-go-v2/service/sts v1.33.2 // indirect
Expand Down Expand Up @@ -284,7 +285,6 @@ require (
github.com/DataDog/datadog-agent/pkg/trace v0.56.0-rc.3
github.com/DataDog/datadog-go/v5 v5.6.0
github.com/aws/aws-sdk-go v1.55.5
github.com/aws/aws-sdk-go-v2/service/s3 v1.71.0
github.com/aws/session-manager-plugin v0.0.0-20241119210807-82dc72922492
github.com/digitalocean/go-libvirt v0.0.0-20240812180835-9c6c0a310c6c
github.com/hairyhenderson/go-codeowners v0.7.0
Expand Down
4 changes: 2 additions & 2 deletions test/new-e2e/go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions test/new-e2e/pkg/components/operator.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// Unless explicitly stated otherwise all files in this repository are licensed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 suggestion
Looks like this component is never used, and has no client associated. You can skip it if it's not meant to receive an export from a pulumi output

Copy link
Contributor Author

@fanny-jiang fanny-jiang Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was planning on using it in the datadog-operator repo's E2E tests to export an operator output as a KubernetesObjRefOutput

// under the Apache License Version 2.0.
// This product includes software developed at Datadog (https://www.datadoghq.com/).
// Copyright 2016-present Datadog, Inc.

package components

import (
"github.com/DataDog/test-infra-definitions/components/datadog/operator"
)

// Operator is a Datadog Operator running in a Kubernetes cluster
type Operator struct { // nolint:revive, We want to keep the name as <Component>
fanny-jiang marked this conversation as resolved.
Show resolved Hide resolved
operator.OperatorOutput
}
50 changes: 46 additions & 4 deletions test/new-e2e/pkg/environments/aws/kubernetes/kind.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,11 @@ package awskubernetes
import (
"context"
"fmt"

"github.com/DataDog/test-infra-definitions/common/utils"
"github.com/DataDog/test-infra-definitions/components/datadog/agent"
"github.com/DataDog/test-infra-definitions/components/datadog/agentwithoperatorparams"
"github.com/DataDog/test-infra-definitions/components/datadog/operator"
"github.com/DataDog/test-infra-definitions/components/datadog/operatorparams"

"github.com/DataDog/datadog-agent/test/new-e2e/pkg/e2e"
"github.com/DataDog/datadog-agent/test/new-e2e/pkg/environments"
Expand Down Expand Up @@ -123,12 +126,16 @@ func KindRunFunc(ctx *pulumi.Context, env *environments.Kubernetes, params *Prov
newOpts := []kubernetesagentparams.Option{kubernetesagentparams.WithFakeintake(fakeIntake)}
params.agentOptions = append(newOpts, params.agentOptions...)
}
if params.operatorDDAOptions != nil {
newDdaOpts := []agentwithoperatorparams.Option{agentwithoperatorparams.WithFakeIntake(fakeIntake)}
params.operatorDDAOptions = append(newDdaOpts, params.operatorDDAOptions...)
}
} else {
env.FakeIntake = nil
}

var dependsOnCrd []pulumi.Resource
if params.agentOptions != nil {
if params.agentOptions != nil && !params.deployOperator {
kindClusterName := ctx.Stack()
helmValues := fmt.Sprintf(`
datadog:
Expand All @@ -150,8 +157,23 @@ agents:
return err
}
dependsOnCrd = append(dependsOnCrd, agent)
} else {
env.Agent = nil
}

if params.deployOperator {
operatorOpts := make([]operatorparams.Option, 0)
operatorOpts = append(
operatorOpts,
params.operatorOptions...,
)

operatorComp, err := operator.NewOperator(&awsEnv, awsEnv.Namer.ResourceName("dd-operator"), kubeProvider, operatorOpts...)
if err != nil {
return err
}
err = operatorComp.Export(ctx, nil)
if err != nil {
return err
}
}

if params.deployDogstatsd {
Expand Down Expand Up @@ -208,5 +230,25 @@ agents:
}
}

if params.deployOperator && params.operatorDDAOptions != nil {
ddaOptions := make([]agentwithoperatorparams.Option, 0)
ddaOptions = append(
ddaOptions,
params.operatorDDAOptions...,
)

ddaWithOperatorComp, err := agent.NewDDAWithOperator(&awsEnv, awsEnv.CommonNamer().ResourceName("kind-with-operator"), kubeProvider, ddaOptions...)
if err != nil {
return err
}

if err := ddaWithOperatorComp.Export(ctx, &env.Agent.KubernetesAgentOutput); err != nil {
return err
}

} else {
env.Agent = nil
}

return nil
}
Loading
Loading