Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployOperator option to the AWS kind E2E environment #31136

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

fanny-jiang
Copy link
Contributor

@fanny-jiang fanny-jiang commented Nov 15, 2024

What does this PR do?

  • Add deployOperator option to the AWS kind provisioner
  • Add 2 examples of e2e tests for deploying the agent using the operator for local kind and AWS kind

Motivation

  • Enable E2E testing for operator-managed agents

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly team/agent-devx-loops labels Nov 15, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 15, 2024

[Fast Unit Tests Report]

On pipeline 51520466 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

cit-pr-commenter bot commented Nov 15, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 14e217fc-31bd-44d0-9a7e-fb7dda7c5aa5

Baseline: 52f0517
Comparison: bcad91f
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +0.73 [+0.01, +1.45] 1 Logs
quality_gate_idle memory utilization +0.39 [+0.35, +0.43] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.29 [+0.23, +0.34] 1 Logs
file_tree memory utilization +0.24 [+0.11, +0.38] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.14 [-0.64, +0.91] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.13 [-0.33, +0.59] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.07 [-0.85, +0.99] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.67, +0.68] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.00 [-0.62, +0.63] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.00 [-0.86, +0.85] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.01 [-0.94, +0.91] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.03 [-0.14, +0.07] 1 Logs
otel_to_otel_logs ingress throughput -0.12 [-0.83, +0.58] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.24 [-1.01, +0.53] 1 Logs
quality_gate_idle_all_features memory utilization -0.46 [-0.58, -0.34] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.46 [-3.40, +2.47] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Nov 18, 2024
@fanny-jiang fanny-jiang added the qa/no-code-change No code change in Agent code requiring validation label Dec 17, 2024
@fanny-jiang fanny-jiang force-pushed the fanny/new-dda-woperator-example branch from e94fa16 to e6c3f90 Compare December 17, 2024 20:16
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 17, 2024

Uncompressed package size comparison

Comparison with ancestor 8ccce414826464f35a5176194292f8ac43f740a0

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 1187.90MB 1187.90MB 140.00MB
datadog-agent-x86_64-rpm 0.00MB 1197.14MB 1197.14MB 140.00MB
datadog-agent-x86_64-suse 0.00MB 1197.14MB 1197.14MB 140.00MB
datadog-agent-arm64-deb 0.00MB 933.88MB 933.88MB 140.00MB
datadog-agent-aarch64-rpm 0.00MB 943.10MB 943.10MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.59MB 78.59MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.67MB 78.67MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.67MB 78.67MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.79MB 55.79MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 505.07MB 505.07MB 70.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.31MB 113.31MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.38MB 113.38MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.38MB 113.38MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.78MB 108.78MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.85MB 108.85MB 10.00MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 17, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51520466 --os-family=ubuntu

Note: This applies to commit 947d9e8

@fanny-jiang fanny-jiang changed the title Add new-e2e example test for NewDDAWithOperator Add deployOperator option to the AWS kind E2E environment Dec 17, 2024
@fanny-jiang fanny-jiang marked this pull request as ready for review December 17, 2024 23:48
@fanny-jiang fanny-jiang requested review from a team as code owners December 17, 2024 23:48
@fanny-jiang fanny-jiang requested a review from a team as a code owner December 17, 2024 23:48
.gitlab/common/test_infra_version.yml Outdated Show resolved Hide resolved
test/new-e2e/pkg/components/operator.go Outdated Show resolved Hide resolved
@@ -0,0 +1,15 @@
// Unless explicitly stated otherwise all files in this repository are licensed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 suggestion
Looks like this component is never used, and has no client associated. You can skip it if it's not meant to receive an export from a pulumi output

Copy link
Contributor Author

@fanny-jiang fanny-jiang Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was planning on using it in the datadog-operator repo's E2E tests to export an operator output as a KubernetesObjRefOutput

…or-example

# Conflicts:
#	.gitlab/common/test_infra_version.yml
#	test/new-e2e/go.mod
#	test/new-e2e/go.sum
@fanny-jiang fanny-jiang force-pushed the fanny/new-dda-woperator-example branch from b049e48 to bcad91f Compare December 18, 2024 15:41
@fanny-jiang fanny-jiang requested a review from pducolin December 18, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-devx-loops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants