-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CWS] add release note with fargate fixes for 7.58.1 #30165
[CWS] add release note with fargate fixes for 7.58.1 #30165
Conversation
[Fast Unit Tests Report] On pipeline 46737870 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Regression DetectorRegression Detector ResultsRun ID: 14f9554b-d4c6-492d-8ea0-99691439044b Metrics dashboard Target profiles Baseline: cf39839 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.91 | [+0.16, +1.66] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.38 | [+0.32, +0.44] | 1 | Logs |
➖ | idle | memory utilization | +0.26 | [+0.22, +0.31] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.00, +0.00] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | file_tree | memory utilization | -0.02 | [-0.14, +0.10] | 1 | Logs |
➖ | basic_py_check | % cpu utilization | -0.27 | [-3.04, +2.49] | 1 | Logs |
➖ | pycheck_lots_of_tags | % cpu utilization | -1.23 | [-3.73, +1.27] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | -1.36 | [-2.19, -0.53] | 1 | Logs |
Bounds Checks
perf | experiment | bounds_check_name | replicates_passed |
---|---|---|---|
❌ | idle | memory_usage | 6/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with a few minor updates requested for the release note
releasenotes/notes/cws-7.58.1-fargate-fix-82bfa36a8873f3a4.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Bryce Eadie <[email protected]>
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
This PR is just adding a release note matching the 2 CWS backports for 7.58.1:
forkExec
nosplit, so that it's not preemptible before the exec #30150Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes