Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] add release note with fargate fixes for 7.58.1 #30165

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

paulcacheux
Copy link
Contributor

What does this PR do?

This PR is just adding a release note matching the 2 CWS backports for 7.58.1:

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@paulcacheux paulcacheux added team/agent-security qa/no-code-change No code change in Agent code requiring validation labels Oct 16, 2024
@paulcacheux paulcacheux requested a review from a team as a code owner October 16, 2024 08:32
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Oct 16, 2024

[Fast Unit Tests Report]

On pipeline 46737870 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@pr-commenter
Copy link

pr-commenter bot commented Oct 16, 2024

Regression Detector

Regression Detector Results

Run ID: 14f9554b-d4c6-492d-8ea0-99691439044b Metrics dashboard Target profiles

Baseline: cf39839
Comparison: a8ca627

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +0.91 [+0.16, +1.66] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.38 [+0.32, +0.44] 1 Logs
idle memory utilization +0.26 [+0.22, +0.31] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_tree memory utilization -0.02 [-0.14, +0.10] 1 Logs
basic_py_check % cpu utilization -0.27 [-3.04, +2.49] 1 Logs
pycheck_lots_of_tags % cpu utilization -1.23 [-3.73, +1.27] 1 Logs
otel_to_otel_logs ingress throughput -1.36 [-2.19, -0.53] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 6/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a few minor updates requested for the release note

Co-authored-by: Bryce Eadie <[email protected]>
@paulcacheux
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 21, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in 7.58.x is 40m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 2927b76 into 7.58.x Oct 21, 2024
208 checks passed
@dd-mergequeue dd-mergequeue bot deleted the paulcacheux/7.58.1-cws-fargate-release-note branch October 21, 2024 12:32
@kacper-murzyn kacper-murzyn added this to the 7.58.1 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa/no-code-change No code change in Agent code requiring validation team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants