Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport][CWS] backport #29666 - fix task tags in fargate #30164

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

paulcacheux
Copy link
Contributor

(cherry picked from commit d4e9db1)

What does this PR do?

Backport of #29666 for 7.58

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

Copy link

Go Package Import Differences

Baseline: cf39839
Comparison: d715e03

binaryosarchchange
system-probelinuxamd64
+6, -0
+github.com/DataDog/datadog-agent/pkg/util/ecs/common
+github.com/DataDog/datadog-agent/pkg/util/ecs/metadata
+github.com/DataDog/datadog-agent/pkg/util/ecs/metadata/v1
+github.com/DataDog/datadog-agent/pkg/util/ecs/metadata/v2
+github.com/DataDog/datadog-agent/pkg/util/ecs/metadata/v3or4
+github.com/DataDog/datadog-agent/pkg/util/ecs/telemetry
system-probelinuxarm64
+6, -0
+github.com/DataDog/datadog-agent/pkg/util/ecs/common
+github.com/DataDog/datadog-agent/pkg/util/ecs/metadata
+github.com/DataDog/datadog-agent/pkg/util/ecs/metadata/v1
+github.com/DataDog/datadog-agent/pkg/util/ecs/metadata/v2
+github.com/DataDog/datadog-agent/pkg/util/ecs/metadata/v3or4
+github.com/DataDog/datadog-agent/pkg/util/ecs/telemetry
system-probewindowsamd64
+7, -0
+github.com/DataDog/datadog-agent/pkg/util/ecs/common
+github.com/DataDog/datadog-agent/pkg/util/ecs/metadata
+github.com/DataDog/datadog-agent/pkg/util/ecs/metadata/v1
+github.com/DataDog/datadog-agent/pkg/util/ecs/metadata/v2
+github.com/DataDog/datadog-agent/pkg/util/ecs/metadata/v3or4
+github.com/DataDog/datadog-agent/pkg/util/ecs/telemetry
+github.com/hashicorp/go-version

@pr-commenter
Copy link

pr-commenter bot commented Oct 16, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=46691541 --os-family=ubuntu

Note: This applies to commit d715e03

@pr-commenter
Copy link

pr-commenter bot commented Oct 16, 2024

Regression Detector

Regression Detector Results

Run ID: e4e7d267-5163-41ee-9dfb-588a5368a2bd Metrics dashboard Target profiles

Baseline: cf39839
Comparison: d715e03

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
otel_to_otel_logs ingress throughput +0.73 [-0.11, +1.56] 1 Logs
file_tree memory utilization +0.72 [+0.61, +0.83] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.51 [-0.23, +1.26] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] 1 Logs
idle memory utilization -0.22 [-0.26, -0.18] 1 Logs
basic_py_check % cpu utilization -0.66 [-3.46, +2.14] 1 Logs
pycheck_lots_of_tags % cpu utilization -1.48 [-4.12, +1.17] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.81 [-1.88, -1.75] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 7/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@paulcacheux
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 21, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in 7.58.x is 40m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 772b13f into 7.58.x Oct 21, 2024
251 checks passed
@dd-mergequeue dd-mergequeue bot deleted the paulcacheux/backport-29666-7.58 branch October 21, 2024 11:57
@kacper-murzyn kacper-murzyn added this to the 7.58.1 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants