Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore microsoft.net in system path tester #27989

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

clarkb7
Copy link
Contributor

@clarkb7 clarkb7 commented Jul 26, 2024

What does this PR do?

Add C:\Windows\Microsoft.NET to the list of paths that are ignored by the "does not remove system files" test.

Motivation

The following paths creating flakes

C:\Windows\Microsoft.NET\ngennicupdatelock.dat
C:\Windows\Microsoft.NET\Framework\v4.0.30319\ngenrootstorelock.dat
C:\Windows\Microsoft.NET\Framework\v4.0.30319\ngentasklock.dat
C:\Windows\Microsoft.NET\Framework64\v4.0.30319\ngenrootstorelock.dat
C:\Windows\Microsoft.NET\Framework64\v4.0.30319\ngentasklock.dat

flakes
https://datadoghq.atlassian.net/browse/WINA-794
https://datadoghq.atlassian.net/browse/WINA-923
https://datadoghq.atlassian.net/browse/WINA-924
https://datadoghq.atlassian.net/browse/WINA-925
https://datadoghq.atlassian.net/browse/WINA-929

todo card to come up with a better test
https://datadoghq.atlassian.net/browse/WINA-624

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

N/A, e2e test update

@clarkb7 clarkb7 added changelog/no-changelog team/windows-agent qa/no-code-change No code change in Agent code requiring validation labels Jul 26, 2024
@clarkb7 clarkb7 requested review from a team as code owners July 26, 2024 19:10
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 40263180 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@pr-commenter
Copy link

pr-commenter bot commented Jul 26, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=40263180 --os-family=ubuntu

Note: This applies to commit 68b3da8

@pr-commenter
Copy link

pr-commenter bot commented Jul 26, 2024

Regression Detector

Regression Detector Results

Run ID: f3a07e03-a890-4c13-bdb3-88dd90f056cd Metrics dashboard Target profiles

Baseline: ab2f289
Comparison: 68b3da8

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
uds_dogstatsd_to_api_cpu % cpu utilization +1.50 [+0.62, +2.38] Logs
idle memory utilization +0.27 [+0.23, +0.30] Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] Logs
otel_to_otel_logs ingress throughput -0.06 [-0.87, +0.75] Logs
file_tree memory utilization -0.21 [-0.27, -0.14] Logs
pycheck_1000_100byte_tags % cpu utilization -0.81 [-5.50, +3.87] Logs
basic_py_check % cpu utilization -0.90 [-3.46, +1.66] Logs
tcp_syslog_to_blackhole ingress throughput -1.15 [-14.08, +11.77] Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@clarkb7
Copy link
Contributor Author

clarkb7 commented Jul 26, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jul 26, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 1bdd5ac into main Jul 26, 2024
248 checks passed
@dd-mergequeue dd-mergequeue bot deleted the branden.clark/system-file-checker branch July 26, 2024 21:22
@github-actions github-actions bot added this to the 7.57.0 milestone Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/windows-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants