-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore microsoft.net in system path tester #27989
Conversation
[Fast Unit Tests Report] On pipeline 40263180 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=40263180 --os-family=ubuntu Note: This applies to commit 68b3da8 |
Regression DetectorRegression Detector ResultsRun ID: f3a07e03-a890-4c13-bdb3-88dd90f056cd Metrics dashboard Target profiles Baseline: ab2f289 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.50 | [+0.62, +2.38] | Logs |
➖ | idle | memory utilization | +0.27 | [+0.23, +0.30] | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | Logs |
➖ | otel_to_otel_logs | ingress throughput | -0.06 | [-0.87, +0.75] | Logs |
➖ | file_tree | memory utilization | -0.21 | [-0.27, -0.14] | Logs |
➖ | pycheck_1000_100byte_tags | % cpu utilization | -0.81 | [-5.50, +3.87] | Logs |
➖ | basic_py_check | % cpu utilization | -0.90 | [-3.46, +1.66] | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -1.15 | [-14.08, +11.77] | Logs |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
Add
C:\Windows\Microsoft.NET
to the list of paths that are ignored by the "does not remove system files" test.Motivation
The following paths creating flakes
flakes
https://datadoghq.atlassian.net/browse/WINA-794
https://datadoghq.atlassian.net/browse/WINA-923
https://datadoghq.atlassian.net/browse/WINA-924
https://datadoghq.atlassian.net/browse/WINA-925
https://datadoghq.atlassian.net/browse/WINA-929
todo card to come up with a better test
https://datadoghq.atlassian.net/browse/WINA-624
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
N/A, e2e test update