Handle errors in python subprocess cmd.Start() (#27986)

DataDog · Jul 26, 2024 · ab2f289 · ab2f289
1 parent 5cafc93
commit ab2f289
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/pkg/collector/python/test_util.go b/pkg/collector/python/test_util.go
@@ -59,7 +59,7 @@ func testGetSubprocessOutputUnknownBin(t *testing.T) {
 	assert.Equal(t, "", C.GoString(cStdout))
 	assert.Equal(t, "", C.GoString(cStderr))
 	assert.Equal(t, C.int(0), cRetCode)
-	assert.Nil(t, exception)
+	assert.NotNil(t, exception)
 }
 
 func testGetSubprocessOutputError(t *testing.T) {

diff --git a/pkg/collector/python/util.go b/pkg/collector/python/util.go
@@ -68,7 +68,11 @@ func GetSubprocessOutput(argv **C.char, env **C.char, cStdout **C.char, cStderr
 		outputErr, _ = io.ReadAll(stderr)
 	}()
 
-	cmd.Start() //nolint:errcheck
+	err = cmd.Start()
+	if err != nil {
+		*exception = TrackedCString(fmt.Sprintf("internal error starting subprocess: %v", err))
+		return
+	}
 
 	// Wait for the pipes to be closed *before* waiting for the cmd to exit, as per os.exec docs
 	wg.Wait()