Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mypy to the pre-commit hooks #27266

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Jul 3, 2024

What does this PR do?

Add mypy to the pre-commit hooks

Motivation

Follow-up for #27254

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@FlorentClarret FlorentClarret added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Jul 3, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 38226279 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@pr-commenter
Copy link

pr-commenter bot commented Jul 3, 2024

Regression Detector

Regression Detector Results

Run ID: a38d8ade-d6a4-4c2b-88a6-b91ce50bd439 Metrics dashboard Target profiles

Baseline: d41ff64
Comparison: 961c6eb

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
tcp_syslog_to_blackhole ingress throughput +6.37 [-6.66, +19.41] Logs
basic_py_check % cpu utilization +1.38 [-1.23, +3.99] Logs
idle memory utilization +0.56 [+0.51, +0.60] Logs
pycheck_1000_100byte_tags % cpu utilization +0.44 [-4.40, +5.28] Logs
otel_to_otel_logs ingress throughput +0.36 [-0.45, +1.17] Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.26 [-0.62, +1.14] Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] Logs
file_tree memory utilization -1.74 [-1.82, -1.65] Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@FlorentClarret FlorentClarret marked this pull request as ready for review July 3, 2024 11:19
@FlorentClarret FlorentClarret requested a review from a team as a code owner July 3, 2024 11:19
@FlorentClarret
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jul 3, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 25m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 51437cf into main Jul 3, 2024
215 of 216 checks passed
@dd-mergequeue dd-mergequeue bot deleted the florentclarret/mypy-precommit branch July 3, 2024 13:11
@github-actions github-actions bot added this to the 7.56.0 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/agent-devx-loops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants