Enable mypy on Invoke tasks #27254
Merged
Enable mypy on Invoke tasks #27254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorentClarret
added
changelog/no-changelog
qa/no-code-change
gjulianm
approved these changes
Jul 3, 2024
pducolin
approved these changes
Jul 3, 2024
CelianR
approved these changes
Jul 3, 2024
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable mypy on Invoke tasks and fix the
attr-definederrors we have.For now, I just ignore all the other errors we have so we won't get any new errors out of this list. I'll fix them one by one in the future.
Type annotations are not enforced, when I had a doubt because there was something obviously wrong I just deleted the annotation to fix the error. Having no type annotations is better than having the wrong one.
I bumped the base image to get DataDog/datadog-agent-buildimages#613
Motivation
Proper fix for #27247
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes