-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from black and flake8 to ruff for Python files #24590
Conversation
07615e1
to
67d65a4
Compare
67d65a4
to
8c485ee
Compare
Regression DetectorRegression Detector ResultsRun ID: 7c3a6e11-25f9-49f6-9144-1a6ef15c1d47 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | file_to_blackhole | % cpu utilization | +2.34 | [-3.71, +8.40] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | file_to_blackhole | % cpu utilization | +2.34 | [-3.71, +8.40] |
➖ | pycheck_1000_100byte_tags | % cpu utilization | +2.22 | [-2.72, +7.16] |
➖ | process_agent_standard_check_with_stats | memory utilization | +0.35 | [+0.30, +0.39] |
➖ | otel_to_otel_logs | ingress throughput | +0.27 | [-0.14, +0.69] |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.14 | [-2.81, +3.09] |
➖ | process_agent_standard_check | memory utilization | +0.11 | [+0.06, +0.17] |
➖ | file_tree | memory utilization | +0.03 | [-0.09, +0.15] |
➖ | trace_agent_msgpack | ingress throughput | +0.02 | [+0.01, +0.03] |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.19, +0.22] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.01 | [-0.04, +0.03] |
➖ | trace_agent_json | ingress throughput | -0.01 | [-0.03, +0.01] |
➖ | idle | memory utilization | -0.10 | [-0.14, -0.06] |
➖ | process_agent_real_time_mode | memory utilization | -0.12 | [-0.17, -0.08] |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.14 | [-0.23, -0.06] |
➖ | basic_py_check | % cpu utilization | -1.64 | [-4.15, +0.86] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
8c485ee
to
471cfab
Compare
471cfab
to
0781f51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for files that ASC owns
/merge |
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 25m) Use |
* Switch from black and flake8 to ruff for Python files * fix * Update .pre-commit-config.yaml * Update pyproject.toml * address * fix fmt * future * noqa * fix comment
* Switch from black and flake8 to ruff for Python files * fix * Update .pre-commit-config.yaml * Update pyproject.toml * address * fix fmt * future * noqa * fix comment
What does this PR do?
We currently use:
We drop them all to replace them with ruff which can do the same things! I also updated the hooks, people that are using them won't need to do anything.
I kept almost the same rules we already have to avoid modifying too many things. We will probably update some of them in the future.
Motivation
Additional Notes
This PR depends on:
https://datadoghq.atlassian.net/browse/ADXT-186
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes