Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruff to the Python deps #568

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Apr 11, 2024

We plan to replace flake8 + isort + black with ruff.

I'll open another PR in the agent later to use it, and another one after to drop the old libraries

https://datadoghq.atlassian.net/browse/ADXT-186

@FlorentClarret FlorentClarret force-pushed the florentclarret/install_ruff branch from 19cc32f to c835801 Compare April 11, 2024 07:15
@FlorentClarret FlorentClarret marked this pull request as ready for review April 11, 2024 13:41
@FlorentClarret FlorentClarret requested a review from a team as a code owner April 11, 2024 13:41
Copy link
Contributor

@CelianR CelianR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you want to only update constraints and not requirement files ? If so lgtm 👍

@FlorentClarret FlorentClarret force-pushed the florentclarret/install_ruff branch from c835801 to 5829d03 Compare April 11, 2024 13:47
@FlorentClarret
Copy link
Member Author

Are you sure you want to only update constraints and not requirement files ? If so lgtm 👍

Fixed!

@FlorentClarret FlorentClarret force-pushed the florentclarret/install_ruff branch from 5829d03 to f330704 Compare April 11, 2024 14:22
@FlorentClarret FlorentClarret changed the title Add ruff to the Python constraints Add ruff to the Python deps Apr 11, 2024
@FlorentClarret FlorentClarret enabled auto-merge (squash) April 11, 2024 14:34
@FlorentClarret FlorentClarret merged commit 6edac87 into main Apr 11, 2024
21 checks passed
@FlorentClarret FlorentClarret deleted the florentclarret/install_ruff branch April 11, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants