-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging in testDNSStats #21470
Add logging in testDNSStats #21470
Conversation
TestDNSStatsWithNAT is still flaky, I'm noticing that many of the failures are on prebuilt, and the CO-RE failures have the suspicious 'clang timed out error'. I'm wondering if this is an issue of the netlink conntracker being behind the real tracer. These logs will help verify. If all the failures we see are on prebuilt, we can either skip this test with netlink conntrack, or add some synchronization
/merge |
🚂 MergeQueue This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. you can cancel this operation by commenting your pull request with |
/merge |
❌ MergeQueue PR is already in db with waiting status If you need support, contact us on slack #ci-interfaces with those details! |
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: caef9ffc-2f4d-46a1-9d64-0b1e1a1bab11 Performance changes are noted in the perf column of each table:
|
perf | experiment | goal | Δ mean % | Δ mean % CI | confidence |
---|---|---|---|---|---|
❌ | otel_to_otel_logs | ingress throughput | -1.35 | [-2.05, -0.66] | 99.86% |
Experiments with missing or malformed data
- idle
Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI | confidence |
---|---|---|---|---|---|
✅ | tcp_syslog_to_blackhole | ingress throughput | +0.66 | [+0.60, +0.72] | 100.00% |
✅ | file_tree | egress throughput | +0.12 | [-1.68, +1.91] | 8.58% |
❌ | dogstatsd_string_interner_128MiB_1k | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | dogstatsd_string_interner_8MiB_10k | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | trace_agent_json | ingress throughput | +0.00 | [-0.01, +0.01] | 0.00% |
❌ | dogstatsd_string_interner_64MiB_100 | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | dogstatsd_string_interner_8MiB_100 | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | dogstatsd_string_interner_8MiB_50k | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | trace_agent_msgpack | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | dogstatsd_string_interner_64MiB_1k | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | dogstatsd_string_interner_128MiB_100 | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | dogstatsd_string_interner_8MiB_1k | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | dogstatsd_string_interner_8MiB_100k | ingress throughput | -0.00 | [-0.00, +0.00] | 9.82% |
❌ | file_to_blackhole | egress throughput | -0.01 | [-6.17, +6.15] | 0.22% |
❌ | otel_to_otel_logs | ingress throughput | -1.35 | [-2.05, -0.66] | 99.86% |
🚂 MergeQueue Added to the queue. There are 2 builds ahead of this PR! (estimated merge in less than 1h) you can cancel this operation by commenting your pull request with |
What does this PR do?
TestDNSStatsWithNAT is still flaky, I'm noticing that many of the failures are on prebuilt, and the CO-RE failures have the suspicious 'clang timed out error'. I'm wondering if this is an issue of the netlink conntracker being behind the real tracer. These logs will help verify. If all the failures we see are on prebuilt, we can either skip this test with netlink conntrack, or add some synchronization
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Triage
milestone is set.major_change
label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changelog
label has been applied.qa/skip-qa
label is not applied.team/..
label has been applied, indicating the team(s) that should QA this change.need-change/operator
andneed-change/helm
labels have been applied.k8s/<min-version>
label, indicating the lowest Kubernetes version compatible with this feature.