Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging in testDNSStats #21470

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

leeavital
Copy link
Contributor

What does this PR do?

TestDNSStatsWithNAT is still flaky, I'm noticing that many of the failures are on prebuilt, and the CO-RE failures have the suspicious 'clang timed out error'. I'm wondering if this is an issue of the netlink conntracker being behind the real tracer. These logs will help verify. If all the failures we see are on prebuilt, we can either skip this test with netlink conntrack, or add some synchronization

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

TestDNSStatsWithNAT is still flaky, I'm noticing that many of the failures are on prebuilt, and the CO-RE
failures have the suspicious 'clang timed out error'. I'm wondering if
this is an issue of the netlink conntracker being behind the real
tracer. These logs will help verify. If all the failures we see are on
prebuilt, we can either skip this test with netlink conntrack,  or add
some synchronization
@leeavital
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 11, 2023

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

you can cancel this operation by commenting your pull request with /merge -c!

@leeavital
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 11, 2023

❌ MergeQueue

PR is already in db with waiting status

If you need support, contact us on slack #ci-interfaces with those details!

@pr-commenter
Copy link

pr-commenter bot commented Dec 11, 2023

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: caef9ffc-2f4d-46a1-9d64-0b1e1a1bab11
Baseline: 2af43d0
Comparison: 2315acb
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ denotes better comparison variant performance
  • ❌ denotes worse comparison variant performance

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Declared stable experiments that are now erratic

An experiment is erratic (i.e., not stable) if its coefficient of variation is at least 0.10.

perf experiment goal Δ mean % Δ mean % CI confidence
otel_to_otel_logs ingress throughput -1.35 [-2.05, -0.66] 99.86%

Experiments with missing or malformed data

  • idle

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI confidence
tcp_syslog_to_blackhole ingress throughput +0.66 [+0.60, +0.72] 100.00%
file_tree egress throughput +0.12 [-1.68, +1.91] 8.58%
dogstatsd_string_interner_128MiB_1k ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_8MiB_10k ingress throughput +0.00 [-0.00, +0.00] 0.00%
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] 0.00%
trace_agent_json ingress throughput +0.00 [-0.01, +0.01] 0.00%
dogstatsd_string_interner_64MiB_100 ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_8MiB_100 ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_8MiB_50k ingress throughput +0.00 [-0.00, +0.00] 0.00%
trace_agent_msgpack ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_64MiB_1k ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_128MiB_100 ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_8MiB_1k ingress throughput +0.00 [-0.00, +0.00] 0.00%
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_8MiB_100k ingress throughput -0.00 [-0.00, +0.00] 9.82%
file_to_blackhole egress throughput -0.01 [-6.17, +6.15] 0.22%
otel_to_otel_logs ingress throughput -1.35 [-2.05, -0.66] 99.86%

@dd-devflow
Copy link

dd-devflow bot commented Dec 11, 2023

🚂 MergeQueue

Added to the queue.

There are 2 builds ahead of this PR! (estimated merge in less than 1h)

you can cancel this operation by commenting your pull request with /merge -c!

@dd-mergequeue dd-mergequeue bot merged commit 8e3aa2f into main Dec 11, 2023
193 of 195 checks passed
@dd-mergequeue dd-mergequeue bot deleted the lee.avital/more_dns_nat_logging branch December 11, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants