Update opentelemetry-mapping-go to v0.9.0 #21524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
added
component/otlp
Go Package Import DifferencesBaseline: e1ef601
|
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: e62a8e9e-47c6-4bfe-a853-34c45c3667ae Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +1.25 | [-5.40, +7.90] |
| ➖ | idle | memory utilization | -0.27 | [-0.29, -0.25] |
| ➖ | file_tree | memory utilization | -0.99 | [-1.09, -0.89] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +1.25 | [-5.40, +7.90] |
| ➖ | otel_to_otel_logs | ingress throughput | +0.33 | [-0.42, +1.08] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.19 | [+0.13, +0.26] |
| ➖ | dogstatsd_string_interner_8MiB_100k | ingress throughput | +0.06 | [+0.04, +0.07] |
| ➖ | trace_agent_json | ingress throughput | +0.03 | [+0.00, +0.06] |
| ➖ | dogstatsd_string_interner_128MiB_1k | ingress throughput | +0.00 | [-0.05, +0.05] |
| ➖ | dogstatsd_string_interner_128MiB_100 | ingress throughput | +0.00 | [-0.05, +0.05] |
| ➖ | dogstatsd_string_interner_8MiB_10k | ingress throughput | +0.00 | [-0.04, +0.04] |
| ➖ | dogstatsd_string_interner_8MiB_100 | ingress throughput | +0.00 | [-0.04, +0.04] |
| ➖ | dogstatsd_string_interner_8MiB_1k | ingress throughput | +0.00 | [-0.04, +0.04] |
| ➖ | dogstatsd_string_interner_64MiB_100 | ingress throughput | -0.00 | [-0.04, +0.04] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.06, +0.06] |
| ➖ | dogstatsd_string_interner_8MiB_50k | ingress throughput | -0.00 | [-0.04, +0.04] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.04, +0.04] |
| ➖ | dogstatsd_string_interner_64MiB_1k | ingress throughput | -0.00 | [-0.04, +0.04] |
| ➖ | trace_agent_msgpack | ingress throughput | -0.02 | [-0.05, +0.01] |
| ➖ | process_agent_standard_check | memory utilization | -0.22 | [-0.27, -0.18] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | -0.25 | [-0.29, -0.20] |
| ➖ | idle | memory utilization | -0.27 | [-0.29, -0.25] |
| ➖ | process_agent_real_time_mode | memory utilization | -0.79 | [-0.82, -0.76] |
| ➖ | file_tree | memory utilization | -0.99 | [-1.09, -0.89] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
This comment was marked as resolved.
This comment was marked as resolved.
mx-psi
force-pushed
the
mx-psi/otel-mapping-v0.9.0
branch
from
d4841b2 to
4c1e252
Compare
mackjmr
approved these changes
Dec 13, 2023
drichards-87
approved these changes
Dec 13, 2023
Co-authored-by: DeForest Richards <[email protected]>
vickenty
approved these changes
Dec 14, 2023
|
@DataDog/agent-apm any chance you can review this? 🙏 |
ajgajg1134
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bumps opentelemetry-mapping-go to v0.9.0.
Motivation
Include:
process.runtime.jvm.gc.durationopentelemetry-mapping-go#213Additional Notes
The metrics change does not affect the OTLP ingest pipeline, since the Agent does not have the internal metrics pipeline enabled
Describe how to test/QA your changes
Send an OTLP log to the Agent and verify that milliseconds are shown in the timestamp on the UI.
Reviewer's Checklist
Triagemilestone is set.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel is not applied.team/..label has been applied, indicating the team(s) that should QA this change.need-change/operatorandneed-change/helmlabels have been applied.k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature.