-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
omnibus: lmdb: allow overriding build/install environment & use common env/flags #21462
Conversation
…n env/flags This allows us to just `make install` instead of manually copying every files around. It also allows for modifying the compiler we use We can now also modify the build environment if needed
277c264
to
6d9ead9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: c0a52577-2d6e-416b-8c98-e28b55bbdcfb Performance changes are noted in the perf column of each table:
|
perf | experiment | goal | Δ mean % | Δ mean % CI | confidence |
---|---|---|---|---|---|
❌ | otel_to_otel_logs | ingress throughput | -0.29 | [-0.99, +0.41] | 50.15% |
Experiments with missing or malformed data
- dogstatsd_string_interner_128MiB_100
- idle
Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI | confidence |
---|---|---|---|---|---|
✅ | dogstatsd_string_interner_8MiB_100k | ingress throughput | +0.00 | [-0.04, +0.04] | 2.53% |
✅ | trace_agent_msgpack | ingress throughput | +0.00 | [-0.01, +0.01] | 2.65% |
❌ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | dogstatsd_string_interner_64MiB_1k | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | dogstatsd_string_interner_8MiB_100 | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | dogstatsd_string_interner_8MiB_10k | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | dogstatsd_string_interner_8MiB_1k | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | dogstatsd_string_interner_8MiB_50k | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | trace_agent_json | ingress throughput | +0.00 | [-0.01, +0.01] | 0.00% |
❌ | dogstatsd_string_interner_64MiB_100 | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | dogstatsd_string_interner_128MiB_1k | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | file_to_blackhole | egress throughput | -0.02 | [-6.18, +6.14] | 0.48% |
❌ | tcp_syslog_to_blackhole | ingress throughput | -0.18 | [-0.25, -0.10] | 99.99% |
❌ | file_tree | egress throughput | -0.21 | [-2.00, +1.59] | 14.99% |
❌ | otel_to_otel_logs | ingress throughput | -0.29 | [-0.99, +0.41] | 50.15% |
/merge |
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 45m) you can cancel this operation by commenting your pull request with |
/merge |
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 45m) you can cancel this operation by commenting your pull request with |
What does this PR do?
Fix and simplify the lmdb recipe
Motivation
We can now specify a different toolchain, use specific compiler flags, and don't have to copy each individual file we need to the install directory
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Triage
milestone is set.major_change
label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changelog
label has been applied.qa/skip-qa
label is not applied.team/..
label has been applied, indicating the team(s) that should QA this change.need-change/operator
andneed-change/helm
labels have been applied.k8s/<min-version>
label, indicating the lowest Kubernetes version compatible with this feature.