Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omnibus: lmdb: allow overriding build/install environment & use common env/flags #21462

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

chouquette
Copy link
Contributor

What does this PR do?

Fix and simplify the lmdb recipe

Motivation

We can now specify a different toolchain, use specific compiler flags, and don't have to copy each individual file we need to the install directory

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@chouquette chouquette added changelog/no-changelog [deprecated] team/agent-platform [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card labels Dec 11, 2023
@chouquette chouquette added this to the 7.51.0 milestone Dec 11, 2023
@chouquette chouquette requested a review from a team as a code owner December 11, 2023 08:38
…n env/flags

This allows us to just `make install` instead of manually copying every files
around. It also allows for modifying the compiler we use
We can now also modify the build environment if needed
@chouquette chouquette force-pushed the chouquette/lmdb_simplify branch from 277c264 to 6d9ead9 Compare December 11, 2023 09:17
Copy link
Member

@KevinFairise2 KevinFairise2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@chouquette
Copy link
Contributor Author

@pr-commenter
Copy link

pr-commenter bot commented Dec 11, 2023

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: c0a52577-2d6e-416b-8c98-e28b55bbdcfb
Baseline: bc41561
Comparison: 6d9ead9
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ denotes better comparison variant performance
  • ❌ denotes worse comparison variant performance

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Declared stable experiments that are now erratic

An experiment is erratic (i.e., not stable) if its coefficient of variation is at least 0.10.

perf experiment goal Δ mean % Δ mean % CI confidence
otel_to_otel_logs ingress throughput -0.29 [-0.99, +0.41] 50.15%

Experiments with missing or malformed data

  • dogstatsd_string_interner_128MiB_100
  • idle

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI confidence
dogstatsd_string_interner_8MiB_100k ingress throughput +0.00 [-0.04, +0.04] 2.53%
trace_agent_msgpack ingress throughput +0.00 [-0.01, +0.01] 2.65%
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_64MiB_1k ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_8MiB_100 ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_8MiB_10k ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_8MiB_1k ingress throughput +0.00 [-0.00, +0.00] 0.00%
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_8MiB_50k ingress throughput +0.00 [-0.00, +0.00] 0.00%
trace_agent_json ingress throughput +0.00 [-0.01, +0.01] 0.00%
dogstatsd_string_interner_64MiB_100 ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_128MiB_1k ingress throughput +0.00 [-0.00, +0.00] 0.00%
file_to_blackhole egress throughput -0.02 [-6.18, +6.14] 0.48%
tcp_syslog_to_blackhole ingress throughput -0.18 [-0.25, -0.10] 99.99%
file_tree egress throughput -0.21 [-2.00, +1.59] 14.99%
otel_to_otel_logs ingress throughput -0.29 [-0.99, +0.41] 50.15%

@chouquette
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 11, 2023

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 45m)

you can cancel this operation by commenting your pull request with /merge -c!

@chouquette
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 11, 2023

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 45m)

you can cancel this operation by commenting your pull request with /merge -c!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants