Move api code from cmd to comp #21359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Guerguadj <[email protected]>
Signed-off-by: Nicolas Guerguadj <[email protected]>
…comp Signed-off-by: Nicolas Guerguadj <[email protected]>
Go Package Import DifferencesBaseline: e07ec60
|
Kaderinho
added
[deprecated] qa/skip-qa - use other qa/ labels
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: f1c5864b-5be2-4721-b971-b34fa2eaf0b2 Explanation A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI". For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Experiments that were not declared erratic but were detected as being so, coefficient of variation cutoff 0.10:
Experiments where analysis encountered missing or malformed data: idle Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration. Fine details of change detection per experiment.
|
pgimalac
approved these changes
Dec 6, 2023
|
@pgimalac it's a bit weird but the first |
NouhaManai96
approved these changes
Dec 6, 2023
L3n41c
approved these changes
Dec 6, 2023
|
/merge |
|
🚂 MergeQueue Pull request added to the queue. There are 3 builds ahead! (estimated merge in less than 2h) you can cancel this operation by commenting your pull request with |
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-mergequeue
bot
deleted the
nicolas.guerguadj/move-api-code-from-cmd-to-comp
branch
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Move code from cmd to comp as a follow up of #21028
Motivation
This code should be under
compbut was not in the first PR to avoid conflictsAdditional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Should be a noop
Reviewer's Checklist
Triagemilestone is set.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel is not applied.team/..label has been applied, indicating the team(s) that should QA this change.need-change/operatorandneed-change/helmlabels have been applied.k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature.