Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSPM] Compliance module: improve err report and fix tests #21150

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

jinroh
Copy link
Contributor

@jinroh jinroh commented Nov 28, 2023

What does this PR do?

  • Make the module work for processes running outside of a container
  • Improve the error reporting of the compliance module by reporting the error string as part of the response body.

Also fixes and improve the tests:

  • remove the symlink chmod (was failing locally for some contributors)
  • check the proper result when no configuration path has been found.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@jinroh jinroh added changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card team/agent-cspm labels Nov 28, 2023
@jinroh jinroh added this to the 7.51.0 milestone Nov 28, 2023
@pr-commenter
Copy link

pr-commenter bot commented Nov 28, 2023

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 2a06656f-6e23-4e4b-a4c8-8c9f109ed301
Baseline: 7535b8d
Comparison: 41804d5
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ denotes better comparison variant performance
  • ❌ denotes worse comparison variant performance

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Experiments with missing or malformed data

  • dogstatsd_string_interner_128MiB_100
  • dogstatsd_string_interner_128MiB_1k
  • dogstatsd_string_interner_64MiB_100
  • dogstatsd_string_interner_64MiB_1k
  • dogstatsd_string_interner_8MiB_100
  • dogstatsd_string_interner_8MiB_10k
  • dogstatsd_string_interner_8MiB_1k
  • dogstatsd_string_interner_8MiB_50k
  • file_tree
  • idle
  • otel_to_otel_logs
  • tcp_dd_logs_filter_exclude
  • tcp_syslog_to_blackhole
  • trace_agent_json
  • uds_dogstatsd_to_api

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI confidence
trace_agent_msgpack ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_8MiB_100k ingress throughput -0.00 [-0.00, +0.00] 6.56%
file_to_blackhole egress throughput -0.13 [-6.29, +6.03] 2.70%

@jinroh jinroh force-pushed the jinroh/improve-compliance-module-err-report branch from 209f382 to d97a9c4 Compare November 28, 2023 16:33
@jinroh jinroh force-pushed the jinroh/improve-compliance-module-err-report branch from d97a9c4 to 43bb944 Compare December 8, 2023 13:29
@jinroh jinroh removed the [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card label Dec 8, 2023
@jinroh jinroh force-pushed the jinroh/improve-compliance-module-err-report branch from 43bb944 to 6c4afea Compare December 8, 2023 13:44
@jinroh jinroh force-pushed the jinroh/improve-compliance-module-err-report branch from 27fa1ac to 41804d5 Compare December 8, 2023 15:00
@jinroh jinroh marked this pull request as ready for review December 8, 2023 15:15
@jinroh jinroh requested review from a team as code owners December 8, 2023 15:15
@jinroh jinroh merged commit 04a5acb into main Dec 8, 2023
145 of 148 checks passed
@jinroh jinroh deleted the jinroh/improve-compliance-module-err-report branch December 8, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants