[ASCII-931][component] Create orchestrator forwarder component #21058
Conversation
Goal: Make next commit easier Note: DemultiplexerMock cannot be used in pkg/aggregator because comp/aggregator depends on pkg/aggregator
Go Package Import DifferencesBaseline: 28bf6fd
|
…/create-orchestrator-fwd
ogaca-dd
changed the title
| fx.Provide(func() demultiplexer.Params { | ||
| opts := aggregator.DefaultAgentDemultiplexerOptions() | ||
| opts.UseEventPlatformForwarder = false | ||
| opts.UseOrchestratorForwarder = false |
There was a problem hiding this comment.
As can be seen here, I believe the security agent does not need the orchestrator forwarder
There was a problem hiding this comment.
Indeed, it doesn't and this is the reason why it is not enabled. See fx.Supply(orchestratorForwarderImpl.Params{UseOrchestratorForwarder: false}) few lines upper.
There was a problem hiding this comment.
Ah ok indeed, what would happen if we did not provide the module and the params supply ? Wouldn't it default to disabled as well ?
There was a problem hiding this comment.
Because the demultiplexer uses the orchestrator forwarder, orchestrator forwarder is always mandatory when using the demultiplexer (Fx refuses to start the application if the module and the params are missing).
Note: There are units tests that check subcommands provides all the require modules and params. There is a linter to make sure all subcommand are tested (I also have a card to check there is no missing tests for other cases).
|
I think we have learned now that big-bang PRs like this one are difficult to test, and will probably lead to broken code paths. I would like to see this PR refactored and the migration done package by package, or at least team by team |
@paulcacheux I understand your concern. Unlike many other PRs, I spent a fair amount of time to create small atomic commits to the better catch behaviour changes during review. |
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: e0ccbafb-c08a-4ec8-b176-d2e093136dfa ExplanationA regression test is an integrated performance test for Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval. We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:
The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
…/create-orchestrator-fwd
cmd/otel-agent/main.go
Outdated
| @@ -72,6 +73,8 @@ func main() { | |||
| ), | |||
| fx.Provide(newForwarderParams), | |||
| demultiplexer.Module, | |||
| orchestratorForwarderImpl.Module, | |||
| fx.Supply(orchestratorForwarderImpl.NewDefaultParams()), | |||
There was a problem hiding this comment.
I believe it should be disabled in the otel agent (like the security agent)
There was a problem hiding this comment.
It was previously enabled by calling aggregator.DefaultAgentDemultiplexerOptions() which set UseOrchestratorForwarder: true
There was a problem hiding this comment.
I have got the confirmation from open telemetry team and it should not be enabled.
comp/forwarder/orchestrator/orchestratorimpl/forwarder_orchestrator.go
Outdated
Show resolved
Hide resolved
comp/forwarder/orchestrator/orchestratorimpl/forwarder_orchestrator_mock.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Pierre Margueritte <[email protected]>
comp/forwarder/orchestrator/orchestratorimpl/forwarder_no_orchestrator.go
Outdated
Show resolved
Hide resolved
…/create-orchestrator-fwd
* Move NewOrchestratorForwarder into a new component * Reduce the number of calls to `InitAndStartAgentDemultiplexerForTest` Goal: Make next commit easier Note: DemultiplexerMock cannot be used in pkg/aggregator because comp/aggregator depends on pkg/aggregator * Use orchestrator forwarder component. * Make orchestrator component optional * Fix TestDemuxForwardersCreated * Update CODEOWNERS (aggregator is owned by agent-metrics-logs) * Fix linters * Move the component to comp/forwarder/orchestrator * Fix lint-components * Fix Windows compilation issue * Disable Orchestrator Forwarder for open telemetry * Update .github/CODEOWNERS Co-authored-by: Pierre Margueritte <[email protected]> * Remove empty lines * Improve comment for Component.Reset * Use constructor for Params * Fix windows linter * Improve comments * Fix code owner --------- Co-authored-by: Pierre Margueritte <[email protected]>
* Move NewOrchestratorForwarder into a new component * Reduce the number of calls to `InitAndStartAgentDemultiplexerForTest` Goal: Make next commit easier Note: DemultiplexerMock cannot be used in pkg/aggregator because comp/aggregator depends on pkg/aggregator * Use orchestrator forwarder component. * Make orchestrator component optional * Fix TestDemuxForwardersCreated * Update CODEOWNERS (aggregator is owned by agent-metrics-logs) * Fix linters * Move the component to comp/forwarder/orchestrator * Fix lint-components * Fix Windows compilation issue * Disable Orchestrator Forwarder for open telemetry * Update .github/CODEOWNERS Co-authored-by: Pierre Margueritte <[email protected]> * Remove empty lines * Improve comment for Component.Reset * Use constructor for Params * Fix windows linter * Improve comments * Fix code owner --------- Co-authored-by: Pierre Margueritte <[email protected]>
What does this PR do?
This PR extracts the orchestrator forwarder from the aggregator and create a new component.
Reviewing commit per commit is strongly recommended.
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Perform sanity checks on the orchestrator forwarder.
Reviewer's Checklist
Triagemilestone is set.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel is not applied.team/..label has been applied, indicating the team(s) that should QA this change.need-change/operatorandneed-change/helmlabels have been applied.k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature.