[Serverless] Benchmarks for start/end-invocation. #21046
Conversation
purple4reina
added
changelog/no-changelog
[deprecated] qa/skip-qa - use other qa/ labels
There was a problem hiding this comment.
Gives us a baseline benchmark.
purple4reina
force-pushed
the
rey.abolofia/benchmarks
branch
3 times, most recently
from
66e991f to
d12ee08
Compare
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: a1bc73fe-3cae-42cf-9866-b5fb7046b28b ExplanationA regression test is an integrated performance test for Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval. We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:
The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
pkg/serverless/daemon/routes_test.go
Outdated
| startBody := getEventFromFile(file.Name()) | ||
| b.Run("event="+file.Name(), func(b *testing.B) { | ||
| startReq := httptest.NewRequest("GET", "/lambda/start-invocation", nil) | ||
| endReq := httptest.NewRequest("GET", "/lambda/endd-invocation", nil) |
There was a problem hiding this comment.
Sure is! Great catch.
purple4reina
force-pushed
the
rey.abolofia/benchmarks
branch
from
d12ee08 to
e966922
Compare
What does this PR do?
Adds benchmarks to track overhead of calling start and end invocation.
Motivation
In the future, we can create a github action to run on pull request to track changes to benchmark time.
Additional Notes
Run benchmarks
Compare benchmarks
Sample output
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Triagemilestone is set.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel is not applied.team/..label has been applied, indicating the team(s) that should QA this change.need-change/operatorandneed-change/helmlabels have been applied.k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature.