Convert pkg/util/winutil to module

[dineshg13]

What does this PR do?

PR converts pkg/util/winutil to go module. In the process we do the following

• Move pkg/util/winutil/crashreport to pkg/util/crashreport - to simplify creating pkg/util/winutil module
• Move pkg/util/winutil/pdhutil to pkg/util/pdhutil - to simplify creating pkg/util/winutil module

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

• create a windows vm
• install IIS
• powershell: Install-WindowsFeature -name Web-Server -IncludeManagementTools
• install the agent
• enable USM & NPM in system probe
• ensure you see your host in NPM
• after generating some http traffic, make sure you see defaultapppool in services for your host in USM

Reviewer's Checklist

• If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
• Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
• A release note has been added or the changelog/no-changelog label has been applied.
• Changed code has automated tests for its functionality.
• Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
• At least one team/.. label has been applied, indicating the team(s) that should QA this change.
• If applicable, docs team has been notified or an issue has been opened on the documentation repo.
• If applicable, the need-change/operator and need-change/helm labels have been applied.
• If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
• If applicable, the config template has been updated.

[cit-pr-commenter]

Go Package Import Differences

Baseline: 750770c
Comparison: ed801be

binary	os	arch	change
agent	windows	amd64	+2, -2 +github.com/DataDog/datadog-agent/pkg/util/crashreport +github.com/DataDog/datadog-agent/pkg/util/pdhutil -github.com/DataDog/datadog-agent/pkg/util/winutil/crashreport -github.com/DataDog/datadog-agent/pkg/util/winutil/pdhutil
agent	windows	386	+2, -2 +github.com/DataDog/datadog-agent/pkg/util/crashreport +github.com/DataDog/datadog-agent/pkg/util/pdhutil -github.com/DataDog/datadog-agent/pkg/util/winutil/crashreport -github.com/DataDog/datadog-agent/pkg/util/winutil/pdhutil
process-agent	windows	amd64	+1, -1 +github.com/DataDog/datadog-agent/pkg/util/pdhutil -github.com/DataDog/datadog-agent/pkg/util/winutil/pdhutil
system-probe	windows	amd64	+1, -1 +github.com/DataDog/datadog-agent/pkg/util/pdhutil -github.com/DataDog/datadog-agent/pkg/util/winutil/pdhutil

[iglendd]

Perfect. Removing non-generic function from ETW is improves its implementation. Thank you. The only thing is setting ownership for crash reporting where I left the comment.

[guyarb]

Remove a file - #20851 (comment)

[pr-commenter]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 444eb296-d243-45db-bb77-ec424f4c2c3a
Baseline: 750770c
Comparison: ed801be
Total datadog-agent CPUs: 7

Explanation

A regression test is an integrated performance test for datadog-agent in a repeatable rig, with varying configuration for datadog-agent. What follows is a statistical summary of a brief datadog-agent run for each configuration across SHAs given above. The goal of these tests are to determine quickly if datadog-agent performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.

experiment	goal	Δ mean %	Δ mean % CI	confidence
tcp_syslog_to_blackhole	ingress throughput	+0.90	[+0.77, +1.03]	100.00%
idle	egress throughput	+0.06	[-2.39, +2.51]	3.07%
trace_agent_json	ingress throughput	+0.03	[-0.10, +0.16]	31.75%
dogstatsd_string_interner_8MiB_10k	ingress throughput	+0.01	[-0.03, +0.04]	26.67%
dogstatsd_string_interner_128MiB_1k	ingress throughput	+0.01	[-0.13, +0.15]	4.95%
dogstatsd_string_interner_8MiB_100	ingress throughput	+0.00	[-0.13, +0.13]	3.01%
tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.16, +0.16]	0.59%
dogstatsd_string_interner_64MiB_1k	ingress throughput	+0.00	[-0.13, +0.13]	0.44%
dogstatsd_string_interner_128MiB_100	ingress throughput	+0.00	[-0.14, +0.14]	0.08%
dogstatsd_string_interner_64MiB_100	ingress throughput	+0.00	[-0.14, +0.14]	0.07%
uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.18, +0.17]	0.53%
dogstatsd_string_interner_8MiB_100k	ingress throughput	-0.01	[-0.08, +0.06]	13.22%
trace_agent_msgpack	ingress throughput	-0.01	[-0.13, +0.12]	7.79%
dogstatsd_string_interner_8MiB_1k	ingress throughput	-0.02	[-0.12, +0.09]	20.01%
dogstatsd_string_interner_8MiB_50k	ingress throughput	-0.02	[-0.05, +0.02]	58.59%
file_to_blackhole	egress throughput	-0.09	[-1.10, +0.93]	11.21%
file_tree	egress throughput	-0.15	[-2.01, +1.70]	10.84%
otel_to_otel_logs	ingress throughput	-0.90	[-2.47, +0.68]	65.15%

[amenasria]

LGTM for Agent Platform owned file !

[dustmop]

Heads up that secrets is being turned into a component by #20927. This will impact this PR by both moving the source out of pkg/secrets (into comp/core/secrets/secretsimpl) and also by slightly changing the method signatures of secrets. Aside from that, it should not be changing any functionality.

[hush-hush]

This PR seems to do a lot more than converting secrets into a module. Could we either split the PR or update the PR's title ?

[dineshg13]

@hush-hush I have updated the PR title. I have found communicating easier - the need to convert a specific package into a module by including the dependent package in one PR

@hush-hush @dustmop I will push an update to convert comp/core/secrets to a module
@dustmop The comp/core/secrets has introduced dependency on comp/core/flare/types

[dineshg13]

We were able to verify it is working as expected