Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appsec: upgrade appsec-internal-go 1.0.0 -> 1.0.1 #20505

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

eliottness
Copy link
Contributor

What does this PR do?

This PR follows up on DataDog/appsec-internal-go#8 to upgrade the recommended appsec ruleset to all location where it is used.

Motivation

We already skipped 3 minor versions. AWS Lambda GA Appsec usage would benefit from a more up-to-date rulset.

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@eliottness eliottness added this to the 7.50.0 milestone Oct 30, 2023
@eliottness eliottness self-assigned this Oct 30, 2023
@eliottness eliottness marked this pull request as ready for review October 30, 2023 14:51
@eliottness
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 30, 2023

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. You can remove it from the waiting list with /remove command.

you can cancel this operation by commenting your pull request with /merge -c!

@dd-devflow
Copy link

dd-devflow bot commented Oct 30, 2023

🚂 MergeQueue

Added to the queue.

This build is going to start soon! (estimated merge in less than 1h)

you can cancel this operation by commenting your pull request with /merge -c!

@eliottness eliottness merged commit 2e5d887 into main Oct 30, 2023
21 checks passed
@eliottness eliottness deleted the eliott.bouhana/APPSEC-11819 branch October 30, 2023 15:47
@dd-devflow
Copy link

dd-devflow bot commented Oct 30, 2023

🚂 MergeQueue

PullRequest was merged manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants