Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change always to on_success to prevent running child pipelines when images are not built #507

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KevinFairise2
Copy link
Member

With always the jobs are always run even if previous stages failed. On success will run jobs only if previous stages succeeded. It should avoid situations where we run datadog-agent pipeline with images that failed their build.
It will make the behaviour closer to what we have before #497

@KevinFairise2 KevinFairise2 requested a review from a team as a code owner January 4, 2024 13:14
Copy link
Contributor

@chouquette chouquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thanks for fixing!

@Pythyu
Copy link
Contributor

Pythyu commented Jan 4, 2024

It will break wait_for_tests when failling actually, a separate reference for wait_for_tests is needed with always still on. Needs to be added before merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants