Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheduled pipeline & remove deprecated only/except keywords #497

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

chouquette
Copy link
Contributor

No description provided.

@chouquette chouquette requested a review from a team as a code owner December 15, 2023 13:31
on_success & wait_for_tests were relying on a job that isn't created in the
context of a scheduled pipeline
Copy link
Contributor

@Pythyu Pythyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from my comment LGTM

.gitlab-ci.yml Outdated Show resolved Hide resolved
Copy link
Member

@KevinFairise2 KevinFairise2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, but you can let is as is. LGTM

.gitlab-ci.yml Outdated
Comment on lines 237 to 240
rules:
- if: $CI_COMMIT_TAG != null
when: never
- when: always
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this should be equivalent

Suggested change
rules:
- if: $CI_COMMIT_TAG != null
when: never
- when: always
rules:
- if: $CI_COMMIT_TAG == null

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! Fixed

@chouquette chouquette merged commit 2e6bd94 into main Dec 15, 2023
23 checks passed
@chouquette chouquette deleted the chouquette/remove_only_except branch December 15, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants