-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scheduled pipeline & remove deprecated only
/except
keywords
#497
Conversation
on_success & wait_for_tests were relying on a job that isn't created in the context of a scheduled pipeline
9b394ec
to
87b92dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from my comment LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit, but you can let is as is. LGTM
.gitlab-ci.yml
Outdated
rules: | ||
- if: $CI_COMMIT_TAG != null | ||
when: never | ||
- when: always |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this should be equivalent
rules: | |
- if: $CI_COMMIT_TAG != null | |
when: never | |
- when: always | |
rules: | |
- if: $CI_COMMIT_TAG == null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed! Fixed
No description provided.