Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dd-handler] Loosen constraint on chef_handler dep #414

Merged
merged 3 commits into from
Mar 22, 2017

Conversation

olivielpeau
Copy link
Member

2.x versions of chef_handler are known to work with the present cookbook (cc @degemer)

Also, adds the dd-handler recipe to the kitchen CI run list

@olivielpeau olivielpeau added this to the 2.9.0 milestone Mar 21, 2017
@olivielpeau olivielpeau force-pushed the olivielpeau/chef-handler-loose-constraint branch from 6344780 to a1d94b1 Compare March 22, 2017 17:25
@olivielpeau olivielpeau force-pushed the olivielpeau/chef-handler-loose-constraint branch from a1d94b1 to fc81da1 Compare March 22, 2017 17:30
Copy link
Member

@degemer degemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Tested with chef_handler 2.1.0, working as expected.

suites:
- name: dd-agent-handler
run_list:
- recipe[datadog::dd-handler]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

# Scope the suites to only execute against the Agent installer suites.
commands.push "kitchen verify dd-agent-#{name}"
# Execute a suite that installs the handler and the Agent.
commands.push "kitchen verify dd-agent-handler-#{name}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@olivielpeau olivielpeau merged commit 05ba57d into master Mar 22, 2017
@olivielpeau olivielpeau deleted the olivielpeau/chef-handler-loose-constraint branch March 22, 2017 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants