Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dd-handler] Bump requirement on chef_handler #396

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

olivielpeau
Copy link
Member

Allows removing the require on our handler, since chef_handler >= 1.2
can take care of requiring our handler. Should fix #338

Keep installing the chef_gem and enabling the handler at compile time
so that the handler can report compilation errors.

Unfortunately we still need to skip the dd-handler recipe in why_run mode with chef_handler 1.4 (see inline comment for link to related issue)

Copy link
Member

@degemer degemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to enable the handler on Circle CI (only place where an error there could actually be detected, as far as I know).
As you said, you could lower the chef_handler requirement to 1.2 if it still works (even though Chef 11 users will have to bump it to at least 1.3).
👍

@olivielpeau olivielpeau force-pushed the olivielpeau/bump-chef-handler-dep branch from e1a7d95 to 75c2e6c Compare January 20, 2017 18:14
@olivielpeau olivielpeau added this to the Triage milestone Jan 24, 2017
@olivielpeau
Copy link
Member Author

Let's wait a bit before merging this, I want to have a quick look at how the requirement bump would play with "the rest of the world" of community cookbooks

@olivielpeau
Copy link
Member Author

Chef 13 seems to require chef_handler 2.x (see #406), would also affect this PR.

@bai
Copy link
Contributor

bai commented Mar 20, 2017

👋 It's almost April and Chef 13 is less than a month away. Are there any blockers on this one — anything I could help with?

@degemer
Copy link
Member

degemer commented Mar 23, 2017

Hello @bai, #414 loosened the requirements on chef_handler which we thought was required for Chef 13. It might actually not be the case (see this comment on the related chef_handler issue).

I tested chef 13.0.64 with both chef_handler 1.4.0 & 2.1.0, and it worked in both cases, so I think we're ready. Please let us know if you encounter an issue with it!

If you wanted to use chef_handler 2.x, we'll release 2.9.0 this week that will allow you to do that.

metadata.rb Outdated Show resolved Hide resolved
Allows removing the `require` on our handler, since chef_handler
can take care of requiring our handler.

Keep installing the chef_gem and enabling the handler at compile time
so that the handler can report compilation errors.

We're compatible with 1.2, we just have to warn Chef 11 users that they
have to use >= 1.3
@olivielpeau olivielpeau force-pushed the olivielpeau/bump-chef-handler-dep branch from 75c2e6c to bacc969 Compare October 30, 2018 19:52
@olivielpeau olivielpeau modified the milestones: Triage, 2.17.0 Oct 30, 2018
@olivielpeau olivielpeau merged commit cc639d9 into master Oct 30, 2018
@olivielpeau olivielpeau deleted the olivielpeau/bump-chef-handler-dep branch October 30, 2018 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to test my cookbook w/ ChefSpec when including datadog::dd-handler
3 participants