Promotion 2023-05-31 (#5252)

[achave11-ucsc]

Connected issue: #5252

Checklist

Author

• Target branch is prod
• Name of PR branch matches promotions/yyyy-mm-dd
• Title of connected issue matches Promotion yyyy-mm-dd
• PR title references the connected issue
• PR title starts with title of connected issue
• PR is connected to issue via ZenHub
• PR description links to connected issue

Author (reindex, API changes)

• Added reindex label to PR _{or this PR does not require reindexing}
• Added API label to connected issue _{or this PR does not modify the Azul service API}

Author (upgrading)

• Added upgrade label to PR _{or this PR does not require upgrading}

Primary reviewer (after approval)

• Actually approved the PR
• Labeled PR as no sandbox
• Moved ticket to Approved column
• Assigned PR to current operator

Operator (before pushing merge the commit)

• Pushed PR branch to GitHub
• Title of merge commit starts with title from this PR
• Added PR reference to merge commit title
• Added commit title tags to merge commit title
• Pushed merge commit to GitHub

Operator (after pushing the merge commit)

• Pushed merge commit to GitLab prod
• Build passes on GitLab prod
• Reviewed build logs for anomalies on GitLab prod
• Deleted PR branch from GitHub
• Deleted PR branch from GitLab prod
• Moved connected issue to Merged prod column on ZenHub
• Moved promoted issues from Merged to Merged prod column on ZenHub
• Moved promoted issues from dev to prod column on ZenHub

Operator (reindex)

• Deleted unreferenced indices in prod _{or this PR does not remove catalogs or otherwise causes unreferenced indices}
• Started reindex in prod _{or this PR does not require reindexing}
• Checked for and triaged indexing failures in prod _{or this PR does not require reindexing}
• Emptied fail queues in prod deployment _{or this PR does not require reindexing}

Operator

• Unassigned PR

Shorthand for review comments

• L line is too long
• W line wrapping is wrong
• Q bad quotes
• F other formatting problem

[coveralls]

Coverage: 84.435% (+0.06%) from 84.373% when pulling 1f28050 on promotions/2023-05-31 into 5093a46 on prod.

[codecov]

Codecov Report

Merging #5253 (1f28050) into prod (be7830d) will increase coverage by 0.06%.
The diff coverage is 97.50%.

@@            Coverage Diff             @@
##             prod    #5253      +/-   ##
==========================================
+ Coverage   84.35%   84.41%   +0.06%     
==========================================
  Files         148      149       +1     
  Lines       18278    18305      +27     
==========================================
+ Hits        15418    15452      +34     
+ Misses       2860     2853       -7     

Impacted Files	Coverage Δ
test/integration_test.py	0.00% <0.00%> (ø)
lambdas/indexer/app.py	95.11% <100.00%> (-0.04%)	⬇️
src/azul/openapi/params.py	100.00% <100.00%> (ø)
src/azul/openapi/spec.py	100.00% <100.00%> (ø)
test/service/test_app_logging.py	98.75% <100.00%> (ø)