Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger UI for indexer is a stub #5051

Closed
14 tasks
nadove-ucsc opened this issue Mar 15, 2023 · 2 comments
Closed
14 tasks

Swagger UI for indexer is a stub #5051

nadove-ucsc opened this issue Mar 15, 2023 · 2 comments
Assignees
Labels
- [priority] Medium debt [type] A defect incurring continued engineering cost demo [process] To be demonstrated at the end of the sprint demoed [process] Successfully demonstrated to team doc [subject] Internal and external documentation enh [type] New feature or request indexer [subject] The indexer part of Azul orange [process] Done by the Azul team

Comments

@nadove-ucsc
Copy link
Contributor

nadove-ucsc commented Mar 15, 2023

This being an internal API, we don't need much high-level documentation. But all endpoints and their parameters should be documented. For the health endpoints a way to reuse the documentation from the service should be devised.

[edit: @hannes-ucsc]

  • Security design review completed; the Resolution of this issue does not
    • … affect authentication; for example:
      • OAuth 2.0 with the application (API or Swagger UI)
      • Authentication of developers with Google Cloud APIs
      • Authentication of developers with AWS APIs
      • Authentication with a GitLab instance in the system
      • Password and 2FA authentication with GitHub
      • API access token authentication with GitHub
      • Authentication with
    • … affect the permissions of internal users like access to
      • Cloud resources on AWS and GCP
      • GitLab repositories, projects and groups, administration
      • an EC2 instance via SSH
      • GitHub issues, pull requests, commits, commit statuses, wikis, repositories, organizations
    • … affect the permissions of external users like access to
      • TDR snapshots
    • … affect permissions of service or bot accounts
      • Cloud resources on AWS and GCP
    • … affect audit logging in the system, like
      • adding, removing or changing a log message that represents an auditable event
      • changing the routing of log messages through the system
    • … affect monitoring of the system
    • … introduce a new software dependency like
      • Python packages on PYPI
      • Command-line utilities
      • Docker images
      • Terraform providers
    • … add an interface that exposes sensitive or confidential data at the security boundary
    • … affect the encryption of data at rest
    • … require persistence of sensitive or confidential data that might require encryption at rest
    • … require unencrypted transmission of data within the security boundary
    • … affect the network security layer; for example by
      • modifying, adding or removing firewall rules
      • modifying, adding or removing security groups
      • changing or adding a port a service, proxy or load balancer listens on
  • Documentation on any unchecked boxes is provided in comments below
@nadove-ucsc nadove-ucsc added orange [process] Done by the Azul team epic [type] Issue consists of multiple smaller issues labels Mar 15, 2023
@nadove-ucsc nadove-ucsc changed the title Indexer Swagger UI for indexer is a stub Mar 15, 2023
nadove-ucsc added a commit that referenced this issue Mar 15, 2023
@dsotirho-ucsc dsotirho-ucsc added doc [subject] Internal and external documentation indexer [subject] The indexer part of Azul enh [type] New feature or request debt [type] A defect incurring continued engineering cost and removed epic [type] Issue consists of multiple smaller issues labels Mar 16, 2023
nadove-ucsc added a commit that referenced this issue Mar 16, 2023
nadove-ucsc added a commit that referenced this issue Mar 23, 2023
nadove-ucsc added a commit that referenced this issue Mar 23, 2023
nadove-ucsc added a commit that referenced this issue Mar 29, 2023
nadove-ucsc added a commit that referenced this issue Mar 29, 2023
nadove-ucsc added a commit that referenced this issue Mar 30, 2023
nadove-ucsc added a commit that referenced this issue Mar 30, 2023
nadove-ucsc added a commit that referenced this issue Mar 30, 2023
nadove-ucsc added a commit that referenced this issue Apr 2, 2023
nadove-ucsc added a commit that referenced this issue Apr 3, 2023
hannes-ucsc pushed a commit that referenced this issue Apr 4, 2023
achave11-ucsc pushed a commit that referenced this issue Apr 5, 2023
@hannes-ucsc hannes-ucsc added the - [priority] Medium label Apr 25, 2023
@nadove-ucsc
Copy link
Contributor Author

Note to self: this and #5059 require coordination due to the changing notification structure

@hannes-ucsc
Copy link
Member

For demo, show Swagger UI for indexer in anvildev.

@hannes-ucsc hannes-ucsc added the demo [process] To be demonstrated at the end of the sprint label May 23, 2023
@nadove-ucsc nadove-ucsc added the demoed [process] Successfully demonstrated to team label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- [priority] Medium debt [type] A defect incurring continued engineering cost demo [process] To be demonstrated at the end of the sprint demoed [process] Successfully demonstrated to team doc [subject] Internal and external documentation enh [type] New feature or request indexer [subject] The indexer part of Azul orange [process] Done by the Azul team
Projects
None yet
Development

No branches or pull requests

3 participants